All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/3] sunxi: Add mmc0 card detect pin for Sinlinx SinA33
@ 2016-09-14  2:26 Chen-Yu Tsai
  2016-09-14  2:26 ` [U-Boot] [PATCH 2/3] sunxi: Enable USB host support " Chen-Yu Tsai
  2016-09-14  2:26 ` [U-Boot] [PATCH 3/3] sunxi: Enable USB gadget " Chen-Yu Tsai
  0 siblings, 2 replies; 4+ messages in thread
From: Chen-Yu Tsai @ 2016-09-14  2:26 UTC (permalink / raw)
  To: u-boot

Sinlinx SinA33 uses PB4 for mmc0 card detect.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 configs/Sinlinx_SinA33_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/Sinlinx_SinA33_defconfig b/configs/Sinlinx_SinA33_defconfig
index 013c35e1a835..77eb05bf251a 100644
--- a/configs/Sinlinx_SinA33_defconfig
+++ b/configs/Sinlinx_SinA33_defconfig
@@ -3,6 +3,7 @@ CONFIG_ARCH_SUNXI=y
 CONFIG_MACH_SUN8I_A33=y
 CONFIG_DRAM_CLK=552
 CONFIG_DRAM_ZQ=15291
+CONFIG_MMC0_CD_PIN="PB4"
 CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-sinlinx-sina33"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL=y
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 2/3] sunxi: Enable USB host support for Sinlinx SinA33
  2016-09-14  2:26 [U-Boot] [PATCH 1/3] sunxi: Add mmc0 card detect pin for Sinlinx SinA33 Chen-Yu Tsai
@ 2016-09-14  2:26 ` Chen-Yu Tsai
  2016-09-17 12:44   ` Hans de Goede
  2016-09-14  2:26 ` [U-Boot] [PATCH 3/3] sunxi: Enable USB gadget " Chen-Yu Tsai
  1 sibling, 1 reply; 4+ messages in thread
From: Chen-Yu Tsai @ 2016-09-14  2:26 UTC (permalink / raw)
  To: u-boot

Sinlinx SinA33 has 1 USB host port. Enable EHCI_HCD support for it.
Also enable USB mass storage support so we can access USB sticks.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 configs/Sinlinx_SinA33_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/configs/Sinlinx_SinA33_defconfig b/configs/Sinlinx_SinA33_defconfig
index 77eb05bf251a..673f3210a1b5 100644
--- a/configs/Sinlinx_SinA33_defconfig
+++ b/configs/Sinlinx_SinA33_defconfig
@@ -9,4 +9,6 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-sinlinx-sina33"
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
+CONFIG_CMD_USB_MASS_STORAGE=y
 # CONFIG_CMD_FPGA is not set
+CONFIG_USB_EHCI_HCD=y
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 3/3] sunxi: Enable USB gadget support for Sinlinx SinA33
  2016-09-14  2:26 [U-Boot] [PATCH 1/3] sunxi: Add mmc0 card detect pin for Sinlinx SinA33 Chen-Yu Tsai
  2016-09-14  2:26 ` [U-Boot] [PATCH 2/3] sunxi: Enable USB host support " Chen-Yu Tsai
@ 2016-09-14  2:26 ` Chen-Yu Tsai
  1 sibling, 0 replies; 4+ messages in thread
From: Chen-Yu Tsai @ 2016-09-14  2:26 UTC (permalink / raw)
  To: u-boot

Sinlinx SinA33 has a USB OTG port, but VBUS is controlled manually from
a jumper pad.

Enable OTG in gadget mode, as well as the download gadget and related
functions.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 configs/Sinlinx_SinA33_defconfig | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/configs/Sinlinx_SinA33_defconfig b/configs/Sinlinx_SinA33_defconfig
index 673f3210a1b5..a3a234fb875a 100644
--- a/configs/Sinlinx_SinA33_defconfig
+++ b/configs/Sinlinx_SinA33_defconfig
@@ -4,11 +4,19 @@ CONFIG_MACH_SUN8I_A33=y
 CONFIG_DRAM_CLK=552
 CONFIG_DRAM_ZQ=15291
 CONFIG_MMC0_CD_PIN="PB4"
+CONFIG_USB0_ID_DET="PH8"
 CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-sinlinx-sina33"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
+CONFIG_CMD_DFU=y
 CONFIG_CMD_USB_MASS_STORAGE=y
 # CONFIG_CMD_FPGA is not set
 CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_MUSB_GADGET=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_G_DNL_MANUFACTURER="Allwinner Technology"
+CONFIG_G_DNL_VENDOR_NUM=0x1f3a
+CONFIG_G_DNL_PRODUCT_NUM=0x1010
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 2/3] sunxi: Enable USB host support for Sinlinx SinA33
  2016-09-14  2:26 ` [U-Boot] [PATCH 2/3] sunxi: Enable USB host support " Chen-Yu Tsai
@ 2016-09-17 12:44   ` Hans de Goede
  0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2016-09-17 12:44 UTC (permalink / raw)
  To: u-boot

Hi,

On 14-09-16 04:26, Chen-Yu Tsai wrote:
> Sinlinx SinA33 has 1 USB host port. Enable EHCI_HCD support for it.
> Also enable USB mass storage support so we can access USB sticks.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  configs/Sinlinx_SinA33_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/configs/Sinlinx_SinA33_defconfig b/configs/Sinlinx_SinA33_defconfig
> index 77eb05bf251a..673f3210a1b5 100644
> --- a/configs/Sinlinx_SinA33_defconfig
> +++ b/configs/Sinlinx_SinA33_defconfig
> @@ -9,4 +9,6 @@ CONFIG_DEFAULT_DEVICE_TREE="sun8i-a33-sinlinx-sina33"
>  CONFIG_SPL=y
>  # CONFIG_CMD_IMLS is not set
>  # CONFIG_CMD_FLASH is not set
> +CONFIG_CMD_USB_MASS_STORAGE=y

If we want to enable CONFIG_CMD_USB_MASS_STORAGE on sunxi, we really
should do so on all boards (feel free to submit a patch for this).

e.g. add something like this to board/sunxi/Kconfig:

config CMD_USB_MASS_STORAGE
	default y

So that we can still disable it in case there are space constraints,
but normally we enable it on all sunxi boards offering a
consistent set of available comments.

So I've dropped this bit of the patch.

Otherwise this series LGTM:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

I've added this to my local queue and this will go out
with the pull-req I plan todo later today.

Regards,

Hans


>  # CONFIG_CMD_FPGA is not set
> +CONFIG_USB_EHCI_HCD=y
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-09-17 12:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14  2:26 [U-Boot] [PATCH 1/3] sunxi: Add mmc0 card detect pin for Sinlinx SinA33 Chen-Yu Tsai
2016-09-14  2:26 ` [U-Boot] [PATCH 2/3] sunxi: Enable USB host support " Chen-Yu Tsai
2016-09-17 12:44   ` Hans de Goede
2016-09-14  2:26 ` [U-Boot] [PATCH 3/3] sunxi: Enable USB gadget " Chen-Yu Tsai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.