All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc/64: whitelist unresolved modversions CRCs
@ 2016-09-14  2:45 Nicholas Piggin
  2016-09-14 23:41 ` Stephen Rothwell
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Nicholas Piggin @ 2016-09-14  2:45 UTC (permalink / raw)
  To: Michal Marek, linux-kbuild
  Cc: Nicholas Piggin, linuxppc-dev, Michael Ellerman, Stephen Rothwell

These are a symptom of CRC generation failure in generic
build code, and not powerpc specific.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---

Hi Michal,

Please merge this via your trees with Al's patches. I have
a patch that can catch crc generation failure generically,
and both Arnd and I have some ideas to fix crc generation
for .S exports. This should get powerpc building again with
your tree.

Thanks,
Nick


 arch/powerpc/relocs_check.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/relocs_check.sh b/arch/powerpc/relocs_check.sh
index 2e4ebd0..ec2d5c8 100755
--- a/arch/powerpc/relocs_check.sh
+++ b/arch/powerpc/relocs_check.sh
@@ -30,6 +30,7 @@ bad_relocs=$(
 	# On PPC64:
 	#	R_PPC64_RELATIVE, R_PPC64_NONE
 	#	R_PPC64_ADDR64 mach_<name>
+	#	R_PPC64_ADDR64 __crc_<name>
 	# On PPC:
 	#	R_PPC_RELATIVE, R_PPC_ADDR16_HI,
 	#	R_PPC_ADDR16_HA,R_PPC_ADDR16_LO,
@@ -41,7 +42,8 @@ R_PPC_ADDR16_HI
 R_PPC_ADDR16_HA
 R_PPC_RELATIVE
 R_PPC_NONE' |
-	grep -E -v '\<R_PPC64_ADDR64[[:space:]]+mach_'
+	grep -E -v '\<R_PPC64_ADDR64[[:space:]]+mach_' |
+	grep -E -v '\<R_PPC64_ADDR64[[:space:]]+__crc_'
 )
 
 if [ -z "$bad_relocs" ]; then
-- 
2.9.3


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] powerpc/64: whitelist unresolved modversions CRCs
  2016-09-14  2:45 [PATCH] powerpc/64: whitelist unresolved modversions CRCs Nicholas Piggin
@ 2016-09-14 23:41 ` Stephen Rothwell
  2016-09-14 23:49 ` Stephen Rothwell
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2016-09-14 23:41 UTC (permalink / raw)
  To: Nicholas Piggin
  Cc: Michal Marek, linux-kbuild, linuxppc-dev, Michael Ellerman

Hi Nick,

On Wed, 14 Sep 2016 12:45:07 +1000 Nicholas Piggin <npiggin@gmail.com> wrote:
>
> These are a symptom of CRC generation failure in generic
> build code, and not powerpc specific.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

OK, so I will use this as a merge fix patch for the kbuild tree today
(instead of the revert I have been doing).

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] powerpc/64: whitelist unresolved modversions CRCs
  2016-09-14  2:45 [PATCH] powerpc/64: whitelist unresolved modversions CRCs Nicholas Piggin
  2016-09-14 23:41 ` Stephen Rothwell
@ 2016-09-14 23:49 ` Stephen Rothwell
  2016-09-15  4:54   ` Michael Ellerman
  2016-09-22 12:48 ` Michal Marek
  3 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2016-09-14 23:49 UTC (permalink / raw)
  To: Nicholas Piggin
  Cc: Michal Marek, linux-kbuild, linuxppc-dev, Michael Ellerman

Hi Nick,

On Wed, 14 Sep 2016 12:45:07 +1000 Nicholas Piggin <npiggin@gmail.com> wrote:
>
> These are a symptom of CRC generation failure in generic
> build code, and not powerpc specific.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

This fixes my build problems.

Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] powerpc/64: whitelist unresolved modversions CRCs
  2016-09-14  2:45 [PATCH] powerpc/64: whitelist unresolved modversions CRCs Nicholas Piggin
@ 2016-09-15  4:54   ` Michael Ellerman
  2016-09-14 23:49 ` Stephen Rothwell
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2016-09-15  4:54 UTC (permalink / raw)
  To: Nicholas Piggin, Michal Marek, linux-kbuild
  Cc: linuxppc-dev, Stephen Rothwell

Nicholas Piggin <npiggin@gmail.com> writes:

> These are a symptom of CRC generation failure in generic
> build code, and not powerpc specific.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

Acked-by: Michael Ellerman <mpe@ellerman.id.au>

cheers

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] powerpc/64: whitelist unresolved modversions CRCs
@ 2016-09-15  4:54   ` Michael Ellerman
  0 siblings, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2016-09-15  4:54 UTC (permalink / raw)
  To: Nicholas Piggin, Michal Marek, linux-kbuild
  Cc: Nicholas Piggin, linuxppc-dev, Stephen Rothwell

Nicholas Piggin <npiggin@gmail.com> writes:

> These are a symptom of CRC generation failure in generic
> build code, and not powerpc specific.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

Acked-by: Michael Ellerman <mpe@ellerman.id.au>

cheers

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] powerpc/64: whitelist unresolved modversions CRCs
  2016-09-14  2:45 [PATCH] powerpc/64: whitelist unresolved modversions CRCs Nicholas Piggin
                   ` (2 preceding siblings ...)
  2016-09-15  4:54   ` Michael Ellerman
@ 2016-09-22 12:48 ` Michal Marek
  3 siblings, 0 replies; 6+ messages in thread
From: Michal Marek @ 2016-09-22 12:48 UTC (permalink / raw)
  To: Nicholas Piggin, linux-kbuild
  Cc: linuxppc-dev, Michael Ellerman, Stephen Rothwell

On 2016-09-14 04:45, Nicholas Piggin wrote:
> These are a symptom of CRC generation failure in generic
> build code, and not powerpc specific.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> 
> Hi Michal,
> 
> Please merge this via your trees with Al's patches.

Done, thanks for the patch.

Michal


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-09-22 12:48 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14  2:45 [PATCH] powerpc/64: whitelist unresolved modversions CRCs Nicholas Piggin
2016-09-14 23:41 ` Stephen Rothwell
2016-09-14 23:49 ` Stephen Rothwell
2016-09-15  4:54 ` Michael Ellerman
2016-09-15  4:54   ` Michael Ellerman
2016-09-22 12:48 ` Michal Marek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.