All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Liu <b-liu@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: kbuild test robot <fengguang.wu@intel.com>, <kbuild-all@01.org>,
	<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>
Subject: Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared
Date: Wed, 14 Sep 2016 08:13:38 -0500	[thread overview]
Message-ID: <20160914131338.GA9442@uda0271908> (raw)
In-Reply-To: <20160913223504.7mdgtipmkltikuyt@atomide.com>

On Tue, Sep 13, 2016 at 03:35:05PM -0700, Tony Lindgren wrote:
> * Bin Liu <b-liu@ti.com> [160908 11:26]:
> > On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote:
> > > --- a/drivers/usb/musb/Kconfig
> > > +++ b/drivers/usb/musb/Kconfig
> > > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
> > >  config USB_MUSB_TUSB6010
> > >  	tristate "TUSB6010"
> > >  	depends on HAS_IOMEM
> > > -	depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > > +	depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN
> > 
> > Would this cause more issue later when trying to enable all glue drivers
> > in one build?
> 
> Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h..
> It completely redefines all the registers with ifdef else.
> 
> > The macros defined in tusb6010.h are only used in tusb6010.c, so how
> > about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c
> > instead? This gives flexibility to random config test, isn't it?
> 
> I'd like to see that but we have this in musb_core.c:
> 
> hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF;
> 
> So the build would break there again on blackin with tusb6010..
> Got any ideas on how to sort that out?

Thanks for catching it. It appears that the glues require more work to
cleanup. I am taking your patch.

Regards,
-Bin.

> 
> Regards,
> 
> Tony

WARNING: multiple messages have this Message-ID (diff)
From: Bin Liu <b-liu@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
	kbuild-all@01.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared
Date: Wed, 14 Sep 2016 08:13:38 -0500	[thread overview]
Message-ID: <20160914131338.GA9442@uda0271908> (raw)
In-Reply-To: <20160913223504.7mdgtipmkltikuyt@atomide.com>

On Tue, Sep 13, 2016 at 03:35:05PM -0700, Tony Lindgren wrote:
> * Bin Liu <b-liu@ti.com> [160908 11:26]:
> > On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote:
> > > --- a/drivers/usb/musb/Kconfig
> > > +++ b/drivers/usb/musb/Kconfig
> > > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
> > >  config USB_MUSB_TUSB6010
> > >  	tristate "TUSB6010"
> > >  	depends on HAS_IOMEM
> > > -	depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > > +	depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN
> > 
> > Would this cause more issue later when trying to enable all glue drivers
> > in one build?
> 
> Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h..
> It completely redefines all the registers with ifdef else.
> 
> > The macros defined in tusb6010.h are only used in tusb6010.c, so how
> > about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c
> > instead? This gives flexibility to random config test, isn't it?
> 
> I'd like to see that but we have this in musb_core.c:
> 
> hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF;
> 
> So the build would break there again on blackin with tusb6010..
> Got any ideas on how to sort that out?

Thanks for catching it. It appears that the glues require more work to
cleanup. I am taking your patch.

Regards,
-Bin.

> 
> Regards,
> 
> Tony

  reply	other threads:[~2016-09-14 13:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-11 20:10 drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared kbuild test robot
2016-09-08 17:45 ` Tony Lindgren
2016-09-08 18:26   ` Bin Liu
2016-09-13 22:35     ` Tony Lindgren
2016-09-14 13:13       ` Bin Liu [this message]
2016-09-14 13:13         ` Bin Liu
2016-09-14 14:35         ` Tony Lindgren
2016-09-14 13:37   ` Bin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160914131338.GA9442@uda0271908 \
    --to=b-liu@ti.com \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.