From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH, RFC] nvme: Do not test the read-ahead flag in cmd_flags
Date: Wed, 14 Sep 2016 16:23:06 +0200 [thread overview]
Message-ID: <20160914142306.GA28616@lst.de> (raw)
In-Reply-To: <30c2c70d-ec2d-607b-3f2f-5b3daa1754cd@sandisk.com>
On Wed, Sep 14, 2016@12:02:22PM +0200, Bart Van Assche wrote:
> REQ_RAHEAD is a bio-only flag (bio.bi_opf) and hence is never set in
> request.cmd_flags. Hence remove the cmd_flags & REQ_RAHEAD tests.
> Compile-tested only.
It's indeed a bug, but the questions is if why we shouldn't pass
REQ_RAHEAD down to the request layer. It's a useful attribute,
and NVMe devices could make use of it.
next prev parent reply other threads:[~2016-09-14 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 10:02 [PATCH, RFC] nvme: Do not test the read-ahead flag in cmd_flags Bart Van Assche
2016-09-14 14:23 ` Christoph Hellwig [this message]
2016-09-14 14:43 ` Jens Axboe
2016-09-14 14:47 ` Christoph Hellwig
2016-09-14 14:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914142306.GA28616@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.