From: axboe@fb.com (Jens Axboe)
Subject: [PATCH, RFC] nvme: Do not test the read-ahead flag in cmd_flags
Date: Wed, 14 Sep 2016 08:54:06 -0600 [thread overview]
Message-ID: <4c27bf68-e2b3-2ad2-ddd3-8f5189ebec21@fb.com> (raw)
In-Reply-To: <20160914144715.GA29336@lst.de>
On 09/14/2016 08:47 AM, Christoph Hellwig wrote:
> On Wed, Sep 14, 2016@08:43:48AM -0600, Jens Axboe wrote:
>>> It's indeed a bug, but the questions is if why we shouldn't pass
>>> REQ_RAHEAD down to the request layer. It's a useful attribute,
>>> and NVMe devices could make use of it.
>>
>> Indeed, seems a shame to lose this hint.
>
> It currently doesn't work. But it would be useful to actually pass
Right, hence we lose it when mapping from a bio to a request.
> it through. That being said we currently have a complete mess with
> the common vs request only flags, both about their placement in the
> enum and inclusion in the common mask. Making it worse it seems
> like REQ_NOMERGE actually is used in both currently and not actually
> expecting propagation.
It would be nice to harden that.
--
Jens Axboe
prev parent reply other threads:[~2016-09-14 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 10:02 [PATCH, RFC] nvme: Do not test the read-ahead flag in cmd_flags Bart Van Assche
2016-09-14 14:23 ` Christoph Hellwig
2016-09-14 14:43 ` Jens Axboe
2016-09-14 14:47 ` Christoph Hellwig
2016-09-14 14:54 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c27bf68-e2b3-2ad2-ddd3-8f5189ebec21@fb.com \
--to=axboe@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.