[PATCH] arm64: dts: r8a7796 salvator-x: External SCIF3/HSCIF3 loop

[PATCH] arm64: dts: r8a7796 salvator-x: External SCIF3/HSCIF3 loop

[Ulrich Hecht]

Add SCIF3 and HSCIF3 as two new serial ports to the r8a7796
Salvator-X DT file.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
index bdf6e05..2636742 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
@@ -18,6 +18,8 @@
 
 	aliases {
 		serial0 = &scif2;
+		serial2 = &scif3;
+		serial3 = &hscif3;
 	};
 
 	chosen {
@@ -89,6 +91,14 @@
 		groups = "scif2_data_a";
 		function = "scif2";
 	};
+	scif3_pins: scif3 { /* TX: 1_11, RX: 1_8 */
+		groups = "scif3_data_b";
+		function = "scif3";
+	};
+	hscif3_pins: hscif3 { /* TX: 2_8, RX: 2_7 */
+		groups = "hscif3_data_d";
+		function = "hscif3";
+	};
 	scif_clk_pins: scif_clk {
 		groups = "scif_clk_a";
 		function = "scif_clk";
@@ -138,6 +148,22 @@
 	status = "okay";
 };
 
+&scif3 {
+	pinctrl-0 = <&scif3_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
+/* SCIF3 TX -> HSCIF3 RX, HSCIF3 TX -> SCIF3 RX */
+
+&hscif3 {
+	pinctrl-0 = <&hscif3_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
 &scif2 {
 	pinctrl-0 = <&scif2_pins>;
 	pinctrl-names = "default";
-- 
2.9.3

Re: [PATCH] arm64: dts: r8a7796 salvator-x: External SCIF3/HSCIF3 loop

[Simon Horman]

On Wed, Sep 14, 2016 at 06:47:41PM +0200, Ulrich Hecht wrote:
> Add SCIF3 and HSCIF3 as two new serial ports to the r8a7796
> Salvator-X DT file.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Please repost once the (at least DT) dependencies have been merged
(or at least reposted).

Re: [PATCH] arm64: dts: r8a7796 salvator-x: External SCIF3/HSCIF3 loop

[Geert Uytterhoeven]

Hi Simon,

On Fri, Sep 16, 2016 at 12:14 PM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Sep 14, 2016 at 06:47:41PM +0200, Ulrich Hecht wrote:
>> Add SCIF3 and HSCIF3 as two new serial ports to the r8a7796
>> Salvator-X DT file.
>>
>> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
>
> Please repost once the (at least DT) dependencies have been merged
> (or at least reposted).

As this is for testing (H)SCIF only, and requires external wiring,
I think this is something we do not want to upstream.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds