Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[Joakim Tjernlund]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

These patches are picked from Linux upstream repo and applies directly on 4.4.x
Please excuse the attachments but git send email does not work for us ATM.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch --]
[-- Type: text/x-patch; name="0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch", Size: 6159 bytes --]

From 6cf4a2c575b4797b967a575b6274e0e40c5f88f1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali.rohar@gmail.com>
Date: Wed, 30 Dec 2015 23:27:41 +0100
Subject: [PATCH 2/6] thinkpad_acpi: Add support for keyboard backlight
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This patch adds support for controlling keyboard backlight via standard
linux led class interface (::kbd_backlight). It uses ACPI HKEY device with
MLCG and MLCS methods.

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Tested-by: Fabio D'Urso <fabiodurso@hotmail.it>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
---
 drivers/platform/x86/thinkpad_acpi.c | 206 +++++++++++++++++++++++++++++++++++
 1 file changed, 206 insertions(+)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index f453d5d..1f0eda2 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -303,6 +303,7 @@ static struct {
 	u32 hotkey_mask:1;
 	u32 hotkey_wlsw:1;
 	u32 hotkey_tablet:1;
+	u32 kbdlight:1;
 	u32 light:1;
 	u32 light_status:1;
 	u32 bright_acpimode:1;
@@ -4986,6 +4987,207 @@ static struct ibm_struct video_driver_data = {
 #endif /* CONFIG_THINKPAD_ACPI_VIDEO */
 
 /*************************************************************************
+ * Keyboard backlight subdriver
+ */
+
+static int kbdlight_set_level(int level)
+{
+	if (!hkey_handle)
+		return -ENXIO;
+
+	if (!acpi_evalf(hkey_handle, NULL, "MLCS", "dd", level))
+		return -EIO;
+
+	return 0;
+}
+
+static int kbdlight_get_level(void)
+{
+	int status = 0;
+
+	if (!hkey_handle)
+		return -ENXIO;
+
+	if (!acpi_evalf(hkey_handle, &status, "MLCG", "dd", 0))
+		return -EIO;
+
+	if (status < 0)
+		return status;
+
+	return status & 0x3;
+}
+
+static bool kbdlight_is_supported(void)
+{
+	int status = 0;
+
+	if (!hkey_handle)
+		return false;
+
+	if (!acpi_has_method(hkey_handle, "MLCG")) {
+		vdbg_printk(TPACPI_DBG_INIT, "kbdlight MLCG is unavailable\n");
+		return false;
+	}
+
+	if (!acpi_evalf(hkey_handle, &status, "MLCG", "qdd", 0)) {
+		vdbg_printk(TPACPI_DBG_INIT, "kbdlight MLCG failed\n");
+		return false;
+	}
+
+	if (status < 0) {
+		vdbg_printk(TPACPI_DBG_INIT, "kbdlight MLCG err: %d\n", status);
+		return false;
+	}
+
+	vdbg_printk(TPACPI_DBG_INIT, "kbdlight MLCG returned 0x%x\n", status);
+	/*
+	 * Guessed test for keyboard backlight:
+	 *
+	 * Machines with backlight keyboard return:
+	 *   b010100000010000000XX - ThinkPad X1 Carbon 3rd
+	 *   b110100010010000000XX - ThinkPad x230
+	 *   b010100000010000000XX - ThinkPad x240
+	 *   b010100000010000000XX - ThinkPad W541
+	 * (XX is current backlight level)
+	 *
+	 * Machines without backlight keyboard return:
+	 *   b10100001000000000000 - ThinkPad x230
+	 *   b10110001000000000000 - ThinkPad E430
+	 *   b00000000000000000000 - ThinkPad E450
+	 *
+	 * Candidate BITs for detection test (XOR):
+	 *   b01000000001000000000
+	 *              ^
+	 */
+	return status & BIT(9);
+}
+
+static void kbdlight_set_worker(struct work_struct *work)
+{
+	struct tpacpi_led_classdev *data =
+			container_of(work, struct tpacpi_led_classdev, work);
+
+	if (likely(tpacpi_lifecycle == TPACPI_LIFE_RUNNING))
+		kbdlight_set_level(data->new_state);
+}
+
+static void kbdlight_sysfs_set(struct led_classdev *led_cdev,
+			enum led_brightness brightness)
+{
+	struct tpacpi_led_classdev *data =
+			container_of(led_cdev,
+				     struct tpacpi_led_classdev,
+				     led_classdev);
+	data->new_state = brightness;
+	queue_work(tpacpi_wq, &data->work);
+}
+
+static enum led_brightness kbdlight_sysfs_get(struct led_classdev *led_cdev)
+{
+	int level;
+
+	level = kbdlight_get_level();
+	if (level < 0)
+		return 0;
+
+	return level;
+}
+
+static struct tpacpi_led_classdev tpacpi_led_kbdlight = {
+	.led_classdev = {
+		.name		= "tpacpi::kbd_backlight",
+		.max_brightness	= 2,
+		.brightness_set	= &kbdlight_sysfs_set,
+		.brightness_get	= &kbdlight_sysfs_get,
+		.flags		= LED_CORE_SUSPENDRESUME,
+	}
+};
+
+static int __init kbdlight_init(struct ibm_init_struct *iibm)
+{
+	int rc;
+
+	vdbg_printk(TPACPI_DBG_INIT, "initializing kbdlight subdriver\n");
+
+	TPACPI_ACPIHANDLE_INIT(hkey);
+	INIT_WORK(&tpacpi_led_kbdlight.work, kbdlight_set_worker);
+
+	if (!kbdlight_is_supported()) {
+		tp_features.kbdlight = 0;
+		vdbg_printk(TPACPI_DBG_INIT, "kbdlight is unsupported\n");
+		return 1;
+	}
+
+	tp_features.kbdlight = 1;
+
+	rc = led_classdev_register(&tpacpi_pdev->dev,
+				   &tpacpi_led_kbdlight.led_classdev);
+	if (rc < 0) {
+		tp_features.kbdlight = 0;
+		return rc;
+	}
+
+	return 0;
+}
+
+static void kbdlight_exit(void)
+{
+	if (tp_features.kbdlight)
+		led_classdev_unregister(&tpacpi_led_kbdlight.led_classdev);
+	flush_workqueue(tpacpi_wq);
+}
+
+static int kbdlight_read(struct seq_file *m)
+{
+	int level;
+
+	if (!tp_features.kbdlight) {
+		seq_printf(m, "status:\t\tnot supported\n");
+	} else {
+		level = kbdlight_get_level();
+		if (level < 0)
+			seq_printf(m, "status:\t\terror %d\n", level);
+		else
+			seq_printf(m, "status:\t\t%d\n", level);
+		seq_printf(m, "commands:\t0, 1, 2\n");
+	}
+
+	return 0;
+}
+
+static int kbdlight_write(char *buf)
+{
+	char *cmd;
+	int level = -1;
+
+	if (!tp_features.kbdlight)
+		return -ENODEV;
+
+	while ((cmd = next_cmd(&buf))) {
+		if (strlencmp(cmd, "0") == 0)
+			level = 0;
+		else if (strlencmp(cmd, "1") == 0)
+			level = 1;
+		else if (strlencmp(cmd, "2") == 0)
+			level = 2;
+		else
+			return -EINVAL;
+	}
+
+	if (level == -1)
+		return -EINVAL;
+
+	return kbdlight_set_level(level);
+}
+
+static struct ibm_struct kbdlight_driver_data = {
+	.name = "kbdlight",
+	.read = kbdlight_read,
+	.write = kbdlight_write,
+	.exit = kbdlight_exit,
+};
+
+/*************************************************************************
  * Light (thinklight) subdriver
  */
 
@@ -9207,6 +9409,10 @@ static struct ibm_init_struct ibms_init[] __initdata = {
 	},
 #endif
 	{
+		.init = kbdlight_init,
+		.data = &kbdlight_driver_data,
+	},
+	{
 		.init = light_init,
 		.data = &light_driver_data,
 	},
-- 
2.7.3


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch --]
[-- Type: text/x-patch; name="0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch", Size: 1034 bytes --]

From dcf95a1961f9614eee09066f8148813772ad4268 Mon Sep 17 00:00:00 2001
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 15 Apr 2016 17:46:34 +0300
Subject: [PATCH 4/6] thinkpad_acpi: Silence an uninitialized variable warning

If fan_get_status() fails then "s" is not initialized.  Tweak the error
handling a bit to silence this warning.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
---
 drivers/platform/x86/thinkpad_acpi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 0e0fade..b684904 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -7972,10 +7972,12 @@ static int fan_get_status_safe(u8 *status)
 		fan_update_desired_level(s);
 	mutex_unlock(&fan_mutex);
 
+	if (rc)
+		return rc;
 	if (status)
 		*status = s;
 
-	return rc;
+	return 0;
 }
 
 static int fan_get_speed(unsigned int *speed)
-- 
2.7.3


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: 0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch --]
[-- Type: text/x-patch; name="0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch", Size: 1410 bytes --]

From 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a Mon Sep 17 00:00:00 2001
From: Eric Curtin <ericcurtin17@gmail.com>
Date: Sat, 30 Jan 2016 16:55:59 +0000
Subject: [PATCH 3/6] thinkpad_acpi: Remove ambiguous logging for "Unsupported
 brightness interface"

"Unsupported brightness interface" message gets logged on
 machines that are well supported.

Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
---
 drivers/platform/x86/thinkpad_acpi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 1f0eda2..0e0fade 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6653,18 +6653,16 @@ static void __init tpacpi_detect_brightness_capabilities(void)
 	switch (b) {
 	case 16:
 		bright_maxlvl = 15;
-		pr_info("detected a 16-level brightness capable ThinkPad\n");
 		break;
 	case 8:
 	case 0:
 		bright_maxlvl = 7;
-		pr_info("detected a 8-level brightness capable ThinkPad\n");
 		break;
 	default:
-		pr_info("Unsupported brightness interface\n");
 		tp_features.bright_unkfw = 1;
 		bright_maxlvl = b - 1;
 	}
+	pr_debug("detected %u brightness levels\n", bright_maxlvl + 1);
 }
 
 static int __init brightness_init(struct ibm_init_struct *iibm)
-- 
2.7.3


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #5: 0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch --]
[-- Type: text/x-patch; name="0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch", Size: 5807 bytes --]

From 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2 Mon Sep 17 00:00:00 2001
From: Dennis Wassenberg <dennis.wassenberg@secunet.com>
Date: Wed, 8 Jun 2016 10:54:25 -0400
Subject: [PATCH 6/6] thinkpad_acpi: Add support for HKEY version 0x200

Lenovo Thinkpad devices T460, T460s, T460p, T560, X260 use
HKEY version 0x200 without adaptive keyboard.

HKEY version 0x200 has method MHKA with one parameter value.
Passing parameter value 1 will get hotkey_all_mask (the same like
HKEY version 0x100 without parameter). Passing parameter value 2 to
MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in
that case there is no adaptive keyboard available.

Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
Signed-off-by: Lyude <cpaul@redhat.com>
Tested-by: Lyude <cpaul@redhat.com>
Tested-by: Marco Trevisan <marco@ubuntu.com>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
[dvhart: Keep MHKA error string on one line in new and existing pr_err calls]
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
---
 drivers/platform/x86/thinkpad_acpi.c | 87 ++++++++++++++++++++++++++----------
 1 file changed, 63 insertions(+), 24 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index ad48123..1011c0a 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -2043,6 +2043,7 @@ static int hotkey_autosleep_ack;
 
 static u32 hotkey_orig_mask;		/* events the BIOS had enabled */
 static u32 hotkey_all_mask;		/* all events supported in fw */
+static u32 hotkey_adaptive_all_mask;	/* all adaptive events supported in fw */
 static u32 hotkey_reserved_mask;	/* events better left disabled */
 static u32 hotkey_driver_mask;		/* events needed by the driver */
 static u32 hotkey_user_mask;		/* events visible to userspace */
@@ -2742,6 +2743,17 @@ static ssize_t hotkey_all_mask_show(struct device *dev,
 
 static DEVICE_ATTR_RO(hotkey_all_mask);
 
+/* sysfs hotkey all_mask ----------------------------------------------- */
+static ssize_t hotkey_adaptive_all_mask_show(struct device *dev,
+			   struct device_attribute *attr,
+			   char *buf)
+{
+	return snprintf(buf, PAGE_SIZE, "0x%08x\n",
+			hotkey_adaptive_all_mask | hotkey_source_mask);
+}
+
+static DEVICE_ATTR_RO(hotkey_adaptive_all_mask);
+
 /* sysfs hotkey recommended_mask --------------------------------------- */
 static ssize_t hotkey_recommended_mask_show(struct device *dev,
 					    struct device_attribute *attr,
@@ -2985,6 +2997,7 @@ static struct attribute *hotkey_attributes[] __initdata = {
 	&dev_attr_wakeup_hotunplug_complete.attr,
 	&dev_attr_hotkey_mask.attr,
 	&dev_attr_hotkey_all_mask.attr,
+	&dev_attr_hotkey_adaptive_all_mask.attr,
 	&dev_attr_hotkey_recommended_mask.attr,
 #ifdef CONFIG_THINKPAD_ACPI_HOTKEY_POLL
 	&dev_attr_hotkey_source_mask.attr,
@@ -3321,20 +3334,6 @@ static int __init hotkey_init(struct ibm_init_struct *iibm)
 	if (!tp_features.hotkey)
 		return 1;
 
-	/*
-	 * Check if we have an adaptive keyboard, like on the
-	 * Lenovo Carbon X1 2014 (2nd Gen).
-	 */
-	if (acpi_evalf(hkey_handle, &hkeyv, "MHKV", "qd")) {
-		if ((hkeyv >> 8) == 2) {
-			tp_features.has_adaptive_kbd = true;
-			res = sysfs_create_group(&tpacpi_pdev->dev.kobj,
-					&adaptive_kbd_attr_group);
-			if (res)
-				goto err_exit;
-		}
-	}
-
 	quirks = tpacpi_check_quirks(tpacpi_hotkey_qtable,
 				     ARRAY_SIZE(tpacpi_hotkey_qtable));
 
@@ -3357,30 +3356,70 @@ static int __init hotkey_init(struct ibm_init_struct *iibm)
 	   A30, R30, R31, T20-22, X20-21, X22-24.  Detected by checking
 	   for HKEY interface version 0x100 */
 	if (acpi_evalf(hkey_handle, &hkeyv, "MHKV", "qd")) {
-		if ((hkeyv >> 8) != 1) {
-			pr_err("unknown version of the HKEY interface: 0x%x\n",
-			       hkeyv);
-			pr_err("please report this to %s\n", TPACPI_MAIL);
-		} else {
+		vdbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_HKEY,
+			    "firmware HKEY interface version: 0x%x\n",
+			    hkeyv);
+
+		switch (hkeyv >> 8) {
+		case 1:
 			/*
 			 * MHKV 0x100 in A31, R40, R40e,
 			 * T4x, X31, and later
 			 */
-			vdbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_HKEY,
-				"firmware HKEY interface version: 0x%x\n",
-				hkeyv);
 
 			/* Paranoia check AND init hotkey_all_mask */
 			if (!acpi_evalf(hkey_handle, &hotkey_all_mask,
 					"MHKA", "qd")) {
-				pr_err("missing MHKA handler, "
-				       "please report this to %s\n",
+				pr_err("missing MHKA handler, please report this to %s\n",
 				       TPACPI_MAIL);
 				/* Fallback: pre-init for FN+F3,F4,F12 */
 				hotkey_all_mask = 0x080cU;
 			} else {
 				tp_features.hotkey_mask = 1;
 			}
+			break;
+
+		case 2:
+			/*
+			 * MHKV 0x200 in X1, T460s, X260, T560, X1 Tablet (2016)
+			 */
+
+			/* Paranoia check AND init hotkey_all_mask */
+			if (!acpi_evalf(hkey_handle, &hotkey_all_mask,
+					"MHKA", "dd", 1)) {
+				pr_err("missing MHKA handler, please report this to %s\n",
+				       TPACPI_MAIL);
+				/* Fallback: pre-init for FN+F3,F4,F12 */
+				hotkey_all_mask = 0x080cU;
+			} else {
+				tp_features.hotkey_mask = 1;
+			}
+
+			/*
+			 * Check if we have an adaptive keyboard, like on the
+			 * Lenovo Carbon X1 2014 (2nd Gen).
+			 */
+			if (acpi_evalf(hkey_handle, &hotkey_adaptive_all_mask,
+				       "MHKA", "dd", 2)) {
+				if (hotkey_adaptive_all_mask != 0) {
+					tp_features.has_adaptive_kbd = true;
+					res = sysfs_create_group(
+						&tpacpi_pdev->dev.kobj,
+						&adaptive_kbd_attr_group);
+					if (res)
+						goto err_exit;
+				}
+			} else {
+				tp_features.has_adaptive_kbd = false;
+				hotkey_adaptive_all_mask = 0x0U;
+			}
+			break;
+
+		default:
+			pr_err("unknown version of the HKEY interface: 0x%x\n",
+			       hkeyv);
+			pr_err("please report this to %s\n", TPACPI_MAIL);
+			break;
 		}
 	}
 
-- 
2.7.3


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #6: 0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-res.patch --]
[-- Type: text/x-patch; name="0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-res.patch", Size: 3095 bytes --]

From 1c6c99c6767035761d17aeecaf0224934ccd00fb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marco=20Trevisan=20=28Trevi=C3=B1o=29?= <mail@3v1n0.net>
Date: Tue, 24 May 2016 00:39:51 +0200
Subject: [PATCH 5/6] thinkpad_acpi: save kbdlight state on suspend and restore
 it on resume
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Override default LED class suspend/resume handles, by keeping track of
the brightness level before suspending so that it can be automatically
restored on resume by calling default resume handler.

Signed-off-by: Marco Trevisan (Treviño) <mail@3v1n0.net>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
---
 drivers/platform/x86/thinkpad_acpi.c | 43 +++++++++++++++++++++++++++++++++---
 1 file changed, 40 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index b684904..ad48123 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -5001,6 +5001,8 @@ static int kbdlight_set_level(int level)
 	return 0;
 }
 
+static int kbdlight_set_level_and_update(int level);
+
 static int kbdlight_get_level(void)
 {
 	int status = 0;
@@ -5068,7 +5070,7 @@ static void kbdlight_set_worker(struct work_struct *work)
 			container_of(work, struct tpacpi_led_classdev, work);
 
 	if (likely(tpacpi_lifecycle == TPACPI_LIFE_RUNNING))
-		kbdlight_set_level(data->new_state);
+		kbdlight_set_level_and_update(data->new_state);
 }
 
 static void kbdlight_sysfs_set(struct led_classdev *led_cdev,
@@ -5099,7 +5101,6 @@ static struct tpacpi_led_classdev tpacpi_led_kbdlight = {
 		.max_brightness	= 2,
 		.brightness_set	= &kbdlight_sysfs_set,
 		.brightness_get	= &kbdlight_sysfs_get,
-		.flags		= LED_CORE_SUSPENDRESUME,
 	}
 };
 
@@ -5137,6 +5138,20 @@ static void kbdlight_exit(void)
 	flush_workqueue(tpacpi_wq);
 }
 
+static int kbdlight_set_level_and_update(int level)
+{
+	int ret;
+	struct led_classdev *led_cdev;
+
+	ret = kbdlight_set_level(level);
+	led_cdev = &tpacpi_led_kbdlight.led_classdev;
+
+	if (ret == 0 && !(led_cdev->flags & LED_SUSPENDED))
+		led_cdev->brightness = level;
+
+	return ret;
+}
+
 static int kbdlight_read(struct seq_file *m)
 {
 	int level;
@@ -5177,13 +5192,35 @@ static int kbdlight_write(char *buf)
 	if (level == -1)
 		return -EINVAL;
 
-	return kbdlight_set_level(level);
+	return kbdlight_set_level_and_update(level);
+}
+
+static void kbdlight_suspend(void)
+{
+	struct led_classdev *led_cdev;
+
+	if (!tp_features.kbdlight)
+		return;
+
+	led_cdev = &tpacpi_led_kbdlight.led_classdev;
+	led_update_brightness(led_cdev);
+	led_classdev_suspend(led_cdev);
+}
+
+static void kbdlight_resume(void)
+{
+	if (!tp_features.kbdlight)
+		return;
+
+	led_classdev_resume(&tpacpi_led_kbdlight.led_classdev);
 }
 
 static struct ibm_struct kbdlight_driver_data = {
 	.name = "kbdlight",
 	.read = kbdlight_read,
 	.write = kbdlight_write,
+	.suspend = kbdlight_suspend,
+	.resume = kbdlight_resume,
 	.exit = kbdlight_exit,
 };
 
-- 
2.7.3

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[Greg KH]

On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> These patches are picked from Linux upstream repo and applies directly on 4.4.x
> Please excuse the attachments but git send email does not work for us ATM.

What is the git commit ids of these patches in Linus's tree?

And what happened to the other patches in this series?

thanks,

greg k-h

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[Willy Tarreau]

On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> These patches are picked from Linux upstream repo and applies directly on 4.4.x
> Please excuse the attachments but git send email does not work for us ATM.

> From 6cf4a2c575b4797b967a575b6274e0e40c5f88f1 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali.rohar@gmail.com>
> Date: Wed, 30 Dec 2015 23:27:41 +0100
> Subject: [PATCH 2/6] thinkpad_acpi: Add support for keyboard backlight
(...)
1/6 is apparently missing, and none of these patches provide the upstream
commit ID.

Regards,
Willy

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[Joakim Tjernlund]

On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> > 
> > These patches are picked from Linux upstream repo and applies directly on 4.4.x
> > Please excuse the attachments but git send email does not work for us ATM.
> 
> What is the git commit ids of these patches in Linus's tree?
0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch: 6cf4a2c575b4797b967a575b6274e0e40c5f88f1
0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch: 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a
0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch: dcf95a1961f9614eee09066f8148813772ad4268
0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-res.patch:1c6c99c6767035761d17aeecaf0224934ccd00fb
0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch: 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2
> 
> And what happened to the other patches in this series?
> 
The first one was inappropriate, that is why 0001 is missing.

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[Joakim Tjernlund]

On Wed, 2016-09-14 at 13:57 +0200, Willy Tarreau wrote:
> On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> > 
> > These patches are picked from Linux upstream repo and applies directly on 4.4.x
> > Please excuse the attachments but git send email does not work for us ATM.
> 
> > 
> > From 6cf4a2c575b4797b967a575b6274e0e40c5f88f1 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali.rohar@gmail.com>
> > Date: Wed, 30 Dec 2015 23:27:41 +0100
> > Subject: [PATCH 2/6] thinkpad_acpi: Add support for keyboard backlight
> (...)
> 1/6 is apparently missing, and none of these patches provide the upstream
> commit ID.

It is missing because I initially fetched the 6 latest patches
from Linus tree only to discover that the first one was inappropriate
for 4.4.x and I was to lazy to renumber the 5 remaining ones.

 Jocke

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[greg]

On Wed, Sep 14, 2016 at 12:00:04PM +0000, Joakim Tjernlund wrote:
> On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> > On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> > > 
> > > These patches are picked from Linux upstream repo and applies directly on 4.4.x
> > > Please excuse the attachments but git send email does not work for us ATM.
> > 
> > What is the git commit ids of these patches in Linus's tree?
> 0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch: 6cf4a2c575b4797b967a575b6274e0e40c5f88f1

I do not see that git commit id in Linus's tree, do you?

> 0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch: 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a

Nor this one.  I stopped here, assuming that your other ids aren't
correct either :(

> 0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch: dcf95a1961f9614eee09066f8148813772ad4268
> 0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-res.patch:1c6c99c6767035761d17aeecaf0224934ccd00fb
> 0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch: 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2
> > 
> > And what happened to the other patches in this series?
> >�
> The first one was inappropriate, that is why 0001 is missing.

That's pretty strange of you to force us to guess what is going on here,
would you like to get a series like this and wonder why something
obvious like this is gone?

Please be more considerate.

thanks,

greg k-h

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[Joakim Tjernlund]

On Wed, 2016-09-14 at 16:35 +0200, greg@kroah.com wrote:
> On Wed, Sep 14, 2016 at 12:00:04PM +0000, Joakim Tjernlund wrote:
> > 
> > On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> > > 
> > > On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> > > > 
> > > > 
> > > > These patches are picked from Linux upstream repo and applies directly on 4.4.x
> > > > Please excuse the attachments but git send email does not work for us ATM.
> > > 
> > > What is the git commit ids of these patches in Linus's tree?
> > 0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch: 6cf4a2c575b4797b967a575b6274e0e40c5f88f1
> 
> I do not see that git commit id in Linus's tree, do you?

ehh, no. I used my 4.4 branch instead of linux master, sorry

> 
> > 
> > 0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch: 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a
> 
> Nor this one.  I stopped here, assuming that your other ids aren't
> correct either :(
> 
> > 
> > 0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch: dcf95a1961f9614eee09066f8148813772ad4268
> > 0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-res.patch:1c6c99c6767035761d17aeecaf0224934ccd00fb
> > 0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch: 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2
> > > 
> > > 
> > > And what happened to the other patches in this series?
> > >  
> > The first one was inappropriate, that is why 0001 is missing.
> 
> That's pretty strange of you to force us to guess what is going on here,
> would you like to get a series like this and wonder why something
> obvious like this is gone?

Yes, it was inconsiderate of me, sorry.

Trying to do better I figured I should generate a new series from Linus tree but
I cannot figure out how generate a series from commits that are non sequential in Linux tree.
git format path does not have a syntax for that from what I can tell, any ideas?

  Jocke

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[greg]

On Wed, Sep 14, 2016 at 04:13:52PM +0000, Joakim Tjernlund wrote:
> On Wed, 2016-09-14 at 16:35 +0200, greg@kroah.com wrote:
> > On Wed, Sep 14, 2016 at 12:00:04PM +0000, Joakim Tjernlund wrote:
> > > 
> > > On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> > > > 
> > > > On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> > > > > 
> > > > > 
> > > > > These patches are picked from Linux upstream repo and applies directly on 4.4.x
> > > > > Please excuse the attachments but git send email does not work for us ATM.
> > > > 
> > > > What is the git commit ids of these patches in Linus's tree?
> > > 0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch: 6cf4a2c575b4797b967a575b6274e0e40c5f88f1
> > 
> > I do not see that git commit id in Linus's tree, do you?
> 
> ehh, no. I used my 4.4 branch instead of linux master, sorry
> 
> > 
> > > 
> > > 0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch: 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a
> > 
> > Nor this one.��I stopped here, assuming that your other ids aren't
> > correct either :(
> > 
> > > 
> > > 0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch: dcf95a1961f9614eee09066f8148813772ad4268
> > > 0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-res.patch:1c6c99c6767035761d17aeecaf0224934ccd00fb
> > > 0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch: 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2
> > > > 
> > > > 
> > > > And what happened to the other patches in this series?
> > > > �
> > > The first one was inappropriate, that is why 0001 is missing.
> > 
> > That's pretty strange of you to force us to guess what is going on here,
> > would you like to get a series like this and wonder why something
> > obvious like this is gone?
> 
> Yes, it was inconsiderate of me, sorry.
> 
> Trying to do better I figured I should generate a new series from Linus tree but
> I cannot figure out how generate a series from commits that are non sequential in Linux tree.
> git format path does not have a syntax for that from what I can tell, any ideas?

Why not just send us the git commit ids that you want applied?  That's
all we need.

thanks,

greg k-h

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[Joakim Tjernlund]

On Wed, 2016-09-14 at 19:08 +0200, greg@kroah.com wrote:
> On Wed, Sep 14, 2016 at 04:13:52PM +0000, Joakim Tjernlund wrote:
> > 
> > On Wed, 2016-09-14 at 16:35 +0200, greg@kroah.com wrote:
> > > 
> > > On Wed, Sep 14, 2016 at 12:00:04PM +0000, Joakim Tjernlund wrote:
> > > > 
> > > > 
> > > > On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> > > > > 
> > > > > 
> > > > > On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > These patches are picked from Linux upstream repo and applies directly on 4.4.x
> > > > > > Please excuse the attachments but git send email does not work for us ATM.
> > > > > 
> > > > > What is the git commit ids of these patches in Linus's tree?
> > > > 0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch: 6cf4a2c575b4797b967a575b6274e0e40c5f88f1
> > > 
> > > I do not see that git commit id in Linus's tree, do you?
> > 
> > ehh, no. I used my 4.4 branch instead of linux master, sorry
> > 
> > > 
> > > 
> > > > 
> > > > 
> > > > 0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch:
> > > > 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a
> > > 
> > > Nor this one.  I stopped here, assuming that your other ids aren't
> > > correct either :(
> > > 
> > > > 
> > > > 
> > > > 0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch:
> > > > dcf95a1961f9614eee09066f8148813772ad4268
> > > > 0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-
> > > > res.patch:1c6c99c6767035761d17aeecaf0224934ccd00fb
> > > > 0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch: 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2
> > > > > 
> > > > > 
> > > > > 
> > > > > And what happened to the other patches in this series?
> > > > >  
> > > > The first one was inappropriate, that is why 0001 is missing.
> > > 
> > > That's pretty strange of you to force us to guess what is going on here,
> > > would you like to get a series like this and wonder why something
> > > obvious like this is gone?
> > 
> > Yes, it was inconsiderate of me, sorry.
> > 
> > Trying to do better I figured I should generate a new series from Linus tree but
> > I cannot figure out how generate a series from commits that are non sequential in Linux tree.
> > git format path does not have a syntax for that from what I can tell, any ideas?
> 
> Why not just send us the git commit ids that you want applied?  That's
> all we need.
> 
Oh, didn't occur to me. Here we go(ltes se fi I got it right this time :)

bb28f3d51ff5e1be541d057708011cc1efe6fae9 - thinkpad_acpi: Add support for keyboard backlight
15c75626f0999cce8357c8bf8578247134032acb - thinkpad_acpi: Remove ambiguous logging for "Unsupported brightness interface"
a7718360d91eedbedd58978ec8fff4a67a866f86 - thinkpad_acpi: Silence an uninitialized variable warning
afcedebc6a094224973534f43b396bbbf33fe44e - thinkpad_acpi: save kbdlight state on suspend and restore it on resume
0118c2d3eac0545d4095877e5a015b5dc763b3c2 - thinkpad_acpi: Add support for HKEY version 0x200

These are all that are missing from this file compared to what is upstream.

 Jocke

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[greg]

On Wed, Sep 14, 2016 at 05:57:30PM +0000, Joakim Tjernlund wrote:
> On Wed, 2016-09-14 at 19:08 +0200, greg@kroah.com wrote:
> > On Wed, Sep 14, 2016 at 04:13:52PM +0000, Joakim Tjernlund wrote:
> > > 
> > > On Wed, 2016-09-14 at 16:35 +0200, greg@kroah.com wrote:
> > > > 
> > > > On Wed, Sep 14, 2016 at 12:00:04PM +0000, Joakim Tjernlund wrote:
> > > > > 
> > > > > 
> > > > > On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> > > > > > 
> > > > > > 
> > > > > > On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > These patches are picked from Linux upstream repo and applies directly on 4.4.x
> > > > > > > Please excuse the attachments but git send email does not work for us ATM.
> > > > > > 
> > > > > > What is the git commit ids of these patches in Linus's tree?
> > > > > 0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch: 6cf4a2c575b4797b967a575b6274e0e40c5f88f1
> > > > 
> > > > I do not see that git commit id in Linus's tree, do you?
> > > 
> > > ehh, no. I used my 4.4 branch instead of linux master, sorry
> > > 
> > > > 
> > > > 
> > > > > 
> > > > > 
> > > > > 0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch:
> > > > > 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a
> > > > 
> > > > Nor this one.��I stopped here, assuming that your other ids aren't
> > > > correct either :(
> > > > 
> > > > > 
> > > > > 
> > > > > 0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch:
> > > > > dcf95a1961f9614eee09066f8148813772ad4268
> > > > > 0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-
> > > > > res.patch:1c6c99c6767035761d17aeecaf0224934ccd00fb
> > > > > 0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch: 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > And what happened to the other patches in this series?
> > > > > > �
> > > > > The first one was inappropriate, that is why 0001 is missing.
> > > > 
> > > > That's pretty strange of you to force us to guess what is going on here,
> > > > would you like to get a series like this and wonder why something
> > > > obvious like this is gone?
> > > 
> > > Yes, it was inconsiderate of me, sorry.
> > > 
> > > Trying to do better I figured I should generate a new series from Linus tree but
> > > I cannot figure out how generate a series from commits that are non sequential in Linux tree.
> > > git format path does not have a syntax for that from what I can tell, any ideas?
> > 
> > Why not just send us the git commit ids that you want applied?��That's
> > all we need.
> >�
> Oh, didn't occur to me. Here we go(ltes se fi I got it right this time :)
> 
> bb28f3d51ff5e1be541d057708011cc1efe6fae9 -�thinkpad_acpi: Add support for keyboard backlight

How does this commit meet the Documentation/stable_kernel_rules.txt
requirements?  It's a new feature, and too big, why would we add it to
an old kernel like this one?  What's wrong with just using a newer
kernel for a feature like this?

> 15c75626f0999cce8357c8bf8578247134032acb -�thinkpad_acpi: Remove ambiguous logging for "Unsupported brightness interface"
> a7718360d91eedbedd58978ec8fff4a67a866f86 - thinkpad_acpi: Silence an uninitialized variable warning
> afcedebc6a094224973534f43b396bbbf33fe44e - thinkpad_acpi: save kbdlight state on suspend and restore it on resume

Are these 3 fixes for the first one?

> 0118c2d3eac0545d4095877e5a015b5dc763b3c2 - thinkpad_acpi: Add support for HKEY version 0x200

Again, another feature :(

And why aren't we cc:ing the maintainers of this subsystem?

thanks,

greg k-h

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[Joakim Tjernlund]

On Wed, 2016-09-14 at 20:10 +0200, greg@kroah.com wrote:
> On Wed, Sep 14, 2016 at 05:57:30PM +0000, Joakim Tjernlund wrote:
> > 
> > On Wed, 2016-09-14 at 19:08 +0200, greg@kroah.com wrote:
> > > 
> > > On Wed, Sep 14, 2016 at 04:13:52PM +0000, Joakim Tjernlund wrote:
> > > > 
> > > > 
> > > > On Wed, 2016-09-14 at 16:35 +0200, greg@kroah.com wrote:
> > > > > 
> > > > > 
> > > > > On Wed, Sep 14, 2016 at 12:00:04PM +0000, Joakim Tjernlund wrote:
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > These patches are picked from Linux upstream repo and applies directly on 4.4.x
> > > > > > > > Please excuse the attachments but git send email does not work for us ATM.
> > > > > > > 
> > > > > > > What is the git commit ids of these patches in Linus's tree?
> > > > > > 0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch:
> > > > > > 6cf4a2c575b4797b967a575b6274e0e40c5f88f1
> > > > > 
> > > > > I do not see that git commit id in Linus's tree, do you?
> > > > 
> > > > ehh, no. I used my 4.4 branch instead of linux master, sorry
> > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch:
> > > > > > 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a
> > > > > 
> > > > > Nor this one.  I stopped here, assuming that your other ids aren't
> > > > > correct either :(
> > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch:
> > > > > > dcf95a1961f9614eee09066f8148813772ad4268
> > > > > > 0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-
> > > > > > res.patch:1c6c99c6767035761d17aeecaf0224934ccd00fb
> > > > > > 0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch:
> > > > > > 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > And what happened to the other patches in this series?
> > > > > > >  
> > > > > > The first one was inappropriate, that is why 0001 is missing.
> > > > > 
> > > > > That's pretty strange of you to force us to guess what is going on here,
> > > > > would you like to get a series like this and wonder why something
> > > > > obvious like this is gone?
> > > > 
> > > > Yes, it was inconsiderate of me, sorry.
> > > > 
> > > > Trying to do better I figured I should generate a new series from Linus tree but
> > > > I cannot figure out how generate a series from commits that are non sequential in Linux tree.
> > > > git format path does not have a syntax for that from what I can tell, any ideas?
> > > 
> > > Why not just send us the git commit ids that you want applied?  That's
> > > all we need.
> > >  
> > Oh, didn't occur to me. Here we go(ltes se fi I got it right this time :)
> > 
> > bb28f3d51ff5e1be541d057708011cc1efe6fae9 - thinkpad_acpi: Add support for keyboard backlight
> 
> How does this commit meet the Documentation/stable_kernel_rules.txt
> requirements?  It's a new feature, and too big, why would we add it to
> an old kernel like this one?  What's wrong with just using a newer
> kernel for a feature like this?
> 
> > 
> > 15c75626f0999cce8357c8bf8578247134032acb - thinkpad_acpi: Remove ambiguous logging for "Unsupported
> > brightness interface"
> > a7718360d91eedbedd58978ec8fff4a67a866f86 - thinkpad_acpi: Silence an uninitialized variable warning
> > afcedebc6a094224973534f43b396bbbf33fe44e - thinkpad_acpi: save kbdlight state on suspend and restore it on
> > resume
> 
> Are these 3 fixes for the first one?
> 
> > 
> > 0118c2d3eac0545d4095877e5a015b5dc763b3c2 - thinkpad_acpi: Add support for HKEY version 0x200
> 
> Again, another feature :(

hmm, this was the one I really wanted as then wifi/video switch buttons work on our Lenovo laptops we
recently bought to replace old HPs. I did not think this was to regard as a new feature, just a fix to
make the same buttons work as on other models, sorry.

The other patches were just there to make sure I didn't run inte conflicts I didn't want to resolve.
They all made sense except for maybe the one adding keyboard backlight. 

> 
> And why aren't we cc:ing the maintainers of this subsystem?

Right, they are now. If you and/or maintainers do feel this is inappropriate for stable I will just
carry them my self until the next major stable kernel is released.

 Thanks
          Jocke 

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[greg]

On Wed, Sep 14, 2016 at 07:07:36PM +0000, Joakim Tjernlund wrote:
> On Wed, 2016-09-14 at 20:10 +0200, greg@kroah.com wrote:
> > On Wed, Sep 14, 2016 at 05:57:30PM +0000, Joakim Tjernlund wrote:
> > > 
> > > On Wed, 2016-09-14 at 19:08 +0200, greg@kroah.com wrote:
> > > > 
> > > > On Wed, Sep 14, 2016 at 04:13:52PM +0000, Joakim Tjernlund wrote:
> > > > > 
> > > > > 
> > > > > On Wed, 2016-09-14 at 16:35 +0200, greg@kroah.com wrote:
> > > > > > 
> > > > > > 
> > > > > > On Wed, Sep 14, 2016 at 12:00:04PM +0000, Joakim Tjernlund wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > These patches are picked from Linux upstream repo and applies directly on 4.4.x
> > > > > > > > > Please excuse the attachments but git send email does not work for us ATM.
> > > > > > > > 
> > > > > > > > What is the git commit ids of these patches in Linus's tree?
> > > > > > > 0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch:
> > > > > > > 6cf4a2c575b4797b967a575b6274e0e40c5f88f1
> > > > > > 
> > > > > > I do not see that git commit id in Linus's tree, do you?
> > > > > 
> > > > > ehh, no. I used my 4.4 branch instead of linux master, sorry
> > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > 0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch:
> > > > > > > 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a
> > > > > > 
> > > > > > Nor this one.  I stopped here, assuming that your other ids aren't
> > > > > > correct either :(
> > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > 0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch:
> > > > > > > dcf95a1961f9614eee09066f8148813772ad4268
> > > > > > > 0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-
> > > > > > > res.patch:1c6c99c6767035761d17aeecaf0224934ccd00fb
> > > > > > > 0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch:
> > > > > > > 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > And what happened to the other patches in this series?
> > > > > > > >  
> > > > > > > The first one was inappropriate, that is why 0001 is missing.
> > > > > > 
> > > > > > That's pretty strange of you to force us to guess what is going on here,
> > > > > > would you like to get a series like this and wonder why something
> > > > > > obvious like this is gone?
> > > > > 
> > > > > Yes, it was inconsiderate of me, sorry.
> > > > > 
> > > > > Trying to do better I figured I should generate a new series from Linus tree but
> > > > > I cannot figure out how generate a series from commits that are non sequential in Linux tree.
> > > > > git format path does not have a syntax for that from what I can tell, any ideas?
> > > > 
> > > > Why not just send us the git commit ids that you want applied?  That's
> > > > all we need.
> > > >  
> > > Oh, didn't occur to me. Here we go(ltes se fi I got it right this time :)
> > > 
> > > bb28f3d51ff5e1be541d057708011cc1efe6fae9 - thinkpad_acpi: Add support for keyboard backlight
> > 
> > How does this commit meet the Documentation/stable_kernel_rules.txt
> > requirements?  It's a new feature, and too big, why would we add it to
> > an old kernel like this one?  What's wrong with just using a newer
> > kernel for a feature like this?
> > 
> > > 
> > > 15c75626f0999cce8357c8bf8578247134032acb - thinkpad_acpi: Remove ambiguous logging for "Unsupported
> > > brightness interface"
> > > a7718360d91eedbedd58978ec8fff4a67a866f86 - thinkpad_acpi: Silence an uninitialized variable warning
> > > afcedebc6a094224973534f43b396bbbf33fe44e - thinkpad_acpi: save kbdlight state on suspend and restore it on
> > > resume
> > 
> > Are these 3 fixes for the first one?
> > 
> > > 
> > > 0118c2d3eac0545d4095877e5a015b5dc763b3c2 - thinkpad_acpi: Add support for HKEY version 0x200
> > 
> > Again, another feature :(
> 
> hmm, this was the one I really wanted as then wifi/video switch
> buttons work on our Lenovo laptops we recently bought to replace old
> HPs. I did not think this was to regard as a new feature, just a fix
> to make the same buttons work as on other models, sorry.

It's a new feature for that model of laptop, otherwise we would be
backporting everything all the time :(

> The other patches were just there to make sure I didn't run inte
> conflicts I didn't want to resolve.  They all made sense except for
> maybe the one adding keyboard backlight. 
> 
> > And why aren't we cc:ing the maintainers of this subsystem?
> 
> Right, they are now. If you and/or maintainers do feel this is
> inappropriate for stable I will just carry them my self until the next
> major stable kernel is released.

What is wrong with 4.7-stable kernels?  Why are you "stuck" at 4.4?

thanks,

greg k-h

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[greg]

On Wed, Sep 14, 2016 at 07:07:36PM +0000, Joakim Tjernlund wrote:
> On Wed, 2016-09-14 at 20:10 +0200, greg@kroah.com wrote:
> > On Wed, Sep 14, 2016 at 05:57:30PM +0000, Joakim Tjernlund wrote:
> > > 
> > > On Wed, 2016-09-14 at 19:08 +0200, greg@kroah.com wrote:
> > > > 
> > > > On Wed, Sep 14, 2016 at 04:13:52PM +0000, Joakim Tjernlund wrote:
> > > > > 
> > > > > 
> > > > > On Wed, 2016-09-14 at 16:35 +0200, greg@kroah.com wrote:
> > > > > > 
> > > > > > 
> > > > > > On Wed, Sep 14, 2016 at 12:00:04PM +0000, Joakim Tjernlund wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > These patches are picked from Linux upstream repo and applies directly on 4.4.x
> > > > > > > > > Please excuse the attachments but git send email does not work for us ATM.
> > > > > > > > 
> > > > > > > > What is the git commit ids of these patches in Linus's tree?
> > > > > > > 0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch:
> > > > > > > 6cf4a2c575b4797b967a575b6274e0e40c5f88f1
> > > > > > 
> > > > > > I do not see that git commit id in Linus's tree, do you?
> > > > > 
> > > > > ehh, no. I used my 4.4 branch instead of linux master, sorry
> > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > 0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch:
> > > > > > > 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a
> > > > > > 
> > > > > > Nor this one.��I stopped here, assuming that your other ids aren't
> > > > > > correct either :(
> > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > 0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch:
> > > > > > > dcf95a1961f9614eee09066f8148813772ad4268
> > > > > > > 0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-
> > > > > > > res.patch:1c6c99c6767035761d17aeecaf0224934ccd00fb
> > > > > > > 0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch:
> > > > > > > 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > And what happened to the other patches in this series?
> > > > > > > > �
> > > > > > > The first one was inappropriate, that is why 0001 is missing.
> > > > > > 
> > > > > > That's pretty strange of you to force us to guess what is going on here,
> > > > > > would you like to get a series like this and wonder why something
> > > > > > obvious like this is gone?
> > > > > 
> > > > > Yes, it was inconsiderate of me, sorry.
> > > > > 
> > > > > Trying to do better I figured I should generate a new series from Linus tree but
> > > > > I cannot figure out how generate a series from commits that are non sequential in Linux tree.
> > > > > git format path does not have a syntax for that from what I can tell, any ideas?
> > > > 
> > > > Why not just send us the git commit ids that you want applied?��That's
> > > > all we need.
> > > > �
> > > Oh, didn't occur to me. Here we go(ltes se fi I got it right this time :)
> > > 
> > > bb28f3d51ff5e1be541d057708011cc1efe6fae9 -�thinkpad_acpi: Add support for keyboard backlight
> > 
> > How does this commit meet the Documentation/stable_kernel_rules.txt
> > requirements?��It's a new feature, and too big, why would we add it to
> > an old kernel like this one?��What's wrong with just using a newer
> > kernel for a feature like this?
> > 
> > > 
> > > 15c75626f0999cce8357c8bf8578247134032acb -�thinkpad_acpi: Remove ambiguous logging for "Unsupported
> > > brightness interface"
> > > a7718360d91eedbedd58978ec8fff4a67a866f86 - thinkpad_acpi: Silence an uninitialized variable warning
> > > afcedebc6a094224973534f43b396bbbf33fe44e - thinkpad_acpi: save kbdlight state on suspend and restore it on
> > > resume
> > 
> > Are these 3 fixes for the first one?
> > 
> > > 
> > > 0118c2d3eac0545d4095877e5a015b5dc763b3c2 - thinkpad_acpi: Add support for HKEY version 0x200
> > 
> > Again, another feature :(
> 
> hmm, this was the one I really wanted as then wifi/video switch
> buttons work on our Lenovo laptops we recently bought to replace old
> HPs. I did not think this was to regard as a new feature, just a fix
> to make the same buttons work as on other models, sorry.

It's a new feature for that model of laptop, otherwise we would be
backporting everything all the time :(

> The other patches were just there to make sure I didn't run inte
> conflicts I didn't want to resolve.  They all made sense except for
> maybe the one adding keyboard backlight.�
> 
> > And why aren't we cc:ing the maintainers of this subsystem?
> 
> Right, they are now. If you and/or maintainers do feel this is
> inappropriate for stable I will just carry them my self until the next
> major stable kernel is released.

What is wrong with 4.7-stable kernels?  Why are you "stuck" at 4.4?

thanks,

greg k-h

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[Joakim Tjernlund]

On Thu, 2016-09-15 at 07:59 +0200, greg@kroah.com wrote:
> On Wed, Sep 14, 2016 at 07:07:36PM +0000, Joakim Tjernlund wrote:
> > 
> > On Wed, 2016-09-14 at 20:10 +0200, greg@kroah.com wrote:
> > > 
> > > On Wed, Sep 14, 2016 at 05:57:30PM +0000, Joakim Tjernlund wrote:
> > > > 
> > > > 
> > > > On Wed, 2016-09-14 at 19:08 +0200, greg@kroah.com wrote:
> > > > > 
> > > > > 
> > > > > On Wed, Sep 14, 2016 at 04:13:52PM +0000, Joakim Tjernlund wrote:
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > On Wed, 2016-09-14 at 16:35 +0200, greg@kroah.com wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > On Wed, Sep 14, 2016 at 12:00:04PM +0000, Joakim Tjernlund wrote:
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > These patches are picked from Linux upstream repo and applies directly on 4.4.x
> > > > > > > > > > Please excuse the attachments but git send email does not work for us ATM.
> > > > > > > > > 
> > > > > > > > > What is the git commit ids of these patches in Linus's tree?
> > > > > > > > 0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch:
> > > > > > > > 6cf4a2c575b4797b967a575b6274e0e40c5f88f1
> > > > > > > 
> > > > > > > I do not see that git commit id in Linus's tree, do you?
> > > > > > 
> > > > > > ehh, no. I used my 4.4 branch instead of linux master, sorry
> > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch:
> > > > > > > > 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a
> > > > > > > 
> > > > > > > Nor this one.  I stopped here, assuming that your other ids aren't
> > > > > > > correct either :(
> > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch:
> > > > > > > > dcf95a1961f9614eee09066f8148813772ad4268
> > > > > > > > 0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-
> > > > > > > > res.patch:1c6c99c6767035761d17aeecaf0224934ccd00fb
> > > > > > > > 0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch:
> > > > > > > > 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > And what happened to the other patches in this series?
> > > > > > > > >  
> > > > > > > > The first one was inappropriate, that is why 0001 is missing.
> > > > > > > 
> > > > > > > That's pretty strange of you to force us to guess what is going on here,
> > > > > > > would you like to get a series like this and wonder why something
> > > > > > > obvious like this is gone?
> > > > > > 
> > > > > > Yes, it was inconsiderate of me, sorry.
> > > > > > 
> > > > > > Trying to do better I figured I should generate a new series from Linus tree but
> > > > > > I cannot figure out how generate a series from commits that are non sequential in Linux tree.
> > > > > > git format path does not have a syntax for that from what I can tell, any ideas?
> > > > > 
> > > > > Why not just send us the git commit ids that you want applied?  That's
> > > > > all we need.
> > > > >  
> > > > Oh, didn't occur to me. Here we go(ltes se fi I got it right this time :)
> > > > 
> > > > bb28f3d51ff5e1be541d057708011cc1efe6fae9 - thinkpad_acpi: Add support for keyboard backlight
> > > 
> > > How does this commit meet the Documentation/stable_kernel_rules.txt
> > > requirements?  It's a new feature, and too big, why would we add it to
> > > an old kernel like this one?  What's wrong with just using a newer
> > > kernel for a feature like this?
> > > 
> > > > 
> > > > 
> > > > 15c75626f0999cce8357c8bf8578247134032acb - thinkpad_acpi: Remove ambiguous logging for "Unsupported
> > > > brightness interface"
> > > > a7718360d91eedbedd58978ec8fff4a67a866f86 - thinkpad_acpi: Silence an uninitialized variable warning
> > > > afcedebc6a094224973534f43b396bbbf33fe44e - thinkpad_acpi: save kbdlight state on suspend and restore
> > > > it on
> > > > resume
> > > 
> > > Are these 3 fixes for the first one?
> > > 
> > > > 
> > > > 
> > > > 0118c2d3eac0545d4095877e5a015b5dc763b3c2 - thinkpad_acpi: Add support for HKEY version 0x200
> > > 
> > > Again, another feature :(
> > 
> > hmm, this was the one I really wanted as then wifi/video switch
> > buttons work on our Lenovo laptops we recently bought to replace old
> > HPs. I did not think this was to regard as a new feature, just a fix
> > to make the same buttons work as on other models, sorry.
> 
> It's a new feature for that model of laptop, otherwise we would be
> backporting everything all the time :(

Yes, but allowing new HW to work properly in older kernels was an exception or at least so I thought.
If here is a new minor version of the e1000 ethernet device which needs a few tweaks to
function on older kernels, do you not accept patches for that?

> 
> > 
> > The other patches were just there to make sure I didn't run inte
> > conflicts I didn't want to resolve.  They all made sense except for
> > maybe the one adding keyboard backlight. 
> > 
> > > 
> > > And why aren't we cc:ing the maintainers of this subsystem?
> > 
> > Right, they are now. If you and/or maintainers do feel this is
> > inappropriate for stable I will just carry them my self until the next
> > major stable kernel is released.
> 
> What is wrong with 4.7-stable kernels?  Why are you "stuck" at 4.4?
> 

Non LTS kernels are fairly short lived. First you have wait for a few patch levels(say >=5) before
one can consider the kernel fairly stable. After that there isn't that many release before it retired
and you have to look for the next stable kernel. 

Each time you migrate your kernel config between major releases there is a risk something is
mis migrated so one has to spend some time to review/test the kernel.
So I stay on LTS were I can and only systems really needing something newer gets a non LTS kernel.

Note that this our company kernel, used on > 100 boxes and it is not uncommon that something
breaks somewhere after a major kernel upgrade, usually because I missed some kernel config.

  Jocke

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[greg]

On Thu, Sep 15, 2016 at 08:51:34AM +0000, Joakim Tjernlund wrote:
> On Thu, 2016-09-15 at 07:59 +0200, greg@kroah.com wrote:
> > On Wed, Sep 14, 2016 at 07:07:36PM +0000, Joakim Tjernlund wrote:
> > > 
> > > On Wed, 2016-09-14 at 20:10 +0200, greg@kroah.com wrote:
> > > > 
> > > > On Wed, Sep 14, 2016 at 05:57:30PM +0000, Joakim Tjernlund wrote:
> > > > > 
> > > > > 
> > > > > On Wed, 2016-09-14 at 19:08 +0200, greg@kroah.com wrote:
> > > > > > 
> > > > > > 
> > > > > > On Wed, Sep 14, 2016 at 04:13:52PM +0000, Joakim Tjernlund wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > On Wed, 2016-09-14 at 16:35 +0200, greg@kroah.com wrote:
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > On Wed, Sep 14, 2016 at 12:00:04PM +0000, Joakim Tjernlund wrote:
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > These patches are picked from Linux upstream repo and applies directly on 4.4.x
> > > > > > > > > > > Please excuse the attachments but git send email does not work for us ATM.
> > > > > > > > > > 
> > > > > > > > > > What is the git commit ids of these patches in Linus's tree?
> > > > > > > > > 0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch:
> > > > > > > > > 6cf4a2c575b4797b967a575b6274e0e40c5f88f1
> > > > > > > > 
> > > > > > > > I do not see that git commit id in Linus's tree, do you?
> > > > > > > 
> > > > > > > ehh, no. I used my 4.4 branch instead of linux master, sorry
> > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch:
> > > > > > > > > 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a
> > > > > > > > 
> > > > > > > > Nor this one.  I stopped here, assuming that your other ids aren't
> > > > > > > > correct either :(
> > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch:
> > > > > > > > > dcf95a1961f9614eee09066f8148813772ad4268
> > > > > > > > > 0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-
> > > > > > > > > res.patch:1c6c99c6767035761d17aeecaf0224934ccd00fb
> > > > > > > > > 0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch:
> > > > > > > > > 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > And what happened to the other patches in this series?
> > > > > > > > > >  
> > > > > > > > > The first one was inappropriate, that is why 0001 is missing.
> > > > > > > > 
> > > > > > > > That's pretty strange of you to force us to guess what is going on here,
> > > > > > > > would you like to get a series like this and wonder why something
> > > > > > > > obvious like this is gone?
> > > > > > > 
> > > > > > > Yes, it was inconsiderate of me, sorry.
> > > > > > > 
> > > > > > > Trying to do better I figured I should generate a new series from Linus tree but
> > > > > > > I cannot figure out how generate a series from commits that are non sequential in Linux tree.
> > > > > > > git format path does not have a syntax for that from what I can tell, any ideas?
> > > > > > 
> > > > > > Why not just send us the git commit ids that you want applied?  That's
> > > > > > all we need.
> > > > > >  
> > > > > Oh, didn't occur to me. Here we go(ltes se fi I got it right this time :)
> > > > > 
> > > > > bb28f3d51ff5e1be541d057708011cc1efe6fae9 - thinkpad_acpi: Add support for keyboard backlight
> > > > 
> > > > How does this commit meet the Documentation/stable_kernel_rules.txt
> > > > requirements?  It's a new feature, and too big, why would we add it to
> > > > an old kernel like this one?  What's wrong with just using a newer
> > > > kernel for a feature like this?
> > > > 
> > > > > 
> > > > > 
> > > > > 15c75626f0999cce8357c8bf8578247134032acb - thinkpad_acpi: Remove ambiguous logging for "Unsupported
> > > > > brightness interface"
> > > > > a7718360d91eedbedd58978ec8fff4a67a866f86 - thinkpad_acpi: Silence an uninitialized variable warning
> > > > > afcedebc6a094224973534f43b396bbbf33fe44e - thinkpad_acpi: save kbdlight state on suspend and restore
> > > > > it on
> > > > > resume
> > > > 
> > > > Are these 3 fixes for the first one?
> > > > 
> > > > > 
> > > > > 
> > > > > 0118c2d3eac0545d4095877e5a015b5dc763b3c2 - thinkpad_acpi: Add support for HKEY version 0x200
> > > > 
> > > > Again, another feature :(
> > > 
> > > hmm, this was the one I really wanted as then wifi/video switch
> > > buttons work on our Lenovo laptops we recently bought to replace old
> > > HPs. I did not think this was to regard as a new feature, just a fix
> > > to make the same buttons work as on other models, sorry.
> > 
> > It's a new feature for that model of laptop, otherwise we would be
> > backporting everything all the time :(
> 
> Yes, but allowing new HW to work properly in older kernels was an exception or at least so I thought.
> If here is a new minor version of the e1000 ethernet device which needs a few tweaks to
> function on older kernels, do you not accept patches for that?

As the stable_kernel_rules.txt file says, yes, for simple quirk table
and device id additions, yes we do.  But this involves new code and
functions and really, a new feature implemented for that hardware.

> > > The other patches were just there to make sure I didn't run inte
> > > conflicts I didn't want to resolve.  They all made sense except for
> > > maybe the one adding keyboard backlight. 
> > > 
> > > > 
> > > > And why aren't we cc:ing the maintainers of this subsystem?
> > > 
> > > Right, they are now. If you and/or maintainers do feel this is
> > > inappropriate for stable I will just carry them my self until the next
> > > major stable kernel is released.
> > 
> > What is wrong with 4.7-stable kernels?  Why are you "stuck" at 4.4?
> > 
> 
> Non LTS kernels are fairly short lived. First you have wait for a few
> patch levels(say >=5) before one can consider the kernel fairly
> stable.

Why do you say that?  How do you judge stability?  You are getting
bugfixes that are in Linus's tree, not that were specifically for that
stable kernel release alone.

> After that there isn't that many release before it retired and you
> have to look for the next stable kernel. 

Yes, it's a never ending treadmill, welcome to the real world :)

> Each time you migrate your kernel config between major releases there
> is a risk something is mis migrated so one has to spend some time to
> review/test the kernel.

How much time does this take you?  How do you do this review?  What does
it entail?

> So I stay on LTS were I can and only systems really needing something
> newer gets a non LTS kernel.
> 
> Note that this our company kernel, used on > 100 boxes and it is not
> uncommon that something breaks somewhere after a major kernel upgrade,
> usually because I missed some kernel config.

Are you testing the -rc kernels all along?  That's the best way to do
this incrementally such that you don't miss something, and to let the
developers know that there is something wrong.

I've been running every -rc on my personal machines for years without
problems, people shouldn't be afraid of this.

By waiting a full year, your "jump" is much larger and harder,
especially for any new hardware, as you are finding out.  We can't go
back in time and add support for hardware that wasn't around when that
kernel release was being developed, so I recommend using the latest
releases, or use a distro that does this work for you (Fedora,
Tumbleweed, Arch, Debian unstable, etc.)

good luck!

greg k-h

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[greg]

On Thu, Sep 15, 2016 at 08:51:34AM +0000, Joakim Tjernlund wrote:
> On Thu, 2016-09-15 at 07:59 +0200, greg@kroah.com wrote:
> > On Wed, Sep 14, 2016 at 07:07:36PM +0000, Joakim Tjernlund wrote:
> > > 
> > > On Wed, 2016-09-14 at 20:10 +0200, greg@kroah.com wrote:
> > > > 
> > > > On Wed, Sep 14, 2016 at 05:57:30PM +0000, Joakim Tjernlund wrote:
> > > > > 
> > > > > 
> > > > > On Wed, 2016-09-14 at 19:08 +0200, greg@kroah.com wrote:
> > > > > > 
> > > > > > 
> > > > > > On Wed, Sep 14, 2016 at 04:13:52PM +0000, Joakim Tjernlund wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > On Wed, 2016-09-14 at 16:35 +0200, greg@kroah.com wrote:
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > On Wed, Sep 14, 2016 at 12:00:04PM +0000, Joakim Tjernlund wrote:
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > These patches are picked from Linux upstream repo and applies directly on 4.4.x
> > > > > > > > > > > Please excuse the attachments but git send email does not work for us ATM.
> > > > > > > > > > 
> > > > > > > > > > What is the git commit ids of these patches in Linus's tree?
> > > > > > > > > 0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch:
> > > > > > > > > 6cf4a2c575b4797b967a575b6274e0e40c5f88f1
> > > > > > > > 
> > > > > > > > I do not see that git commit id in Linus's tree, do you?
> > > > > > > 
> > > > > > > ehh, no. I used my 4.4 branch instead of linux master, sorry
> > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch:
> > > > > > > > > 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a
> > > > > > > > 
> > > > > > > > Nor this one.��I stopped here, assuming that your other ids aren't
> > > > > > > > correct either :(
> > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch:
> > > > > > > > > dcf95a1961f9614eee09066f8148813772ad4268
> > > > > > > > > 0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-
> > > > > > > > > res.patch:1c6c99c6767035761d17aeecaf0224934ccd00fb
> > > > > > > > > 0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch:
> > > > > > > > > 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > And what happened to the other patches in this series?
> > > > > > > > > > �
> > > > > > > > > The first one was inappropriate, that is why 0001 is missing.
> > > > > > > > 
> > > > > > > > That's pretty strange of you to force us to guess what is going on here,
> > > > > > > > would you like to get a series like this and wonder why something
> > > > > > > > obvious like this is gone?
> > > > > > > 
> > > > > > > Yes, it was inconsiderate of me, sorry.
> > > > > > > 
> > > > > > > Trying to do better I figured I should generate a new series from Linus tree but
> > > > > > > I cannot figure out how generate a series from commits that are non sequential in Linux tree.
> > > > > > > git format path does not have a syntax for that from what I can tell, any ideas?
> > > > > > 
> > > > > > Why not just send us the git commit ids that you want applied?��That's
> > > > > > all we need.
> > > > > > �
> > > > > Oh, didn't occur to me. Here we go(ltes se fi I got it right this time :)
> > > > > 
> > > > > bb28f3d51ff5e1be541d057708011cc1efe6fae9 -�thinkpad_acpi: Add support for keyboard backlight
> > > > 
> > > > How does this commit meet the Documentation/stable_kernel_rules.txt
> > > > requirements?��It's a new feature, and too big, why would we add it to
> > > > an old kernel like this one?��What's wrong with just using a newer
> > > > kernel for a feature like this?
> > > > 
> > > > > 
> > > > > 
> > > > > 15c75626f0999cce8357c8bf8578247134032acb -�thinkpad_acpi: Remove ambiguous logging for "Unsupported
> > > > > brightness interface"
> > > > > a7718360d91eedbedd58978ec8fff4a67a866f86 - thinkpad_acpi: Silence an uninitialized variable warning
> > > > > afcedebc6a094224973534f43b396bbbf33fe44e - thinkpad_acpi: save kbdlight state on suspend and restore
> > > > > it on
> > > > > resume
> > > > 
> > > > Are these 3 fixes for the first one?
> > > > 
> > > > > 
> > > > > 
> > > > > 0118c2d3eac0545d4095877e5a015b5dc763b3c2 - thinkpad_acpi: Add support for HKEY version 0x200
> > > > 
> > > > Again, another feature :(
> > > 
> > > hmm, this was the one I really wanted as then wifi/video switch
> > > buttons work on our Lenovo laptops we recently bought to replace old
> > > HPs. I did not think this was to regard as a new feature, just a fix
> > > to make the same buttons work as on other models, sorry.
> > 
> > It's a new feature for that model of laptop, otherwise we would be
> > backporting everything all the time :(
> 
> Yes, but allowing new HW to work properly in older kernels was an exception or at least so I thought.
> If here is a new minor version of the e1000 ethernet device which needs a few tweaks to
> function on older kernels, do you not accept patches for that?

As the stable_kernel_rules.txt file says, yes, for simple quirk table
and device id additions, yes we do.  But this involves new code and
functions and really, a new feature implemented for that hardware.

> > > The other patches were just there to make sure I didn't run inte
> > > conflicts I didn't want to resolve.��They all made sense except for
> > > maybe the one adding keyboard backlight.�
> > > 
> > > > 
> > > > And why aren't we cc:ing the maintainers of this subsystem?
> > > 
> > > Right, they are now. If you and/or maintainers do feel this is
> > > inappropriate for stable I will just carry them my self until the next
> > > major stable kernel is released.
> > 
> > What is wrong with 4.7-stable kernels?��Why are you "stuck" at 4.4?
> >�
> 
> Non LTS kernels are fairly short lived. First you have wait for a few
> patch levels(say >=5) before one can consider the kernel fairly
> stable.

Why do you say that?  How do you judge stability?  You are getting
bugfixes that are in Linus's tree, not that were specifically for that
stable kernel release alone.

> After that there isn't that many release before it retired and you
> have to look for the next stable kernel.�

Yes, it's a never ending treadmill, welcome to the real world :)

> Each time you migrate your kernel config between major releases there
> is a risk something is mis migrated so one has to spend some time to
> review/test the kernel.

How much time does this take you?  How do you do this review?  What does
it entail?

> So I stay on LTS were I can and only systems really needing something
> newer gets a non LTS kernel.
> 
> Note that this our company kernel, used on > 100 boxes and it is not
> uncommon that something breaks somewhere after a major kernel upgrade,
> usually because I missed some kernel config.

Are you testing the -rc kernels all along?  That's the best way to do
this incrementally such that you don't miss something, and to let the
developers know that there is something wrong.

I've been running every -rc on my personal machines for years without
problems, people shouldn't be afraid of this.

By waiting a full year, your "jump" is much larger and harder,
especially for any new hardware, as you are finding out.  We can't go
back in time and add support for hardware that wasn't around when that
kernel release was being developed, so I recommend using the latest
releases, or use a distro that does this work for you (Fedora,
Tumbleweed, Arch, Debian unstable, etc.)

good luck!

greg k-h

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[Vasiliy Tolstov]

[-- Attachment #1.1: Type: text/plain, Size: 7623 bytes --]

15 Сен 2016 г. 11:52 пользователь "Joakim Tjernlund" <
Joakim.Tjernlund-27rvihrghlNWk0Htik3J/w@public.gmane.org> написал:
>
> On Thu, 2016-09-15 at 07:59 +0200, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org wrote:
> > On Wed, Sep 14, 2016 at 07:07:36PM +0000, Joakim Tjernlund wrote:
> > >
> > > On Wed, 2016-09-14 at 20:10 +0200, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org wrote:
> > > >
> > > > On Wed, Sep 14, 2016 at 05:57:30PM +0000, Joakim Tjernlund wrote:
> > > > >
> > > > >
> > > > > On Wed, 2016-09-14 at 19:08 +0200, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org wrote:
> > > > > >
> > > > > >
> > > > > > On Wed, Sep 14, 2016 at 04:13:52PM +0000, Joakim Tjernlund
wrote:
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Wed, 2016-09-14 at 16:35 +0200, greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org wrote:
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > On Wed, Sep 14, 2016 at 12:00:04PM +0000, Joakim Tjernlund
wrote:
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim
Tjernlund wrote:
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > These patches are picked from Linux upstream repo and
applies directly on 4.4.x
> > > > > > > > > > > Please excuse the attachments but git send email does
not work for us ATM.
> > > > > > > > > >
> > > > > > > > > > What is the git commit ids of these patches in Linus's
tree?
> > > > > > > > >
0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch:
> > > > > > > > > 6cf4a2c575b4797b967a575b6274e0e40c5f88f1
> > > > > > > >
> > > > > > > > I do not see that git commit id in Linus's tree, do you?
> > > > > > >
> > > > > > > ehh, no. I used my 4.4 branch instead of linux master, sorry
> > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch:
> > > > > > > > > 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a
> > > > > > > >
> > > > > > > > Nor this one.  I stopped here, assuming that your other ids
aren't
> > > > > > > > correct either :(
> > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch:
> > > > > > > > > dcf95a1961f9614eee09066f8148813772ad4268
> > > > > > > > > 0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-
> > > > > > > > > res.patch:1c6c99c6767035761d17aeecaf0224934ccd00fb
> > > > > > > > >
0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch:
> > > > > > > > > 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > And what happened to the other patches in this series?
> > > > > > > > > >
> > > > > > > > > The first one was inappropriate, that is why 0001 is
missing.
> > > > > > > >
> > > > > > > > That's pretty strange of you to force us to guess what is
going on here,
> > > > > > > > would you like to get a series like this and wonder why
something
> > > > > > > > obvious like this is gone?
> > > > > > >
> > > > > > > Yes, it was inconsiderate of me, sorry.
> > > > > > >
> > > > > > > Trying to do better I figured I should generate a new series
from Linus tree but
> > > > > > > I cannot figure out how generate a series from commits that
are non sequential in Linux tree.
> > > > > > > git format path does not have a syntax for that from what I
can tell, any ideas?
> > > > > >
> > > > > > Why not just send us the git commit ids that you want
applied?  That's
> > > > > > all we need.
> > > > > >
> > > > > Oh, didn't occur to me. Here we go(ltes se fi I got it right this
time :)
> > > > >
> > > > > bb28f3d51ff5e1be541d057708011cc1efe6fae9 - thinkpad_acpi: Add
support for keyboard backlight
> > > >
> > > > How does this commit meet the Documentation/stable_kernel_rules.txt
> > > > requirements?  It's a new feature, and too big, why would we add it
to
> > > > an old kernel like this one?  What's wrong with just using a newer
> > > > kernel for a feature like this?
> > > >
> > > > >
> > > > >
> > > > > 15c75626f0999cce8357c8bf8578247134032acb - thinkpad_acpi: Remove
ambiguous logging for "Unsupported
> > > > > brightness interface"
> > > > > a7718360d91eedbedd58978ec8fff4a67a866f86 - thinkpad_acpi: Silence
an uninitialized variable warning
> > > > > afcedebc6a094224973534f43b396bbbf33fe44e - thinkpad_acpi: save
kbdlight state on suspend and restore
> > > > > it on
> > > > > resume
> > > >
> > > > Are these 3 fixes for the first one?
> > > >
> > > > >
> > > > >
> > > > > 0118c2d3eac0545d4095877e5a015b5dc763b3c2 - thinkpad_acpi: Add
support for HKEY version 0x200
> > > >
> > > > Again, another feature :(
> > >
> > > hmm, this was the one I really wanted as then wifi/video switch
> > > buttons work on our Lenovo laptops we recently bought to replace old
> > > HPs. I did not think this was to regard as a new feature, just a fix
> > > to make the same buttons work as on other models, sorry.
> >
> > It's a new feature for that model of laptop, otherwise we would be
> > backporting everything all the time :(
>
> Yes, but allowing new HW to work properly in older kernels was an
exception or at least so I thought.
> If here is a new minor version of the e1000 ethernet device which needs a
few tweaks to
> function on older kernels, do you not accept patches for that?
>
> >

Why not add patches in you package and rebuild? I do this things often and
does not have any problems. You can use Fedora corp or opensuse build
service...

> > >
> > > The other patches were just there to make sure I didn't run inte
> > > conflicts I didn't want to resolve.  They all made sense except for
> > > maybe the one adding keyboard backlight.
> > >
> > > >
> > > > And why aren't we cc:ing the maintainers of this subsystem?
> > >
> > > Right, they are now. If you and/or maintainers do feel this is
> > > inappropriate for stable I will just carry them my self until the next
> > > major stable kernel is released.
> >
> > What is wrong with 4.7-stable kernels?  Why are you "stuck" at 4.4?
> >
>
> Non LTS kernels are fairly short lived. First you have wait for a few
patch levels(say >=5) before
> one can consider the kernel fairly stable. After that there isn't that
many release before it retired
> and you have to look for the next stable kernel.
>
> Each time you migrate your kernel config between major releases there is
a risk something is
> mis migrated so one has to spend some time to review/test the kernel.
> So I stay on LTS were I can and only systems really needing something
newer gets a non LTS kernel.
>
> Note that this our company kernel, used on > 100 boxes and it is not
uncommon that something
> breaks somewhere after a major kernel upgrade, usually because I missed
some kernel config.
>
>   Jocke--
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #1.2: Type: text/html, Size: 11702 bytes --]

[-- Attachment #2: Type: text/plain, Size: 203 bytes --]

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot

[-- Attachment #3: Type: text/plain, Size: 201 bytes --]

_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[Vasiliy Tolstov]

2016-09-15 11:51 GMT+03:00 Joakim Tjernlund <Joakim.Tjernlund@infinera.com>:
> Yes, but allowing new HW to work properly in older kernels was an exception or at least so I thought.
> If here is a new minor version of the e1000 ethernet device which needs a few tweaks to
> function on older kernels, do you not accept patches for that?


Why not add patches in you package and rebuild? I do this things often
and does not have any problems. You can use Fedora corp or opensuse
build service...

-- 
Vasiliy Tolstov,
e-mail: v.tolstov@selfip.ru

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[Joakim Tjernlund]

On Thu, 2016-09-15 at 12:07 +0200, greg@kroah.com wrote:
> On Thu, Sep 15, 2016 at 08:51:34AM +0000, Joakim Tjernlund wrote:
> > 
> > On Thu, 2016-09-15 at 07:59 +0200, greg@kroah.com wrote:
> > > 
> > > On Wed, Sep 14, 2016 at 07:07:36PM +0000, Joakim Tjernlund wrote:
> > > > 
> > > > 
> > > > On Wed, 2016-09-14 at 20:10 +0200, greg@kroah.com wrote:
> > > > > 
> > > > > 
> > > > > On Wed, Sep 14, 2016 at 05:57:30PM +0000, Joakim Tjernlund wrote:
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > On Wed, 2016-09-14 at 19:08 +0200, greg@kroah.com wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > On Wed, Sep 14, 2016 at 04:13:52PM +0000, Joakim Tjernlund wrote:
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > On Wed, 2016-09-14 at 16:35 +0200, greg@kroah.com wrote:
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > On Wed, Sep 14, 2016 at 12:00:04PM +0000, Joakim Tjernlund wrote:
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > On Wed, 2016-09-14 at 13:54 +0200, Greg KH wrote:
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > On Wed, Sep 14, 2016 at 06:44:50AM +0000, Joakim Tjernlund wrote:
> > > > > > > > > > > > 
> > > > > > > > > > > > 
> > > > > > > > > > > > 
> > > > > > > > > > > > 
> > > > > > > > > > > > 
> > > > > > > > > > > > 
> > > > > > > > > > > > These patches are picked from Linux upstream repo and applies directly on 4.4.x
> > > > > > > > > > > > Please excuse the attachments but git send email does not work for us ATM.
> > > > > > > > > > > 
> > > > > > > > > > > What is the git commit ids of these patches in Linus's tree?
> > > > > > > > > > 0002-thinkpad_acpi-Add-support-for-keyboard-backlight.patch:
> > > > > > > > > > 6cf4a2c575b4797b967a575b6274e0e40c5f88f1
> > > > > > > > > 
> > > > > > > > > I do not see that git commit id in Linus's tree, do you?
> > > > > > > > 
> > > > > > > > ehh, no. I used my 4.4 branch instead of linux master, sorry
> > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 0003-thinkpad_acpi-Remove-ambiguous-logging-for-Unsupport.patch:
> > > > > > > > > > 85342b97c2ee2a94a31ea5d59d58cdfd1f045e2a
> > > > > > > > > 
> > > > > > > > > Nor this one.  I stopped here, assuming that your other ids aren't
> > > > > > > > > correct either :(
> > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 0004-thinkpad_acpi-Silence-an-uninitialized-variable-warn.patch:
> > > > > > > > > > dcf95a1961f9614eee09066f8148813772ad4268
> > > > > > > > > > 0005-thinkpad_acpi-save-kbdlight-state-on-suspend-and-
> > > > > > > > > > res.patch:1c6c99c6767035761d17aeecaf0224934ccd00fb
> > > > > > > > > > 0006-thinkpad_acpi-Add-support-for-HKEY-version-0x200.patch:
> > > > > > > > > > 1bc0df534d11c8c9c97e1e8315b7d22bf034c8d2
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > And what happened to the other patches in this series?
> > > > > > > > > > >  
> > > > > > > > > > The first one was inappropriate, that is why 0001 is missing.
> > > > > > > > > 
> > > > > > > > > That's pretty strange of you to force us to guess what is going on here,
> > > > > > > > > would you like to get a series like this and wonder why something
> > > > > > > > > obvious like this is gone?
> > > > > > > > 
> > > > > > > > Yes, it was inconsiderate of me, sorry.
> > > > > > > > 
> > > > > > > > Trying to do better I figured I should generate a new series from Linus tree but
> > > > > > > > I cannot figure out how generate a series from commits that are non sequential in Linux tree.
> > > > > > > > git format path does not have a syntax for that from what I can tell, any ideas?
> > > > > > > 
> > > > > > > Why not just send us the git commit ids that you want applied?  That's
> > > > > > > all we need.
> > > > > > >  
> > > > > > Oh, didn't occur to me. Here we go(ltes se fi I got it right this time :)
> > > > > > 
> > > > > > bb28f3d51ff5e1be541d057708011cc1efe6fae9 - thinkpad_acpi: Add support for keyboard backlight
> > > > > 
> > > > > How does this commit meet the Documentation/stable_kernel_rules.txt
> > > > > requirements?  It's a new feature, and too big, why would we add it to
> > > > > an old kernel like this one?  What's wrong with just using a newer
> > > > > kernel for a feature like this?
> > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 15c75626f0999cce8357c8bf8578247134032acb - thinkpad_acpi: Remove ambiguous logging for
> > > > > > "Unsupported
> > > > > > brightness interface"
> > > > > > a7718360d91eedbedd58978ec8fff4a67a866f86 - thinkpad_acpi: Silence an uninitialized variable
> > > > > > warning
> > > > > > afcedebc6a094224973534f43b396bbbf33fe44e - thinkpad_acpi: save kbdlight state on suspend and
> > > > > > restore
> > > > > > it on
> > > > > > resume
> > > > > 
> > > > > Are these 3 fixes for the first one?
> > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 0118c2d3eac0545d4095877e5a015b5dc763b3c2 - thinkpad_acpi: Add support for HKEY version 0x200
> > > > > 
> > > > > Again, another feature :(
> > > > 
> > > > hmm, this was the one I really wanted as then wifi/video switch
> > > > buttons work on our Lenovo laptops we recently bought to replace old
> > > > HPs. I did not think this was to regard as a new feature, just a fix
> > > > to make the same buttons work as on other models, sorry.
> > > 
> > > It's a new feature for that model of laptop, otherwise we would be
> > > backporting everything all the time :(
> > 
> > Yes, but allowing new HW to work properly in older kernels was an exception or at least so I thought.
> > If here is a new minor version of the e1000 ethernet device which needs a few tweaks to
> > function on older kernels, do you not accept patches for that?
> 
> As the stable_kernel_rules.txt file says, yes, for simple quirk table
> and device id additions, yes we do.  But this involves new code and
> functions and really, a new feature implemented for that hardware.
> 
> > 
> > > 
> > > > 
> > > > The other patches were just there to make sure I didn't run inte
> > > > conflicts I didn't want to resolve.  They all made sense except for
> > > > maybe the one adding keyboard backlight. 
> > > > 
> > > > > 
> > > > > 
> > > > > And why aren't we cc:ing the maintainers of this subsystem?
> > > > 
> > > > Right, they are now. If you and/or maintainers do feel this is
> > > > inappropriate for stable I will just carry them my self until the next
> > > > major stable kernel is released.
> > > 
> > > What is wrong with 4.7-stable kernels?  Why are you "stuck" at 4.4?
> > >  
> > 
> > Non LTS kernels are fairly short lived. First you have wait for a few
> > patch levels(say >=5) before one can consider the kernel fairly
> > stable.
> 
> Why do you say that?  How do you judge stability?  You are getting
> bugfixes that are in Linus's tree, not that were specifically for that
> stable kernel release alone.
> 
> > 
> > After that there isn't that many release before it retired and you
> > have to look for the next stable kernel. 
> 
> Yes, it's a never ending treadmill, welcome to the real world :)
> 
> > 
> > Each time you migrate your kernel config between major releases there
> > is a risk something is mis migrated so one has to spend some time to
> > review/test the kernel.
> 
> How much time does this take you?  How do you do this review?  What does
> it entail?
> 
> > 
> > So I stay on LTS were I can and only systems really needing something
> > newer gets a non LTS kernel.
> > 
> > Note that this our company kernel, used on > 100 boxes and it is not
> > uncommon that something breaks somewhere after a major kernel upgrade,
> > usually because I missed some kernel config.
> 
> Are you testing the -rc kernels all along?  That's the best way to do
> this incrementally such that you don't miss something, and to let the
> developers know that there is something wrong.

I wish I had the time ...

> 
> I've been running every -rc on my personal machines for years without
> problems, people shouldn't be afraid of this.

But we are not talking about a few personal machines, we are talking about
all our Linux boxes at the office.

> 
> By waiting a full year, your "jump" is much larger and harder,
> especially for any new hardware, as you are finding out.  We can't go
> back in time and add support for hardware that wasn't around when that
> kernel release was being developed, so I recommend using the latest
> releases, or use a distro that does this work for you (Fedora,
> Tumbleweed, Arch, Debian unstable, etc.)
> 
> good luck!
> 
> greg k-h

Re: Add support for recent lenovo thinkpad HKEYS(Wifi/video swicth etc) buttons

[Vasiliy Tolstov]

2016-09-15 14:57 GMT+03:00 Joakim Tjernlund <Joakim.Tjernlund@infinera.com>:
> But we are not talking about a few personal machines, we are talking about
> all our Linux boxes at the office.


I backport some changes to 150 servers =) If you use right tool (like
opensuse build service) upgrade to all not to hard. Sorry for offtopic

-- 
Vasiliy Tolstov,
e-mail: v.tolstov@selfip.ru