* [PATCH v2] staging: ks7010: Remove explicit cast to kmalloc
@ 2016-09-14 20:59 sayli karnik
2016-09-15 5:21 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: sayli karnik @ 2016-09-14 20:59 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
The assignment operator implicitly converts a void pointer to the type of the
pointer it is assigned to. Hence an explicit cast to result of the kmalloc
function is not required.
Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
---
v2: Fixed the commit message, corrected a spelling error in the subject
drivers/staging/ks7010/ks_hostif.c | 47 +++++++++++++-------------------------
1 file changed, 16 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index f32ce5a..0a897c5 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -1172,9 +1172,8 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *packet)
}
DPRINTK(4, "skb_buff length=%d\n", packet_len);
- pp = (struct hostif_data_request_t *)
- kmalloc(hif_align_size(sizeof(*pp) + 6 + packet_len + 8),
- KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp) + 6 + packet_len + 8),
+ KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
@@ -1313,8 +1312,7 @@ void hostif_mib_get_request(struct ks_wlan_private *priv,
DPRINTK(3, "\n");
/* make primitive */
- pp = (struct hostif_mib_get_request_t *)
- kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
return;
@@ -1344,8 +1342,7 @@ void hostif_mib_set_request(struct ks_wlan_private *priv,
}
/* make primitive */
- pp = (struct hostif_mib_set_request_t *)
- kmalloc(hif_align_size(sizeof(*pp) + size), KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp) + size), KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
return;
@@ -1374,8 +1371,7 @@ void hostif_start_request(struct ks_wlan_private *priv, unsigned char mode)
DPRINTK(3, "\n");
/* make primitive */
- pp = (struct hostif_start_request_t *)
- kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
return;
@@ -1402,8 +1398,7 @@ void hostif_ps_adhoc_set_request(struct ks_wlan_private *priv)
DPRINTK(3, "\n");
/* make primitive */
- pp = (struct hostif_ps_adhoc_set_request_t *)
- kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
return;
@@ -1446,8 +1441,7 @@ void hostif_infrastructure_set_request(struct ks_wlan_private *priv)
DPRINTK(3, "ssid.size=%d \n", priv->reg.ssid.size);
/* make primitive */
- pp = (struct hostif_infrastructure_set_request_t *)
- kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
return;
@@ -1513,8 +1507,7 @@ void hostif_infrastructure_set2_request(struct ks_wlan_private *priv)
DPRINTK(2, "ssid.size=%d \n", priv->reg.ssid.size);
/* make primitive */
- pp = (struct hostif_infrastructure_set2_request_t *)
- kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
return;
@@ -1583,8 +1576,7 @@ void hostif_adhoc_set_request(struct ks_wlan_private *priv)
DPRINTK(3, "\n");
/* make primitive */
- pp = (struct hostif_adhoc_set_request_t *)
- kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
return;
@@ -1629,8 +1621,7 @@ void hostif_adhoc_set2_request(struct ks_wlan_private *priv)
DPRINTK(3, "\n");
/* make primitive */
- pp = (struct hostif_adhoc_set2_request_t *)
- kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
return;
@@ -1677,8 +1668,7 @@ void hostif_stop_request(struct ks_wlan_private *priv)
DPRINTK(3, "\n");
/* make primitive */
- pp = (struct hostif_stop_request_t *)
- kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
return;
@@ -1700,8 +1690,7 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)
DPRINTK(3, "\n");
/* make primitive */
- pp = (struct hostif_phy_information_request_t *)
- kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
return;
@@ -1732,8 +1721,7 @@ void hostif_power_mngmt_request(struct ks_wlan_private *priv,
DPRINTK(3, "mode=%lu wake_up=%lu receiveDTIMs=%lu\n", mode, wake_up,
receiveDTIMs);
/* make primitive */
- pp = (struct hostif_power_mngmt_request_t *)
- kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
return;
@@ -1759,8 +1747,7 @@ void hostif_sleep_request(struct ks_wlan_private *priv, unsigned long mode)
if (mode == SLP_SLEEP) {
/* make primitive */
- pp = (struct hostif_sleep_request_t *)
- kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
return;
@@ -1793,8 +1780,7 @@ void hostif_bss_scan_request(struct ks_wlan_private *priv,
DPRINTK(2, "\n");
/* make primitive */
- pp = (struct hostif_bss_scan_request_t *)
- kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
return;
@@ -1850,8 +1836,7 @@ void hostif_mic_failure_request(struct ks_wlan_private *priv,
DPRINTK(3, "count=%d :: timer=%d\n", failure_count, timer);
/* make primitive */
- pp = (struct hostif_mic_failure_request_t *)
- kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
+ pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
if (!pp) {
DPRINTK(3, "allocate memory failed..\n");
return;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Outreachy kernel] [PATCH v2] staging: ks7010: Remove explicit cast to kmalloc
2016-09-14 20:59 [PATCH v2] staging: ks7010: Remove explicit cast to kmalloc sayli karnik
@ 2016-09-15 5:21 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-09-15 5:21 UTC (permalink / raw)
To: sayli karnik; +Cc: outreachy-kernel, gregkh
On Thu, 15 Sep 2016, sayli karnik wrote:
> The assignment operator implicitly converts a void pointer to the type of the
> pointer it is assigned to. Hence an explicit cast to result of the kmalloc
> function is not required.
In "cast to result", "to" seems like the wrong word. One could cast an
expression to int, for example, ie cast to a type. Here it should be
"on".
julia
>
> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
> ---
> v2: Fixed the commit message, corrected a spelling error in the subject
> drivers/staging/ks7010/ks_hostif.c | 47 +++++++++++++-------------------------
> 1 file changed, 16 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index f32ce5a..0a897c5 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -1172,9 +1172,8 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *packet)
> }
>
> DPRINTK(4, "skb_buff length=%d\n", packet_len);
> - pp = (struct hostif_data_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp) + 6 + packet_len + 8),
> - KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp) + 6 + packet_len + 8),
> + KS_WLAN_MEM_FLAG);
>
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> @@ -1313,8 +1312,7 @@ void hostif_mib_get_request(struct ks_wlan_private *priv,
> DPRINTK(3, "\n");
>
> /* make primitive */
> - pp = (struct hostif_mib_get_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> return;
> @@ -1344,8 +1342,7 @@ void hostif_mib_set_request(struct ks_wlan_private *priv,
> }
>
> /* make primitive */
> - pp = (struct hostif_mib_set_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp) + size), KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp) + size), KS_WLAN_MEM_FLAG);
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> return;
> @@ -1374,8 +1371,7 @@ void hostif_start_request(struct ks_wlan_private *priv, unsigned char mode)
> DPRINTK(3, "\n");
>
> /* make primitive */
> - pp = (struct hostif_start_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> return;
> @@ -1402,8 +1398,7 @@ void hostif_ps_adhoc_set_request(struct ks_wlan_private *priv)
> DPRINTK(3, "\n");
>
> /* make primitive */
> - pp = (struct hostif_ps_adhoc_set_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> return;
> @@ -1446,8 +1441,7 @@ void hostif_infrastructure_set_request(struct ks_wlan_private *priv)
> DPRINTK(3, "ssid.size=%d \n", priv->reg.ssid.size);
>
> /* make primitive */
> - pp = (struct hostif_infrastructure_set_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> return;
> @@ -1513,8 +1507,7 @@ void hostif_infrastructure_set2_request(struct ks_wlan_private *priv)
> DPRINTK(2, "ssid.size=%d \n", priv->reg.ssid.size);
>
> /* make primitive */
> - pp = (struct hostif_infrastructure_set2_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> return;
> @@ -1583,8 +1576,7 @@ void hostif_adhoc_set_request(struct ks_wlan_private *priv)
> DPRINTK(3, "\n");
>
> /* make primitive */
> - pp = (struct hostif_adhoc_set_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> return;
> @@ -1629,8 +1621,7 @@ void hostif_adhoc_set2_request(struct ks_wlan_private *priv)
> DPRINTK(3, "\n");
>
> /* make primitive */
> - pp = (struct hostif_adhoc_set2_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> return;
> @@ -1677,8 +1668,7 @@ void hostif_stop_request(struct ks_wlan_private *priv)
> DPRINTK(3, "\n");
>
> /* make primitive */
> - pp = (struct hostif_stop_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> return;
> @@ -1700,8 +1690,7 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)
> DPRINTK(3, "\n");
>
> /* make primitive */
> - pp = (struct hostif_phy_information_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> return;
> @@ -1732,8 +1721,7 @@ void hostif_power_mngmt_request(struct ks_wlan_private *priv,
> DPRINTK(3, "mode=%lu wake_up=%lu receiveDTIMs=%lu\n", mode, wake_up,
> receiveDTIMs);
> /* make primitive */
> - pp = (struct hostif_power_mngmt_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> return;
> @@ -1759,8 +1747,7 @@ void hostif_sleep_request(struct ks_wlan_private *priv, unsigned long mode)
>
> if (mode == SLP_SLEEP) {
> /* make primitive */
> - pp = (struct hostif_sleep_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> return;
> @@ -1793,8 +1780,7 @@ void hostif_bss_scan_request(struct ks_wlan_private *priv,
>
> DPRINTK(2, "\n");
> /* make primitive */
> - pp = (struct hostif_bss_scan_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> return;
> @@ -1850,8 +1836,7 @@ void hostif_mic_failure_request(struct ks_wlan_private *priv,
>
> DPRINTK(3, "count=%d :: timer=%d\n", failure_count, timer);
> /* make primitive */
> - pp = (struct hostif_mic_failure_request_t *)
> - kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> + pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
> if (!pp) {
> DPRINTK(3, "allocate memory failed..\n");
> return;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914205927.GA28351%40sayli-HP-15-Notebook-PC.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-15 5:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14 20:59 [PATCH v2] staging: ks7010: Remove explicit cast to kmalloc sayli karnik
2016-09-15 5:21 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.