All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: "Brown, Aaron F" <aaron.f.brown@intel.com>
Cc: John Fastabend <john.fastabend@gmail.com>,
	"bblanco@plumgrid.com" <bblanco@plumgrid.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
	"brouer@redhat.com" <brouer@redhat.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"u9012063@gmail.com" <u9012063@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [net-next PATCH v3 1/3] e1000: track BQL bytes regardless of skb or not
Date: Wed, 14 Sep 2016 17:43:55 -0700	[thread overview]
Message-ID: <20160915004353.GA63116@ast-mbp.thefacebook.com> (raw)
In-Reply-To: <309B89C4C689E141A5FF6A0C5FB2118B81F90268@ORSMSX101.amr.corp.intel.com>

On Wed, Sep 14, 2016 at 11:57:24PM +0000, Brown, Aaron F wrote:
> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On
> > Behalf Of John Fastabend
> > Sent: Monday, September 12, 2016 3:13 PM
> > To: bblanco@plumgrid.com; john.fastabend@gmail.com;
> > alexei.starovoitov@gmail.com; Kirsher, Jeffrey T
> > <jeffrey.t.kirsher@intel.com>; brouer@redhat.com; davem@davemloft.net
> > Cc: xiyou.wangcong@gmail.com; intel-wired-lan@lists.osuosl.org;
> > u9012063@gmail.com; netdev@vger.kernel.org
> > Subject: [Intel-wired-lan] [net-next PATCH v3 1/3] e1000: track BQL bytes
> > regardless of skb or not
> > 
> > The BQL API does not reference the sk_buff nor does the driver need to
> > reference the sk_buff to calculate the length of a transmitted frame.
> > This patch removes an sk_buff reference from the xmit irq path and
> > also allows packets sent from XDP to use BQL.
> > 
> > Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> > ---
> >  drivers/net/ethernet/intel/e1000/e1000_main.c |    7 ++-----
> >  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> This patch is causing all my e1000 adapters to fail a simple ftp session with really slow response (hashing on) followed by adapter resets.  I have seen this on 4 different e1000 nics now, an 82543GC, 82544GC, 82546EB and an 82545GM.  On a few occasions I get a splat captured to dmesg.  Here is an example:
> --------------------------------
> ------------[ cut here ]------------
> WARNING: CPU: 1 PID: 0 at net/sched/sch_generic.c:316 dev_watchdog+0x1c2/0x1d0
> NETDEV WATCHDOG: eth1 (e1000): transmit queue 0 timed out

Thanks a lot for the tests! Really appreciate it.

WARNING: multiple messages have this Message-ID (diff)
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [net-next PATCH v3 1/3] e1000: track BQL bytes regardless of skb or not
Date: Wed, 14 Sep 2016 17:43:55 -0700	[thread overview]
Message-ID: <20160915004353.GA63116@ast-mbp.thefacebook.com> (raw)
In-Reply-To: <309B89C4C689E141A5FF6A0C5FB2118B81F90268@ORSMSX101.amr.corp.intel.com>

On Wed, Sep 14, 2016 at 11:57:24PM +0000, Brown, Aaron F wrote:
> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> > Behalf Of John Fastabend
> > Sent: Monday, September 12, 2016 3:13 PM
> > To: bblanco at plumgrid.com; john.fastabend at gmail.com;
> > alexei.starovoitov at gmail.com; Kirsher, Jeffrey T
> > <jeffrey.t.kirsher@intel.com>; brouer at redhat.com; davem at davemloft.net
> > Cc: xiyou.wangcong at gmail.com; intel-wired-lan at lists.osuosl.org;
> > u9012063 at gmail.com; netdev at vger.kernel.org
> > Subject: [Intel-wired-lan] [net-next PATCH v3 1/3] e1000: track BQL bytes
> > regardless of skb or not
> > 
> > The BQL API does not reference the sk_buff nor does the driver need to
> > reference the sk_buff to calculate the length of a transmitted frame.
> > This patch removes an sk_buff reference from the xmit irq path and
> > also allows packets sent from XDP to use BQL.
> > 
> > Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> > ---
> >  drivers/net/ethernet/intel/e1000/e1000_main.c |    7 ++-----
> >  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> This patch is causing all my e1000 adapters to fail a simple ftp session with really slow response (hashing on) followed by adapter resets.  I have seen this on 4 different e1000 nics now, an 82543GC, 82544GC, 82546EB and an 82545GM.  On a few occasions I get a splat captured to dmesg.  Here is an example:
> --------------------------------
> ------------[ cut here ]------------
> WARNING: CPU: 1 PID: 0 at net/sched/sch_generic.c:316 dev_watchdog+0x1c2/0x1d0
> NETDEV WATCHDOG: eth1 (e1000): transmit queue 0 timed out

Thanks a lot for the tests! Really appreciate it.


  reply	other threads:[~2016-09-15  0:44 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 22:13 [net-next PATCH v3 0/3] e1000 XDP implementation John Fastabend
2016-09-12 22:13 ` [Intel-wired-lan] " John Fastabend
2016-09-12 22:13 ` [net-next PATCH v3 1/3] e1000: track BQL bytes regardless of skb or not John Fastabend
2016-09-12 22:13   ` [Intel-wired-lan] " John Fastabend
2016-09-13  3:00   ` Alexander Duyck
2016-09-13  3:00     ` Alexander Duyck
2016-09-13  4:25     ` Tom Herbert
2016-09-13  4:25       ` Tom Herbert
2016-09-13 13:17       ` Alexander Duyck
2016-09-13 13:17         ` Alexander Duyck
2016-09-14 23:57   ` Brown, Aaron F
2016-09-14 23:57     ` Brown, Aaron F
2016-09-15  0:43     ` Alexei Starovoitov [this message]
2016-09-15  0:43       ` Alexei Starovoitov
2016-09-15  4:22       ` John Fastabend
2016-09-15  4:22         ` John Fastabend
2016-09-15 23:29       ` Brown, Aaron F
2016-09-15 23:29         ` Brown, Aaron F
2016-09-12 22:13 ` [net-next PATCH v3 2/3] e1000: add initial XDP support John Fastabend
2016-09-12 22:13   ` [Intel-wired-lan] " John Fastabend
2016-09-12 22:46   ` Eric Dumazet
2016-09-12 22:46     ` [Intel-wired-lan] " Eric Dumazet
2016-09-12 23:07     ` Alexei Starovoitov
2016-09-12 23:07       ` [Intel-wired-lan] " Alexei Starovoitov
2016-09-12 23:46       ` Eric Dumazet
2016-09-12 23:46         ` [Intel-wired-lan] " Eric Dumazet
2016-09-13  0:03         ` Tom Herbert
2016-09-13  0:03           ` [Intel-wired-lan] " Tom Herbert
2016-09-13  1:28           ` Alexei Starovoitov
2016-09-13  1:28             ` [Intel-wired-lan] " Alexei Starovoitov
2016-09-13 16:21             ` Tom Herbert
2016-09-13 16:21               ` [Intel-wired-lan] " Tom Herbert
2016-09-13 17:13               ` Alexei Starovoitov
2016-09-13 17:13                 ` [Intel-wired-lan] " Alexei Starovoitov
2016-09-13 17:37                 ` Eric Dumazet
2016-09-13 17:37                   ` [Intel-wired-lan] " Eric Dumazet
2016-09-13 17:59                   ` Alexei Starovoitov
2016-09-13 17:59                     ` [Intel-wired-lan] " Alexei Starovoitov
2016-09-13 18:28                     ` Rustad, Mark D
2016-09-13 18:28                       ` Rustad, Mark D
2016-09-13 18:30                       ` Alexei Starovoitov
2016-09-13 18:30                         ` Alexei Starovoitov
2016-09-13 19:14                         ` Rustad, Mark D
2016-09-13 19:14                           ` Rustad, Mark D
2016-09-13 21:52                           ` Alexei Starovoitov
2016-09-13 21:52                             ` Alexei Starovoitov
2016-09-13 22:41                             ` Rustad, Mark D
2016-09-13 22:41                               ` Rustad, Mark D
2016-09-13 23:40                               ` Alexei Starovoitov
2016-09-13 23:40                                 ` Alexei Starovoitov
2016-09-14  0:13                                 ` Rustad, Mark D
2016-09-14  0:13                                   ` Rustad, Mark D
2016-09-14 23:42                               ` Brown, Aaron F
2016-09-14 23:42                                 ` Brown, Aaron F
2016-09-13 23:17                           ` Francois Romieu
2016-09-13 23:17                             ` Francois Romieu
2016-09-13 17:55                 ` Tom Herbert
2016-09-13 17:55                   ` [Intel-wired-lan] " Tom Herbert
2016-09-13  1:21         ` Alexei Starovoitov
2016-09-13  1:21           ` [Intel-wired-lan] " Alexei Starovoitov
2016-09-18 17:25         ` Jesper Dangaard Brouer
2016-09-18 17:25           ` [Intel-wired-lan] " Jesper Dangaard Brouer
2016-09-18 18:06           ` Tom Herbert
2016-09-13  3:42   ` Alexander Duyck
2016-09-13  3:42     ` Alexander Duyck
2016-09-13 16:56     ` Alexei Starovoitov
2016-09-13 16:56       ` Alexei Starovoitov
2016-09-12 22:14 ` [net-next PATCH v3 3/3] e1000: bundle xdp xmit routines John Fastabend
2016-09-12 22:14   ` [Intel-wired-lan] " John Fastabend
2016-09-12 23:45   ` Tom Herbert
2016-09-12 23:45     ` [Intel-wired-lan] " Tom Herbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160915004353.GA63116@ast-mbp.thefacebook.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=aaron.f.brown@intel.com \
    --cc=bblanco@plumgrid.com \
    --cc=brouer@redhat.com \
    --cc=davem@davemloft.net \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=u9012063@gmail.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.