All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
@ 2016-09-15  2:15 ` Icenowy Zheng
  0 siblings, 0 replies; 7+ messages in thread
From: Icenowy Zheng @ 2016-09-15  2:15 UTC (permalink / raw)
  To: Rob Herring, Russell King, Maxime Ripard, Chen-Yu Tsai
  Cc: Mark Rutland, devicetree, linux-kernel, linux-arm-kernel, Icenowy Zheng

UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
on iNet D978 Rev2 board.

Enable the UART1 to make it possible to use the modified hciattach by
Realtek to drive the BT part of RTL8723BS.

On the board no r_uart pins are found now (the onboard RX/TX pins are
wired to PF2/PF4, which is muxed with mmc0), so also disabled it.

Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
---
 arch/arm/boot/dts/sun8i-a23-a33.dtsi           | 14 ++++++++++++++
 arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 20 ++++++++++++++++++++
 2 files changed, 34 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
index 7e05e09..c340885 100644
--- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
+++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
@@ -361,6 +361,20 @@
 				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
 			};
 
+			uart1_pins_a: uart1@0 {
+				allwinner,pins = "PG6", "PG7";
+				allwinner,function = "uart1";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart1_pins_cts_rts_a: uart1-cts-rts@0 {
+				allwinner,pins = "PG8", "PG9";
+				allwinner,function = "uart1";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
 			mmc0_pins_a: mmc0@0 {
 				allwinner,pins = "PF0", "PF1", "PF2",
 						 "PF3", "PF4", "PF5";
diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
index 0f52cd9..fb46655 100644
--- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
+++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
@@ -49,6 +49,15 @@
 	model = "INet-D978 Rev 02";
 	compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33";
 
+	aliases {
+		serial0 = &uart1;
+	};
+
+	chosen {
+		/* Delete debug UART as serial0 is the UART for bluetooth */
+		/delete-property/stdout-path;
+	};
+
 	leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
@@ -86,3 +95,14 @@
 		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
 	};
 };
+
+&r_uart {
+	status = "disabled";
+};
+
+&uart1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart1_pins_a>,
+		    <&uart1_pins_cts_rts_a>;
+	status = "okay";
+};
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
@ 2016-09-15  2:15 ` Icenowy Zheng
  0 siblings, 0 replies; 7+ messages in thread
From: Icenowy Zheng @ 2016-09-15  2:15 UTC (permalink / raw)
  To: linux-arm-kernel

UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
on iNet D978 Rev2 board.

Enable the UART1 to make it possible to use the modified hciattach by
Realtek to drive the BT part of RTL8723BS.

On the board no r_uart pins are found now (the onboard RX/TX pins are
wired to PF2/PF4, which is muxed with mmc0), so also disabled it.

Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
---
 arch/arm/boot/dts/sun8i-a23-a33.dtsi           | 14 ++++++++++++++
 arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 20 ++++++++++++++++++++
 2 files changed, 34 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
index 7e05e09..c340885 100644
--- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
+++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
@@ -361,6 +361,20 @@
 				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
 			};
 
+			uart1_pins_a: uart1 at 0 {
+				allwinner,pins = "PG6", "PG7";
+				allwinner,function = "uart1";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			uart1_pins_cts_rts_a: uart1-cts-rts at 0 {
+				allwinner,pins = "PG8", "PG9";
+				allwinner,function = "uart1";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
 			mmc0_pins_a: mmc0 at 0 {
 				allwinner,pins = "PF0", "PF1", "PF2",
 						 "PF3", "PF4", "PF5";
diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
index 0f52cd9..fb46655 100644
--- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
+++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
@@ -49,6 +49,15 @@
 	model = "INet-D978 Rev 02";
 	compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33";
 
+	aliases {
+		serial0 = &uart1;
+	};
+
+	chosen {
+		/* Delete debug UART as serial0 is the UART for bluetooth */
+		/delete-property/stdout-path;
+	};
+
 	leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
@@ -86,3 +95,14 @@
 		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
 	};
 };
+
+&r_uart {
+	status = "disabled";
+};
+
+&uart1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart1_pins_a>,
+		    <&uart1_pins_cts_rts_a>;
+	status = "okay";
+};
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
  2016-09-15  2:15 ` Icenowy Zheng
@ 2016-09-15  2:22   ` Icenowy Zheng
  -1 siblings, 0 replies; 7+ messages in thread
From: Icenowy Zheng @ 2016-09-15  2:22 UTC (permalink / raw)
  To: Rob Herring, Russell King, Maxime Ripard, Chen-Yu Tsai
  Cc: Mark Rutland, devicetree, linux-kernel, linux-arm-kernel



15.09.2016, 10:15, "Icenowy Zheng" <icenowy@aosc.xyz>:
> UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
> on iNet D978 Rev2 board.
>
> Enable the UART1 to make it possible to use the modified hciattach by
> Realtek to drive the BT part of RTL8723BS.
>
> On the board no r_uart pins are found now (the onboard RX/TX pins are
> wired to PF2/PF4, which is muxed with mmc0), so also disabled it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

Oh I forgot to add a patch version number...
It's PATCH v3.

(But it seems that I should send a v4 to split the dtsi change and dts change.)

> ---
>  arch/arm/boot/dts/sun8i-a23-a33.dtsi | 14 ++++++++++++++
>  arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 20 ++++++++++++++++++++
>  2 files changed, 34 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> index 7e05e09..c340885 100644
> --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> @@ -361,6 +361,20 @@
>                                  allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>                          };
>
> + uart1_pins_a: uart1@0 {
> + allwinner,pins = "PG6", "PG7";
> + allwinner,function = "uart1";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> +
> + uart1_pins_cts_rts_a: uart1-cts-rts@0 {
> + allwinner,pins = "PG8", "PG9";
> + allwinner,function = "uart1";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> +
>                          mmc0_pins_a: mmc0@0 {
>                                  allwinner,pins = "PF0", "PF1", "PF2",
>                                                   "PF3", "PF4", "PF5";
> diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
> index 0f52cd9..fb46655 100644
> --- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
> +++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
> @@ -49,6 +49,15 @@
>          model = "INet-D978 Rev 02";
>          compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33";
>
> + aliases {
> + serial0 = &uart1;
> + };
> +
> + chosen {
> + /* Delete debug UART as serial0 is the UART for bluetooth */
> + /delete-property/stdout-path;
> + };
> +
>          leds {
>                  compatible = "gpio-leds";
>                  pinctrl-names = "default";
> @@ -86,3 +95,14 @@
>                  allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>          };
>  };
> +
> +&r_uart {
> + status = "disabled";
> +};
> +
> +&uart1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart1_pins_a>,
> + <&uart1_pins_cts_rts_a>;
> + status = "okay";
> +};
> --
> 2.9.3

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
@ 2016-09-15  2:22   ` Icenowy Zheng
  0 siblings, 0 replies; 7+ messages in thread
From: Icenowy Zheng @ 2016-09-15  2:22 UTC (permalink / raw)
  To: linux-arm-kernel



15.09.2016, 10:15, "Icenowy Zheng" <icenowy@aosc.xyz>:
> UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
> on iNet D978 Rev2 board.
>
> Enable the UART1 to make it possible to use the modified hciattach by
> Realtek to drive the BT part of RTL8723BS.
>
> On the board no r_uart pins are found now (the onboard RX/TX pins are
> wired to PF2/PF4, which is muxed with mmc0), so also disabled it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

Oh I forgot to add a patch version number...
It's PATCH v3.

(But it seems that I should send a v4 to split the dtsi change and dts change.)

> ---
> ?arch/arm/boot/dts/sun8i-a23-a33.dtsi | 14 ++++++++++++++
> ?arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 20 ++++++++++++++++++++
> ?2 files changed, 34 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> index 7e05e09..c340885 100644
> --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> @@ -361,6 +361,20 @@
> ?????????????????????????????????allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> ?????????????????????????};
>
> + uart1_pins_a: uart1 at 0 {
> + allwinner,pins = "PG6", "PG7";
> + allwinner,function = "uart1";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> +
> + uart1_pins_cts_rts_a: uart1-cts-rts at 0 {
> + allwinner,pins = "PG8", "PG9";
> + allwinner,function = "uart1";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> +
> ?????????????????????????mmc0_pins_a: mmc0 at 0 {
> ?????????????????????????????????allwinner,pins = "PF0", "PF1", "PF2",
> ??????????????????????????????????????????????????"PF3", "PF4", "PF5";
> diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
> index 0f52cd9..fb46655 100644
> --- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
> +++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts
> @@ -49,6 +49,15 @@
> ?????????model = "INet-D978 Rev 02";
> ?????????compatible = "primux,inet-d978-rev2", "allwinner,sun8i-a33";
>
> + aliases {
> + serial0 = &uart1;
> + };
> +
> + chosen {
> + /* Delete debug UART as serial0 is the UART for bluetooth */
> + /delete-property/stdout-path;
> + };
> +
> ?????????leds {
> ?????????????????compatible = "gpio-leds";
> ?????????????????pinctrl-names = "default";
> @@ -86,3 +95,14 @@
> ?????????????????allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> ?????????};
> ?};
> +
> +&r_uart {
> + status = "disabled";
> +};
> +
> +&uart1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart1_pins_a>,
> + <&uart1_pins_cts_rts_a>;
> + status = "okay";
> +};
> --
> 2.9.3

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
@ 2016-09-15  8:35     ` Maxime Ripard
  0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2016-09-15  8:35 UTC (permalink / raw)
  To: Icenowy Zheng
  Cc: Rob Herring, Russell King, Chen-Yu Tsai, Mark Rutland,
	devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

On Thu, Sep 15, 2016 at 10:22:18AM +0800, Icenowy Zheng wrote:
> 
> 
> 15.09.2016, 10:15, "Icenowy Zheng" <icenowy@aosc.xyz>:
> > UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
> > on iNet D978 Rev2 board.
> >
> > Enable the UART1 to make it possible to use the modified hciattach by
> > Realtek to drive the BT part of RTL8723BS.
> >
> > On the board no r_uart pins are found now (the onboard RX/TX pins are
> > wired to PF2/PF4, which is muxed with mmc0), so also disabled it.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> 
> Oh I forgot to add a patch version number...
> It's PATCH v3.
> 
> (But it seems that I should send a v4 to split the dtsi change and dts change.)

Indeed :)

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
@ 2016-09-15  8:35     ` Maxime Ripard
  0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2016-09-15  8:35 UTC (permalink / raw)
  To: Icenowy Zheng
  Cc: Rob Herring, Russell King, Chen-Yu Tsai, Mark Rutland,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

On Thu, Sep 15, 2016 at 10:22:18AM +0800, Icenowy Zheng wrote:
> 
> 
> 15.09.2016, 10:15, "Icenowy Zheng" <icenowy-ymACFijhrKM@public.gmane.org>:
> > UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
> > on iNet D978 Rev2 board.
> >
> > Enable the UART1 to make it possible to use the modified hciattach by
> > Realtek to drive the BT part of RTL8723BS.
> >
> > On the board no r_uart pins are found now (the onboard RX/TX pins are
> > wired to PF2/PF4, which is muxed with mmc0), so also disabled it.
> >
> > Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
> 
> Oh I forgot to add a patch version number...
> It's PATCH v3.
> 
> (But it seems that I should send a v4 to split the dtsi change and dts change.)

Indeed :)

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board
@ 2016-09-15  8:35     ` Maxime Ripard
  0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2016-09-15  8:35 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Sep 15, 2016 at 10:22:18AM +0800, Icenowy Zheng wrote:
> 
> 
> 15.09.2016, 10:15, "Icenowy Zheng" <icenowy@aosc.xyz>:
> > UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card
> > on iNet D978 Rev2 board.
> >
> > Enable the UART1 to make it possible to use the modified hciattach by
> > Realtek to drive the BT part of RTL8723BS.
> >
> > On the board no r_uart pins are found now (the onboard RX/TX pins are
> > wired to PF2/PF4, which is muxed with mmc0), so also disabled it.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> 
> Oh I forgot to add a patch version number...
> It's PATCH v3.
> 
> (But it seems that I should send a v4 to split the dtsi change and dts change.)

Indeed :)

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160915/792e2739/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-09-15  8:35 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-15  2:15 [PATCH] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board Icenowy Zheng
2016-09-15  2:15 ` Icenowy Zheng
2016-09-15  2:22 ` Icenowy Zheng
2016-09-15  2:22   ` Icenowy Zheng
2016-09-15  8:35   ` Maxime Ripard
2016-09-15  8:35     ` Maxime Ripard
2016-09-15  8:35     ` Maxime Ripard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.