* [PATCH] staging: iio: adc: Add spaces around operator
@ 2016-09-15 16:42 Katie Dunne
2016-09-16 5:01 ` [Outreachy kernel] " Alison Schofield
0 siblings, 1 reply; 2+ messages in thread
From: Katie Dunne @ 2016-09-15 16:42 UTC (permalink / raw)
To: outreachy-kernel
Cc: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Hartmut Knaack, Peter Meerwald-Stadler
Issue found by checkpatch.pl
Signed-off-by: Katie Dunne <kdunne@mail.ccsf.edu>
---
drivers/staging/iio/adc/ad7280a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
index 2177f1d..bc40153 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -744,14 +744,14 @@ out:
}
static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
- in_voltage-voltage_thresh_low_value,
+ in_voltage - voltage_thresh_low_value,
S_IRUGO | S_IWUSR,
ad7280_read_channel_config,
ad7280_write_channel_config,
AD7280A_CELL_UNDERVOLTAGE);
static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
- in_voltage-voltage_thresh_high_value,
+ in_voltage - voltage_thresh_high_value,
S_IRUGO | S_IWUSR,
ad7280_read_channel_config,
ad7280_write_channel_config,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: iio: adc: Add spaces around operator
2016-09-15 16:42 [PATCH] staging: iio: adc: Add spaces around operator Katie Dunne
@ 2016-09-16 5:01 ` Alison Schofield
0 siblings, 0 replies; 2+ messages in thread
From: Alison Schofield @ 2016-09-16 5:01 UTC (permalink / raw)
To: Katie Dunne
Cc: outreachy-kernel, Lars-Peter Clausen, Michael Hennerich,
Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler
On Thu, Sep 15, 2016 at 09:42:48AM -0700, Katie Dunne wrote:
> Issue found by checkpatch.pl
Hi Katie,
This one's a checkpatch error. I'll just cut/paste the response
Jonathan gave to the person who sent it last week ;)
"Just to explain a bit more. Checkpatch is assuming that it is looking
at two parameters. It's not. That's a string being passed into the
macro. It ultimately forms a file name in sysfs.
p.s. We get patches for this from time to time ;( Unfortunately it's
a somewhat obscure case for checkpatch."
But, if this had been a valid patch, I also would add the feedback to
give the driver name in the subject - staging: iio: adc: ad7192:
Thanks,
alisons
>
> Signed-off-by: Katie Dunne <kdunne@mail.ccsf.edu>
> ---
> drivers/staging/iio/adc/ad7280a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index 2177f1d..bc40153 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -744,14 +744,14 @@ out:
> }
>
> static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> - in_voltage-voltage_thresh_low_value,
> + in_voltage - voltage_thresh_low_value,
> S_IRUGO | S_IWUSR,
> ad7280_read_channel_config,
> ad7280_write_channel_config,
> AD7280A_CELL_UNDERVOLTAGE);
>
> static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
> - in_voltage-voltage_thresh_high_value,
> + in_voltage - voltage_thresh_high_value,
> S_IRUGO | S_IWUSR,
> ad7280_read_channel_config,
> ad7280_write_channel_config,
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160915164248.GA4812%40katie-Inspiron-5748.
> For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-16 5:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-15 16:42 [PATCH] staging: iio: adc: Add spaces around operator Katie Dunne
2016-09-16 5:01 ` [Outreachy kernel] " Alison Schofield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.