From: Rob Herring <robh@kernel.org> To: Stephen Boyd <stephen.boyd@linaro.org> Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross <andy.gross@linaro.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Neil Armstrong <narmstrong@baylibre.com>, Arnd Bergmann <arnd@arndb.de>, Felipe Balbi <balbi@kernel.org>, Peter Chen <peter.chen@nxp.com>, Kishon Vijay Abraham I <kishon@ti.com>, devicetree@vger.kernel.org Subject: Re: [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy Date: Fri, 16 Sep 2016 10:19:51 -0500 [thread overview] Message-ID: <20160916151950.GA31804@rob-hp-laptop> (raw) In-Reply-To: <20160907213519.27340-23-stephen.boyd@linaro.org> On Wed, Sep 07, 2016 at 02:35:19PM -0700, Stephen Boyd wrote: > The high-speed phy on qcom SoCs is controlled via the ULPI > viewport. > > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Cc: <devicetree@vger.kernel.org> > Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org> > --- > .../devicetree/bindings/phy/qcom,usb-hs-phy.txt | 83 ++++++ > drivers/phy/Kconfig | 8 + > drivers/phy/Makefile | 1 + > drivers/phy/phy-qcom-usb-hs.c | 289 +++++++++++++++++++++ > 4 files changed, 381 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.txt > create mode 100644 drivers/phy/phy-qcom-usb-hs.c > > diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.txt b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.txt > new file mode 100644 > index 000000000000..d7eacd63d06b > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.txt > @@ -0,0 +1,83 @@ > +Qualcomm's USB HS PHY > + > +PROPERTIES > + > +- compatible: > + Usage: required > + Value type: <string> > + Definition: Should contain "qcom,usb-hs-phy" and more specifically one of the > + following: > + > + "qcom,usb-hs-phy-apq8064" > + "qcom,usb-hs-phy-msm8916" > + "qcom,usb-hs-phy-msm8974" This is fine, but things are usually named <soc>-<ipblock>. > + > +- #phy-cells: > + Usage: required > + Value type: <u32> > + Definition: Should contain 0 > + > +- clocks: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: Should contain clock specifier for the reference and sleep > + clocks > + > +- clock-names: > + Usage: required > + Value type: <stringlist> > + Definition: Should contain "ref" and "sleep" for the reference and sleep > + clocks respectively > + > +- resets: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: Should contain the phy and POR resets > + > +- reset-names: > + Usage: required > + Value type: <stringlist> > + Definition: Should contain "phy" and "por" for the phy and POR resets > + respectively > + > +- v3p3-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the 3.3V supply > + > +- v1p8-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the 1.8V supply > + > +- extcon: I don't recommend using extcon binding. It needs some work to put it nicely. > + Usage: optional > + Value type: <prop-encoded-array> > + Definition: Should contain the vbus and ID extcons in the first and second > + cells respectively > + > +- qcom,init-seq: > + Usage: optional > + Value type: <u8 array> > + Definition: Should contain a sequence of ULPI register and address pairs to > + program into the ULPI_EXT_VENDOR_SPECIFIC area. This is related > + to Device Mode Eye Diagram test. We generally nak this type of property. For 1 register I don't care so much. For 100, that would be another story. Is this value per unit, per board, per SoC? Can you limit it to certain registers? > + > +EXAMPLE > + > +otg: usb-controller { > + ulpi { > + phy { > + compatible = "qcom,usb-hs-phy-msm8974", "qcom,usb-hs-phy"; > + #phy-cells = <0>; > + clocks = <&xo_board>, <&gcc GCC_USB2A_PHY_SLEEP_CLK>; > + clock-names = "ref", "sleep"; > + resets = <&gcc GCC_USB2A_PHY_BCR>, <&otg 0>; > + reset-names = "phy", "por"; > + v3p3-supply = <&pm8941_l24>; > + v1p8-supply = <&pm8941_l6>; > + extcon = <&smbb>, <&usb_id>; > + qcom,init-seq = /bits/ 8 <0x81 0x63>; > + }; > + }; > +};
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy Date: Fri, 16 Sep 2016 10:19:51 -0500 [thread overview] Message-ID: <20160916151950.GA31804@rob-hp-laptop> (raw) In-Reply-To: <20160907213519.27340-23-stephen.boyd@linaro.org> On Wed, Sep 07, 2016 at 02:35:19PM -0700, Stephen Boyd wrote: > The high-speed phy on qcom SoCs is controlled via the ULPI > viewport. > > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Cc: <devicetree@vger.kernel.org> > Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org> > --- > .../devicetree/bindings/phy/qcom,usb-hs-phy.txt | 83 ++++++ > drivers/phy/Kconfig | 8 + > drivers/phy/Makefile | 1 + > drivers/phy/phy-qcom-usb-hs.c | 289 +++++++++++++++++++++ > 4 files changed, 381 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.txt > create mode 100644 drivers/phy/phy-qcom-usb-hs.c > > diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.txt b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.txt > new file mode 100644 > index 000000000000..d7eacd63d06b > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.txt > @@ -0,0 +1,83 @@ > +Qualcomm's USB HS PHY > + > +PROPERTIES > + > +- compatible: > + Usage: required > + Value type: <string> > + Definition: Should contain "qcom,usb-hs-phy" and more specifically one of the > + following: > + > + "qcom,usb-hs-phy-apq8064" > + "qcom,usb-hs-phy-msm8916" > + "qcom,usb-hs-phy-msm8974" This is fine, but things are usually named <soc>-<ipblock>. > + > +- #phy-cells: > + Usage: required > + Value type: <u32> > + Definition: Should contain 0 > + > +- clocks: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: Should contain clock specifier for the reference and sleep > + clocks > + > +- clock-names: > + Usage: required > + Value type: <stringlist> > + Definition: Should contain "ref" and "sleep" for the reference and sleep > + clocks respectively > + > +- resets: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: Should contain the phy and POR resets > + > +- reset-names: > + Usage: required > + Value type: <stringlist> > + Definition: Should contain "phy" and "por" for the phy and POR resets > + respectively > + > +- v3p3-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the 3.3V supply > + > +- v1p8-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the 1.8V supply > + > +- extcon: I don't recommend using extcon binding. It needs some work to put it nicely. > + Usage: optional > + Value type: <prop-encoded-array> > + Definition: Should contain the vbus and ID extcons in the first and second > + cells respectively > + > +- qcom,init-seq: > + Usage: optional > + Value type: <u8 array> > + Definition: Should contain a sequence of ULPI register and address pairs to > + program into the ULPI_EXT_VENDOR_SPECIFIC area. This is related > + to Device Mode Eye Diagram test. We generally nak this type of property. For 1 register I don't care so much. For 100, that would be another story. Is this value per unit, per board, per SoC? Can you limit it to certain registers? > + > +EXAMPLE > + > +otg: usb-controller { > + ulpi { > + phy { > + compatible = "qcom,usb-hs-phy-msm8974", "qcom,usb-hs-phy"; > + #phy-cells = <0>; > + clocks = <&xo_board>, <&gcc GCC_USB2A_PHY_SLEEP_CLK>; > + clock-names = "ref", "sleep"; > + resets = <&gcc GCC_USB2A_PHY_BCR>, <&otg 0>; > + reset-names = "phy", "por"; > + v3p3-supply = <&pm8941_l24>; > + v1p8-supply = <&pm8941_l6>; > + extcon = <&smbb>, <&usb_id>; > + qcom,init-seq = /bits/ 8 <0x81 0x63>; > + }; > + }; > +};
next prev parent reply other threads:[~2016-09-16 15:19 UTC|newest] Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-07 21:34 [PATCH v4 00/22] Support qcom's HSIC USB and rewrite USB2 HS support Stephen Boyd 2016-09-07 21:34 ` Stephen Boyd 2016-09-07 21:34 ` [PATCH v4 02/22] of: device: Export of_device_{get_modalias, uvent_modalias} to modules Stephen Boyd 2016-09-07 21:34 ` Stephen Boyd 2016-09-07 21:34 ` [PATCH v4 02/22] of: device: Export of_device_{get_modalias,uvent_modalias} " Stephen Boyd 2016-09-08 0:58 ` Rob Herring 2016-09-08 0:58 ` [PATCH v4 02/22] of: device: Export of_device_{get_modalias, uvent_modalias} " Rob Herring 2016-09-08 0:58 ` [PATCH v4 02/22] of: device: Export of_device_{get_modalias,uvent_modalias} " Rob Herring 2016-09-07 21:35 ` [PATCH v4 03/22] usb: ulpi: Support device discovery via DT Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd [not found] ` <20160907213519.27340-4-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-09-08 1:12 ` Rob Herring 2016-09-08 1:12 ` Rob Herring 2016-09-08 1:12 ` Rob Herring 2016-09-08 1:54 ` Stephen Boyd 2016-09-08 1:54 ` Stephen Boyd 2016-09-12 22:05 ` Stephen Boyd 2016-09-12 22:05 ` Stephen Boyd 2016-09-12 22:05 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 04/22] usb: chipidea: Only read/write OTGSC from one place Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 05/22] usb: chipidea: Handle extcon events properly Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 06/22] usb: chipidea: Add platform flag for wrapper phy management Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 07/22] usb: chipidea: Notify events when switching host mode Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 08/22] usb: chipidea: Remove locking in ci_udc_start() Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 09/22] usb: chipidea: Add support for ULPI PHY bus Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 10/22] usb: chipidea: Consolidate extcon notifiers Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-08 1:23 ` Peter Chen 2016-09-08 1:23 ` Peter Chen 2016-09-07 21:35 ` [PATCH v4 12/22] usb: chipidea: msm: Rely on core to override AHBBURST Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 15/22] usb: chipidea: msm: Mux over secondary phy at the right time Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 18/22] usb: chipidea: msm: Add reset controller for PHY POR bit Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 19/22] usb: chipidea: msm: Handle phy power states Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd [not found] ` <20160907213519.27340-1-stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2016-09-07 21:34 ` [PATCH v4 01/22] of: device: Support loading a module with OF based modalias Stephen Boyd 2016-09-07 21:34 ` Stephen Boyd 2016-09-07 21:34 ` Stephen Boyd 2016-09-08 0:58 ` Rob Herring 2016-09-08 0:58 ` Rob Herring 2016-09-08 0:58 ` Rob Herring 2016-09-07 21:35 ` [PATCH v4 11/22] usb: chipidea: msm: Mark device as runtime pm active Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 13/22] usb: chipidea: msm: Use hw_write_id_reg() instead of writel Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 14/22] usb: chipidea: msm: Add proper clk and reset support Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 16/22] usb: chipidea: msm: Restore wrapper settings after reset Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 17/22] usb: chipidea: msm: Make platform data driver local instead of global Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 20/22] usb: chipidea: msm: Be silent on probe defer errors Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` [PATCH v4 21/22] phy: Add support for Qualcomm's USB HSIC phy Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-16 14:21 ` Rob Herring 2016-09-16 14:21 ` Rob Herring 2016-09-07 21:35 ` [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-07 21:35 ` Stephen Boyd 2016-09-13 7:03 ` Peter Chen 2016-09-13 7:03 ` Peter Chen 2016-09-13 20:41 ` Stephen Boyd 2016-09-13 20:41 ` Stephen Boyd 2016-09-14 2:11 ` Peter Chen 2016-09-14 2:11 ` Peter Chen 2016-09-14 2:11 ` Peter Chen 2016-09-14 6:29 ` Stephen Boyd 2016-09-14 6:29 ` Stephen Boyd 2016-09-14 9:33 ` Peter Chen 2016-09-14 9:33 ` Peter Chen 2016-09-14 17:42 ` Stephen Boyd 2016-09-14 17:42 ` Stephen Boyd 2016-09-15 5:29 ` Peter Chen 2016-09-15 5:29 ` Peter Chen [not found] ` <20160910121857.GB11271@a0393678ub> 2016-09-14 5:29 ` Kishon Vijay Abraham I 2016-09-14 5:29 ` Kishon Vijay Abraham I 2016-09-14 5:29 ` Kishon Vijay Abraham I 2016-09-16 15:19 ` Rob Herring [this message] 2016-09-16 15:19 ` Rob Herring 2016-09-17 0:05 ` Stephen Boyd 2016-09-17 0:05 ` Stephen Boyd 2016-09-19 21:01 ` Rob Herring 2016-09-19 21:01 ` Rob Herring 2016-09-19 21:01 ` Rob Herring 2016-09-08 2:06 ` [PATCH v4 00/22] Support qcom's HSIC USB and rewrite USB2 HS support Peter Chen 2016-09-08 2:06 ` Peter Chen 2016-09-08 2:06 ` Peter Chen 2016-09-08 21:13 ` Stephen Boyd 2016-09-08 21:13 ` Stephen Boyd 2016-09-09 0:45 ` Peter Chen 2016-09-09 0:45 ` Peter Chen 2016-09-09 0:45 ` Peter Chen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160916151950.GA31804@rob-hp-laptop \ --to=robh@kernel.org \ --cc=andy.gross@linaro.org \ --cc=arnd@arndb.de \ --cc=balbi@kernel.org \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=kishon@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=narmstrong@baylibre.com \ --cc=peter.chen@nxp.com \ --cc=stephen.boyd@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.