From: maitysanchayan@gmail.com
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: "shawnguo@kernel.org" <shawnguo@kernel.org>,
"stefan@agner.ch" <stefan@agner.ch>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight
Date: Sat, 17 Sep 2016 10:15:32 +0530 [thread overview]
Message-ID: <20160917044532.GA5729@Sanchayan-Arch.localdomain> (raw)
In-Reply-To: <1474033134.3103.27.camel@toradex.com>
Hello Marcel,
On 16-09-16 13:38:54, Marcel Ziswiler wrote:
> On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote:
> > Use enable-gpios property of PWM backlight driver for backlight
> > control. While at it also fix the use of brightness levels required
> > by EDT displays which require inverted PWM's.
>
> That part I am missing below. Did you forget to include it?
No, actually I missed fixing the commit message. Currently PWM polarity
inversion is not supported and while checking, I kept the brightness
levels as is currently but did not change the commit message.
Will send a v2 and fix this.
Regards,
Sanchayan.
>
> > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> > ---
> > arch/arm/boot/dts/imx6qdl-apalis.dtsi | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > index 8c67dd8..9100bde 100644
> > --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > @@ -49,7 +49,10 @@
> >
> > backlight: backlight {
> > compatible = "pwm-backlight";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_gpio_bl_on>;
> > pwms = <&pwm4 0 5000000>;
> > + enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
> > status = "disabled";
> > };
> >
> > @@ -614,6 +617,12 @@
> > >;
> > };
> >
> > + pinctrl_gpio_bl_on: gpioblon {
> > + fsl,pins = <
> > + MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x1b0b0
> > + >;
> > + };
> > +
> > pinctrl_gpio_keys: gpio1io04grp {
> > fsl,pins = <
> > /* Power button */
WARNING: multiple messages have this Message-ID (diff)
From: maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
To: Marcel Ziswiler
<marcel.ziswiler-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
Cc: "shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"stefan-XLVq0VzYD2Y@public.gmane.org"
<stefan-XLVq0VzYD2Y@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight
Date: Sat, 17 Sep 2016 10:15:32 +0530 [thread overview]
Message-ID: <20160917044532.GA5729@Sanchayan-Arch.localdomain> (raw)
In-Reply-To: <1474033134.3103.27.camel-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
Hello Marcel,
On 16-09-16 13:38:54, Marcel Ziswiler wrote:
> On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote:
> > Use enable-gpios property of PWM backlight driver for backlight
> > control. While at it also fix the use of brightness levels required
> > by EDT displays which require inverted PWM's.
>
> That part I am missing below. Did you forget to include it?
No, actually I missed fixing the commit message. Currently PWM polarity
inversion is not supported and while checking, I kept the brightness
levels as is currently but did not change the commit message.
Will send a v2 and fix this.
Regards,
Sanchayan.
>
> > Signed-off-by: Sanchayan Maity <maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> > arch/arm/boot/dts/imx6qdl-apalis.dtsi | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > index 8c67dd8..9100bde 100644
> > --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > @@ -49,7 +49,10 @@
> >
> > backlight: backlight {
> > compatible = "pwm-backlight";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_gpio_bl_on>;
> > pwms = <&pwm4 0 5000000>;
> > + enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
> > status = "disabled";
> > };
> >
> > @@ -614,6 +617,12 @@
> > >;
> > };
> >
> > + pinctrl_gpio_bl_on: gpioblon {
> > + fsl,pins = <
> > + MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x1b0b0
> > + >;
> > + };
> > +
> > pinctrl_gpio_keys: gpio1io04grp {
> > fsl,pins = <
> > /* Power button */
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: maitysanchayan@gmail.com (maitysanchayan at gmail.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight
Date: Sat, 17 Sep 2016 10:15:32 +0530 [thread overview]
Message-ID: <20160917044532.GA5729@Sanchayan-Arch.localdomain> (raw)
In-Reply-To: <1474033134.3103.27.camel@toradex.com>
Hello Marcel,
On 16-09-16 13:38:54, Marcel Ziswiler wrote:
> On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote:
> > Use enable-gpios property of PWM backlight driver for backlight
> > control. While at it also fix the use of brightness levels required
> > by EDT displays which require inverted PWM's.
>
> That part I am missing below. Did you forget to include it?
No, actually I missed fixing the commit message. Currently PWM polarity
inversion is not supported and while checking, I kept the brightness
levels as is currently but did not change the commit message.
Will send a v2 and fix this.
Regards,
Sanchayan.
>
> > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> > ---
> > ?arch/arm/boot/dts/imx6qdl-apalis.dtsi | 9 +++++++++
> > ?1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > index 8c67dd8..9100bde 100644
> > --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> > @@ -49,7 +49,10 @@
> > ?
> > ? backlight: backlight {
> > ? compatible = "pwm-backlight";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_gpio_bl_on>;
> > ? pwms = <&pwm4 0 5000000>;
> > + enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
> > ? status = "disabled";
> > ? };
> > ?
> > @@ -614,6 +617,12 @@
> > ? >;
> > ? };
> > ?
> > + pinctrl_gpio_bl_on: gpioblon {
> > + fsl,pins = <
> > + MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x1b0b0
> > + >;
> > + };
> > +
> > ? pinctrl_gpio_keys: gpio1io04grp {
> > ? fsl,pins = <
> > ? /* Power button */
next prev parent reply other threads:[~2016-09-17 4:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 6:35 [PATCH v1 1/3] ARM: dts: imx6qdl-apalis: Do not rely on DDC I2C bus bitbang for HDMI Sanchayan Maity
2016-09-14 6:35 ` Sanchayan Maity
2016-09-14 6:35 ` Sanchayan Maity
2016-09-14 6:35 ` [PATCH v1 2/3] ARM: dts: imx6q-apalis-ixora: Remove use of pwm-leds Sanchayan Maity
2016-09-14 6:35 ` Sanchayan Maity
2016-09-14 15:58 ` Stefan Agner
2016-09-14 15:58 ` Stefan Agner
2016-09-14 15:58 ` Stefan Agner
2016-09-14 18:28 ` Marcel Ziswiler
2016-09-14 18:28 ` Marcel Ziswiler
2016-09-14 18:28 ` Marcel Ziswiler
2016-09-16 13:38 ` Marcel Ziswiler
2016-09-16 13:38 ` Marcel Ziswiler
2016-09-16 13:38 ` Marcel Ziswiler
2016-09-14 6:35 ` [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight Sanchayan Maity
2016-09-14 6:35 ` Sanchayan Maity
2016-09-16 13:38 ` Marcel Ziswiler
2016-09-16 13:38 ` Marcel Ziswiler
2016-09-16 13:38 ` Marcel Ziswiler
2016-09-17 4:45 ` maitysanchayan [this message]
2016-09-17 4:45 ` maitysanchayan at gmail.com
2016-09-17 4:45 ` maitysanchayan-Re5JQEeQqe8AvxtiuMwx3w
2016-09-16 13:38 ` [PATCH v1 1/3] ARM: dts: imx6qdl-apalis: Do not rely on DDC I2C bus bitbang for HDMI Marcel Ziswiler
2016-09-16 13:38 ` Marcel Ziswiler
2016-09-16 13:38 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160917044532.GA5729@Sanchayan-Arch.localdomain \
--to=maitysanchayan@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.