[PATCH] avr32: fix 'undefined reference to `___copy_from_user'

[PATCH] avr32: fix 'undefined reference to `___copy_from_user'

[Guenter Roeck]

avr32 builds fail with:

arch/avr32/kernel/built-in.o: In function `arch_ptrace':
(.text+0x650): undefined reference to `___copy_from_user'
arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined
reference to `___copy_from_user'
kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax':
(.text+0x5dd8): undefined reference to `___copy_from_user'
kernel/built-in.o: In function `proc_dointvec_minmax_sysadmin':
sysctl.c:(.text+0x6174): undefined reference to `___copy_from_user'
kernel/built-in.o: In function `ptrace_has_cap':
ptrace.c:(.text+0x69c0): undefined reference to `___copy_from_user'
kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to
`___copy_from_user' follow

Fixes: 8630c32275ba ("avr32: fix copy_from_user()")
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/avr32/lib/copy_user.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/avr32/lib/copy_user.S b/arch/avr32/lib/copy_user.S
index 96a6de9d578f..075373471da1 100644
--- a/arch/avr32/lib/copy_user.S
+++ b/arch/avr32/lib/copy_user.S
@@ -23,8 +23,8 @@
 	 */
 	.text
 	.align	1
-	.global	copy_from_user
-	.type	copy_from_user, @function
+	.global	___copy_from_user
+	.type	___copy_from_user, @function
 ___copy_from_user:
 	branch_if_kernel r8, __copy_user
 	ret_if_privileged r8, r11, r10, r10
-- 
2.5.0

Re: [PATCH] avr32: fix 'undefined reference to `___copy_from_user'

[Håvard Skinnemoen]

On Sat, Sep 17, 2016 at 7:56 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> avr32 builds fail with:
>
> arch/avr32/kernel/built-in.o: In function `arch_ptrace':
> (.text+0x650): undefined reference to `___copy_from_user'
> arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined
> reference to `___copy_from_user'
> kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax':
> (.text+0x5dd8): undefined reference to `___copy_from_user'
> kernel/built-in.o: In function `proc_dointvec_minmax_sysadmin':
> sysctl.c:(.text+0x6174): undefined reference to `___copy_from_user'
> kernel/built-in.o: In function `ptrace_has_cap':
> ptrace.c:(.text+0x69c0): undefined reference to `___copy_from_user'
> kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to
> `___copy_from_user' follow
>
> Fixes: 8630c32275ba ("avr32: fix copy_from_user()")
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Right, gmail loves HTML. Let me try this again...

Acked-by: Havard Skinnemoen <hskinnemoen@gmail.com>

Thanks!

Re: [PATCH] avr32: fix 'undefined reference to `___copy_from_user'

[Guenter Roeck]

On Sat, Sep 17, 2016 at 09:46:58AM -0700, Håvard Skinnemoen wrote:
> On Sat, Sep 17, 2016 at 7:56 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> 
> > avr32 builds fail with:
> >
> > arch/avr32/kernel/built-in.o: In function `arch_ptrace':
> > (.text+0x650): undefined reference to `___copy_from_user'
> > arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined
> > reference to `___copy_from_user'
> > kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax':
> > (.text+0x5dd8): undefined reference to `___copy_from_user'
> > kernel/built-in.o: In function `proc_dointvec_minmax_sysadmin':
> > sysctl.c:(.text+0x6174): undefined reference to `___copy_from_user'
> > kernel/built-in.o: In function `ptrace_has_cap':
> > ptrace.c:(.text+0x69c0): undefined reference to `___copy_from_user'
> > kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to
> > `___copy_from_user' follow
> >
> > Fixes: 8630c32275ba ("avr32: fix copy_from_user()")
> > Cc: Al Viro <viro@zeniv.linux.org.uk>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> >
> 
> Acked-by: Havard Skinnemoen <havard@skinnemoen.net>
> 
Al, I assume you'll send this to Linus ?

Thanks,
Guenter

Re: [PATCH] avr32: fix 'undefined reference to `___copy_from_user'

[Guenter Roeck]

On 09/17/2016 09:52 AM, Håvard Skinnemoen wrote:
> On Sat, Sep 17, 2016 at 7:56 AM, Guenter Roeck <linux@roeck-us.net> wrote:
>> avr32 builds fail with:
>>
>> arch/avr32/kernel/built-in.o: In function `arch_ptrace':
>> (.text+0x650): undefined reference to `___copy_from_user'
>> arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined
>> reference to `___copy_from_user'
>> kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax':
>> (.text+0x5dd8): undefined reference to `___copy_from_user'
>> kernel/built-in.o: In function `proc_dointvec_minmax_sysadmin':
>> sysctl.c:(.text+0x6174): undefined reference to `___copy_from_user'
>> kernel/built-in.o: In function `ptrace_has_cap':
>> ptrace.c:(.text+0x69c0): undefined reference to `___copy_from_user'
>> kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to
>> `___copy_from_user' follow
>>
>> Fixes: 8630c32275ba ("avr32: fix copy_from_user()")
>> Cc: Al Viro <viro@zeniv.linux.org.uk>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Right, gmail loves HTML. Let me try this again...
>
> Acked-by: Havard Skinnemoen <hskinnemoen@gmail.com>
>
> Thanks!
>
You are welcome ... I'll wait until tomorrow to see if Al wants to send this
patch and the patch for the openrisc failure to Linus; if I don't hear back,
I'll do it myself.

Guenter

Re: [PATCH] avr32: fix 'undefined reference to `___copy_from_user'

[Hans-Christian Noren Egtvedt]

Around Sat 17 Sep 2016 13:09:17 -0700 or thereabout, Guenter Roeck wrote:
> On 09/17/2016 09:52 AM, Håvard Skinnemoen wrote:
>>On Sat, Sep 17, 2016 at 7:56 AM, Guenter Roeck <linux@roeck-us.net> wrote:
>>>avr32 builds fail with:
>>>
>>>arch/avr32/kernel/built-in.o: In function `arch_ptrace':
>>>(.text+0x650): undefined reference to `___copy_from_user'
>>>arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined
>>>reference to `___copy_from_user'
>>>kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax':
>>>(.text+0x5dd8): undefined reference to `___copy_from_user'
>>>kernel/built-in.o: In function `proc_dointvec_minmax_sysadmin':
>>>sysctl.c:(.text+0x6174): undefined reference to `___copy_from_user'
>>>kernel/built-in.o: In function `ptrace_has_cap':
>>>ptrace.c:(.text+0x69c0): undefined reference to `___copy_from_user'
>>>kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to
>>>`___copy_from_user' follow
>>>
>>>Fixes: 8630c32275ba ("avr32: fix copy_from_user()")
>>>Cc: Al Viro <viro@zeniv.linux.org.uk>
>>>Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>
>>Right, gmail loves HTML. Let me try this again...
>>
>>Acked-by: Havard Skinnemoen <hskinnemoen@gmail.com>

Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>

>>Thanks!
>>
> You are welcome ... I'll wait until tomorrow to see if Al wants to send this
> patch and the patch for the openrisc failure to Linus; if I don't hear back,
> I'll do it myself.

Thanks, I have no other fixes for AVR32. But let me know if you want me to
push it through linux-avr32.

Why did not Al add Håvard/me to CC in the first place? That way we might have
avoided this build break in the first place?

-- 
Best regards,
Hans-Christian Noren Egtvedt

Re: [PATCH] avr32: fix 'undefined reference to `___copy_from_user'

[Guenter Roeck]

On 09/18/2016 02:46 AM, Hans-Christian Noren Egtvedt wrote:
> Around Sat 17 Sep 2016 13:09:17 -0700 or thereabout, Guenter Roeck wrote:
>> On 09/17/2016 09:52 AM, Håvard Skinnemoen wrote:
>>> On Sat, Sep 17, 2016 at 7:56 AM, Guenter Roeck <linux@roeck-us.net> wrote:
>>>> avr32 builds fail with:
>>>>
>>>> arch/avr32/kernel/built-in.o: In function `arch_ptrace':
>>>> (.text+0x650): undefined reference to `___copy_from_user'
>>>> arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined
>>>> reference to `___copy_from_user'
>>>> kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax':
>>>> (.text+0x5dd8): undefined reference to `___copy_from_user'
>>>> kernel/built-in.o: In function `proc_dointvec_minmax_sysadmin':
>>>> sysctl.c:(.text+0x6174): undefined reference to `___copy_from_user'
>>>> kernel/built-in.o: In function `ptrace_has_cap':
>>>> ptrace.c:(.text+0x69c0): undefined reference to `___copy_from_user'
>>>> kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to
>>>> `___copy_from_user' follow
>>>>
>>>> Fixes: 8630c32275ba ("avr32: fix copy_from_user()")
>>>> Cc: Al Viro <viro@zeniv.linux.org.uk>
>>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>> Right, gmail loves HTML. Let me try this again...
>>>
>>> Acked-by: Havard Skinnemoen <hskinnemoen@gmail.com>
>
> Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>
>
>>> Thanks!
>>>
>> You are welcome ... I'll wait until tomorrow to see if Al wants to send this
>> patch and the patch for the openrisc failure to Linus; if I don't hear back,
>> I'll do it myself.
>
> Thanks, I have no other fixes for AVR32. But let me know if you want me to
> push it through linux-avr32.
>
I have another related fix (for openrisc), so let me just send both.
I'll do that in an hour or so.

Thanks,
Guenter