All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] docs: correct values for old VMDP unplug
@ 2016-09-19  9:29 Olaf Hering
  2016-09-19 11:16 ` Wei Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2016-09-19  9:29 UTC (permalink / raw)
  To: xen-devel
  Cc: Olaf Hering, Stefano Stabellini, Wei Liu, George Dunlap,
	Andrew Cooper, Ian Jackson, Tim Deegan, Jan Beulich

Fix commit f6d4cf5 ("docs: document old SUSE/Novell unplug for HVM").
The values which VMDP used to control either NIC or disk are flipped.
What the code does is:

     case 8:
        if (val == 1 ) {
                ide_unplug_harddisks();
        } else if (val == 2) {
                pci_unplug_netifs();
                net_tap_shutdown_all();
        }
        break;

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 docs/misc/hvm-emulated-unplug.markdown | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown
index 70fb024..256cea2 100644
--- a/docs/misc/hvm-emulated-unplug.markdown
+++ b/docs/misc/hvm-emulated-unplug.markdown
@@ -89,8 +89,8 @@ Novells VMDP. Depending on how VMDP was configured it would control all
 devices, or either NIC or storage. To control all devices the value 0x1
 was written to offset 0x4 in the memory region of the Xen Platform PCI
 Device. This was supposed to unplug NIC, IDE and SCSI devices. If VMDP
-was configured to control just NIC devices it would write the value 0x1
+was configured to control just NIC devices it would write the value 0x2
 to offset 0x8. If VMDP was configured to control just storage devices it
-would write the value 0x2 to offset 0x8. Starting with VMDP version 1.7
+would write the value 0x1 to offset 0x8. Starting with VMDP version 1.7
 (released 2011) the official protocol was used.
 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: correct values for old VMDP unplug
  2016-09-19  9:29 [PATCH] docs: correct values for old VMDP unplug Olaf Hering
@ 2016-09-19 11:16 ` Wei Liu
  2016-09-19 11:34   ` Wei Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2016-09-19 11:16 UTC (permalink / raw)
  To: Olaf Hering
  Cc: Tim Deegan, Stefano Stabellini, Wei Liu, George Dunlap,
	Andrew Cooper, Ian Jackson, xen-devel, Jan Beulich

On Mon, Sep 19, 2016 at 09:29:46AM +0000, Olaf Hering wrote:
> Fix commit f6d4cf5 ("docs: document old SUSE/Novell unplug for HVM").
> The values which VMDP used to control either NIC or disk are flipped.
> What the code does is:
> 
>      case 8:
>         if (val == 1 ) {
>                 ide_unplug_harddisks();
>         } else if (val == 2) {
>                 pci_unplug_netifs();
>                 net_tap_shutdown_all();
>         }
>         break;
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: correct values for old VMDP unplug
  2016-09-19 11:16 ` Wei Liu
@ 2016-09-19 11:34   ` Wei Liu
  0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2016-09-19 11:34 UTC (permalink / raw)
  To: Olaf Hering
  Cc: Tim Deegan, Stefano Stabellini, Wei Liu, George Dunlap,
	Andrew Cooper, Ian Jackson, xen-devel, Jan Beulich

On Mon, Sep 19, 2016 at 12:16:06PM +0100, Wei Liu wrote:
> On Mon, Sep 19, 2016 at 09:29:46AM +0000, Olaf Hering wrote:
> > Fix commit f6d4cf5 ("docs: document old SUSE/Novell unplug for HVM").
> > The values which VMDP used to control either NIC or disk are flipped.
> > What the code does is:
> > 
> >      case 8:
> >         if (val == 1 ) {
> >                 ide_unplug_harddisks();
> >         } else if (val == 2) {
> >                 pci_unplug_netifs();
> >                 net_tap_shutdown_all();
> >         }
> >         break;
> > 
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Pushed.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-09-19 11:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-19  9:29 [PATCH] docs: correct values for old VMDP unplug Olaf Hering
2016-09-19 11:16 ` Wei Liu
2016-09-19 11:34   ` Wei Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.