* [PATCH] drm: include linux/seq_file.h as needed
@ 2016-09-19 12:51 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2016-09-19 12:51 UTC (permalink / raw)
To: Jani Nikula, David Airlie
Cc: Arnd Bergmann, Daniel Vetter, Dave Airlie, Mika Kahola,
Ville Syrjälä,
Lyude, dri-devel, linux-kernel
The addition of the debugfs info created references to seq_puts() and
seq_printf(), but relied on the debugfs header to be included implicitly,
which apparently doesn't happen all the time, as seen from this randconfig
build output:
drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_downstream_debug':
drivers/gpu/drm/drm_dp_helper.c:552:2: error: implicit declaration of function 'seq_printf' [-Werror=implicit-function-declaration]
drivers/gpu/drm/drm_dp_helper.c:560:3: error: implicit declaration of function 'seq_puts' [-Werror=implicit-function-declaration]
Adding the extra include brings back a clean build.
Fixes: 80209e5f2c42 ("drm: Add DP branch device info on debugfs")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/drm_dp_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index a07adf0a07db..3e6fe82c6d64 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -27,6 +27,7 @@
#include <linux/errno.h>
#include <linux/sched.h>
#include <linux/i2c.h>
+#include <linux/seq_file.h>
#include <drm/drm_dp_helper.h>
#include <drm/drmP.h>
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm: include linux/seq_file.h as needed
@ 2016-09-19 12:51 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2016-09-19 12:51 UTC (permalink / raw)
To: Jani Nikula, David Airlie
Cc: Arnd Bergmann, Daniel Vetter, linux-kernel, dri-devel,
Mika Kahola, Lyude
The addition of the debugfs info created references to seq_puts() and
seq_printf(), but relied on the debugfs header to be included implicitly,
which apparently doesn't happen all the time, as seen from this randconfig
build output:
drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_downstream_debug':
drivers/gpu/drm/drm_dp_helper.c:552:2: error: implicit declaration of function 'seq_printf' [-Werror=implicit-function-declaration]
drivers/gpu/drm/drm_dp_helper.c:560:3: error: implicit declaration of function 'seq_puts' [-Werror=implicit-function-declaration]
Adding the extra include brings back a clean build.
Fixes: 80209e5f2c42 ("drm: Add DP branch device info on debugfs")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/drm_dp_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index a07adf0a07db..3e6fe82c6d64 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -27,6 +27,7 @@
#include <linux/errno.h>
#include <linux/sched.h>
#include <linux/i2c.h>
+#include <linux/seq_file.h>
#include <drm/drm_dp_helper.h>
#include <drm/drmP.h>
--
2.9.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: include linux/seq_file.h as needed
2016-09-19 12:51 ` Arnd Bergmann
@ 2016-09-19 13:27 ` Jani Nikula
-1 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2016-09-19 13:27 UTC (permalink / raw)
To: Arnd Bergmann, David Airlie
Cc: Arnd Bergmann, Daniel Vetter, Dave Airlie, Mika Kahola,
Ville Syrjälä,
Lyude, dri-devel, linux-kernel
On Mon, 19 Sep 2016, Arnd Bergmann <arnd@arndb.de> wrote:
> The addition of the debugfs info created references to seq_puts() and
> seq_printf(), but relied on the debugfs header to be included implicitly,
> which apparently doesn't happen all the time, as seen from this randconfig
> build output:
>
> drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_downstream_debug':
> drivers/gpu/drm/drm_dp_helper.c:552:2: error: implicit declaration of function 'seq_printf' [-Werror=implicit-function-declaration]
> drivers/gpu/drm/drm_dp_helper.c:560:3: error: implicit declaration of function 'seq_puts' [-Werror=implicit-function-declaration]
>
> Adding the extra include brings back a clean build.
Beat you to it, but no review/acks...
http://patchwork.freedesktop.org/patch/msgid/1474020396-14875-1-git-send-email-jani.nikula@intel.com
BR,
Jani.
>
> Fixes: 80209e5f2c42 ("drm: Add DP branch device info on debugfs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index a07adf0a07db..3e6fe82c6d64 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -27,6 +27,7 @@
> #include <linux/errno.h>
> #include <linux/sched.h>
> #include <linux/i2c.h>
> +#include <linux/seq_file.h>
> #include <drm/drm_dp_helper.h>
> #include <drm/drmP.h>
--
Jani Nikula, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: include linux/seq_file.h as needed
@ 2016-09-19 13:27 ` Jani Nikula
0 siblings, 0 replies; 4+ messages in thread
From: Jani Nikula @ 2016-09-19 13:27 UTC (permalink / raw)
To: David Airlie
Cc: Arnd Bergmann, Daniel Vetter, linux-kernel, dri-devel,
Mika Kahola, Lyude
On Mon, 19 Sep 2016, Arnd Bergmann <arnd@arndb.de> wrote:
> The addition of the debugfs info created references to seq_puts() and
> seq_printf(), but relied on the debugfs header to be included implicitly,
> which apparently doesn't happen all the time, as seen from this randconfig
> build output:
>
> drivers/gpu/drm/drm_dp_helper.c: In function 'drm_dp_downstream_debug':
> drivers/gpu/drm/drm_dp_helper.c:552:2: error: implicit declaration of function 'seq_printf' [-Werror=implicit-function-declaration]
> drivers/gpu/drm/drm_dp_helper.c:560:3: error: implicit declaration of function 'seq_puts' [-Werror=implicit-function-declaration]
>
> Adding the extra include brings back a clean build.
Beat you to it, but no review/acks...
http://patchwork.freedesktop.org/patch/msgid/1474020396-14875-1-git-send-email-jani.nikula@intel.com
BR,
Jani.
>
> Fixes: 80209e5f2c42 ("drm: Add DP branch device info on debugfs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index a07adf0a07db..3e6fe82c6d64 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -27,6 +27,7 @@
> #include <linux/errno.h>
> #include <linux/sched.h>
> #include <linux/i2c.h>
> +#include <linux/seq_file.h>
> #include <drm/drm_dp_helper.h>
> #include <drm/drmP.h>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-19 13:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-19 12:51 [PATCH] drm: include linux/seq_file.h as needed Arnd Bergmann
2016-09-19 12:51 ` Arnd Bergmann
2016-09-19 13:27 ` Jani Nikula
2016-09-19 13:27 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.