[PATCH 1/2] staging: iio: isl29018: remove the FSF's mailing address

[PATCH 1/2] staging: iio: isl29018: remove the FSF's mailing address

[Brian Masney]

Address warning from checkpatch:

CHECK: Do not include the paragraph about writing to the Free Software
Foundation's mailing address from the sample GPL notice. The FSF has
changed addresses in the past, and may do so again. Linux already
includes a copy of the GPL.

Signed-off-by: Brian Masney <masneyb@onstation.org>
---
 drivers/staging/iio/light/isl29018.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
index 76d9f74..ea4d7f1 100644
--- a/drivers/staging/iio/light/isl29018.c
+++ b/drivers/staging/iio/light/isl29018.c
@@ -15,10 +15,6 @@
  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
  * more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA	02110-1301, USA.
  */
 
 #include <linux/module.h>
-- 
2.7.4

[PATCH 2/2] staging: iio: isl29018: fix alignment of function arguments

[Brian Masney]

Address warning from checkpatch:

CHECK: Alignment should match open parenthesis

Signed-off-by: Brian Masney <masneyb@onstation.org>
---
 drivers/staging/iio/light/isl29018.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
index ea4d7f1..4401451 100644
--- a/drivers/staging/iio/light/isl29018.c
+++ b/drivers/staging/iio/light/isl29018.c
@@ -607,8 +607,8 @@ static int isl29018_chip_init(struct isl29018_chip *chip)
 		return status;
 	}
 
-	status = isl29018_set_integration_time(chip,
-			isl29018_int_utimes[chip->type][chip->int_time]);
+	status = isl29018_set_integration_time(
+			chip, isl29018_int_utimes[chip->type][chip->int_time]);
 	if (status < 0) {
 		dev_err(dev, "Init of isl29018 fails\n");
 		return status;
-- 
2.7.4

Re: [PATCH 2/2] staging: iio: isl29018: fix alignment of function arguments

[Dan Carpenter]

On Tue, Sep 20, 2016 at 05:38:57AM -0400, Brian Masney wrote:
> Address warning from checkpatch:
> 
> CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> ---
>  drivers/staging/iio/light/isl29018.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
> index ea4d7f1..4401451 100644
> --- a/drivers/staging/iio/light/isl29018.c
> +++ b/drivers/staging/iio/light/isl29018.c
> @@ -607,8 +607,8 @@ static int isl29018_chip_init(struct isl29018_chip *chip)
>  		return status;
>  	}
>  
> -	status = isl29018_set_integration_time(chip,
> -			isl29018_int_utimes[chip->type][chip->int_time]);
> +	status = isl29018_set_integration_time(
> +			chip, isl29018_int_utimes[chip->type][chip->int_time]);

Congrats on finding a hack to silence checkpatch but this doesn't really
improve the code at all...  It's ok to ignore checkpatch.pl.

regards,
dan carpenter