All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ext4: remove unused variable
@ 2016-09-20 16:16 Eric Engestrom
  2016-09-20 16:16 ` [PATCH 2/2] " Eric Engestrom
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Engestrom @ 2016-09-20 16:16 UTC (permalink / raw)
  To: linux-kernel
  Cc: Eric Engestrom, Theodore Ts'o, Andreas Dilger, linux-ext4

Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
 fs/ext4/dir.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c
index 67415e0..acd76f1 100644
--- a/fs/ext4/dir.c
+++ b/fs/ext4/dir.c
@@ -627,7 +627,7 @@ int ext4_check_all_de(struct inode *dir, struct buffer_head *bh, void *buf,
 		      int buf_size)
 {
 	struct ext4_dir_entry_2 *de;
-	int nlen, rlen;
+	int rlen;
 	unsigned int offset = 0;
 	char *top;
 
@@ -637,7 +637,6 @@ int ext4_check_all_de(struct inode *dir, struct buffer_head *bh, void *buf,
 		if (ext4_check_dir_entry(dir, NULL, de, bh,
 					 buf, buf_size, offset))
 			return -EFSCORRUPTED;
-		nlen = EXT4_DIR_REC_LEN(de->name_len);
 		rlen = ext4_rec_len_from_disk(de->rec_len, buf_size);
 		de = (struct ext4_dir_entry_2 *)((char *)de + rlen);
 		offset += rlen;
-- 
Cheers,
  Eric

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ext4: remove unused variable
  2016-09-20 16:16 [PATCH 1/2] ext4: remove unused variable Eric Engestrom
@ 2016-09-20 16:16 ` Eric Engestrom
  2016-09-30  6:15   ` Theodore Ts'o
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Engestrom @ 2016-09-20 16:16 UTC (permalink / raw)
  To: linux-kernel
  Cc: Eric Engestrom, Theodore Ts'o, Andreas Dilger, linux-ext4

Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
 fs/ext4/page-io.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
index a6132a7..b4cbee9 100644
--- a/fs/ext4/page-io.c
+++ b/fs/ext4/page-io.c
@@ -405,14 +405,12 @@ int ext4_bio_write_page(struct ext4_io_submit *io,
 {
 	struct page *data_page = NULL;
 	struct inode *inode = page->mapping->host;
-	unsigned block_start, blocksize;
+	unsigned block_start;
 	struct buffer_head *bh, *head;
 	int ret = 0;
 	int nr_submitted = 0;
 	int nr_to_submit = 0;
 
-	blocksize = 1 << inode->i_blkbits;
-
 	BUG_ON(!PageLocked(page));
 	BUG_ON(PageWriteback(page));
 
-- 
Cheers,
  Eric

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] ext4: remove unused variable
  2016-09-20 16:16 ` [PATCH 2/2] " Eric Engestrom
@ 2016-09-30  6:15   ` Theodore Ts'o
  0 siblings, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2016-09-30  6:15 UTC (permalink / raw)
  To: Eric Engestrom; +Cc: linux-kernel, Andreas Dilger, linux-ext4

On Tue, Sep 20, 2016 at 05:16:19PM +0100, Eric Engestrom wrote:
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>

Thanks, I've applied both of these cleanups.

					- Ted

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-09-30  6:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-20 16:16 [PATCH 1/2] ext4: remove unused variable Eric Engestrom
2016-09-20 16:16 ` [PATCH 2/2] " Eric Engestrom
2016-09-30  6:15   ` Theodore Ts'o

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.