* [PATCH] cgroup/cpu: Fix tg_has_rt_task() malfunction
@ 2016-09-18 14:23 ` yingooyim
0 siblings, 0 replies; 6+ messages in thread
From: yingooyim @ 2016-09-18 14:23 UTC (permalink / raw)
To: tj, lizefan, hannes; +Cc: cgroups, LKML, jinh
Hi,
I am a graduate student of System Software Lab. at Konkuk University
(http://sslab.konkuk.ac.kr).
This patch is to fix the malfunction of tg_has_rt_tasks(). The
tg_has_rt_tasks() function is supposed to determine whether a task
group includes an "rt task" or not. However, it returns true for
"dl task" too. The origin of this problem is that rt_task() called
by tg_has_rt_tasks() returns true for dl tasks. Because of this
problem, tg_rt_schedulable() that calls tg_has_rt_tasks() returns
–EBUSY if we try to initialize an rt task group, while a dl task
is running. That is, you cannot run an rt task group when there
exists a dl task in the system. Our patch provided in this post
simply makes the tg_has_rt_tasks() function return false for dl
tasks by calling dl_task() in the conditional statement.
Previously we have provided another patch for rt_task() (more
precisely rt_prio()) to resolve this problem as follows:
https://patchwork.kernel.org/patch/9299267/
However, a dependency issue were raised. So, we think that it is
better to modify tg_has_rt_tasks() instead of rt_task() itself.
Signed-off-by: Yin-goo Yim <ygyim@konkuk.ac.kr>
----
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 2a906f2..ee5ab2f 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7846,7 +7846,7 @@ static inline int tg_has_rt_tasks(struct task_group
*tg)
return 0;
for_each_process_thread(g, p) {
- if (rt_task(p) && task_group(p) == tg)
+ if (rt_task(p) && !dl_task(p) && task_group(p) == tg)
return 1;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] cgroup/cpu: Fix tg_has_rt_task() malfunction
@ 2016-09-18 14:23 ` yingooyim
0 siblings, 0 replies; 6+ messages in thread
From: yingooyim @ 2016-09-18 14:23 UTC (permalink / raw)
To: tj, lizefan, hannes; +Cc: cgroups, LKML, jinh
Hi,
I am a graduate student of System Software Lab. at Konkuk University
(http://sslab.konkuk.ac.kr).
This patch is to fix the malfunction of tg_has_rt_tasks(). The
tg_has_rt_tasks() function is supposed to determine whether a task
group includes an "rt task" or not. However, it returns true for
"dl task" too. The origin of this problem is that rt_task() called
by tg_has_rt_tasks() returns true for dl tasks. Because of this
problem, tg_rt_schedulable() that calls tg_has_rt_tasks() returns
–EBUSY if we try to initialize an rt task group, while a dl task
is running. That is, you cannot run an rt task group when there
exists a dl task in the system. Our patch provided in this post
simply makes the tg_has_rt_tasks() function return false for dl
tasks by calling dl_task() in the conditional statement.
Previously we have provided another patch for rt_task() (more
precisely rt_prio()) to resolve this problem as follows:
https://patchwork.kernel.org/patch/9299267/
However, a dependency issue were raised. So, we think that it is
better to modify tg_has_rt_tasks() instead of rt_task() itself.
Signed-off-by: Yin-goo Yim <ygyim@konkuk.ac.kr>
----
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 2a906f2..ee5ab2f 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7846,7 +7846,7 @@ static inline int tg_has_rt_tasks(struct task_group
*tg)
return 0;
for_each_process_thread(g, p) {
- if (rt_task(p) && task_group(p) == tg)
+ if (rt_task(p) && !dl_task(p) && task_group(p) == tg)
return 1;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] cgroup/cpu: Fix tg_has_rt_task() malfunction
2016-09-18 14:23 ` yingooyim
@ 2016-09-20 19:41 ` Tejun Heo
-1 siblings, 0 replies; 6+ messages in thread
From: Tejun Heo @ 2016-09-20 19:41 UTC (permalink / raw)
To: yingooyim; +Cc: lizefan, hannes, cgroups, LKML, jinh
On Sun, Sep 18, 2016 at 11:23:10PM +0900, yingooyim wrote:
> Hi,
> I am a graduate student of System Software Lab. at Konkuk University
> (http://sslab.konkuk.ac.kr).
>
> This patch is to fix the malfunction of tg_has_rt_tasks(). The
> tg_has_rt_tasks() function is supposed to determine whether a task
> group includes an "rt task" or not. However, it returns true for
> "dl task" too. The origin of this problem is that rt_task() called
> by tg_has_rt_tasks() returns true for dl tasks. Because of this
> problem, tg_rt_schedulable() that calls tg_has_rt_tasks() returns
> –EBUSY if we try to initialize an rt task group, while a dl task
> is running. That is, you cannot run an rt task group when there
> exists a dl task in the system. Our patch provided in this post
> simply makes the tg_has_rt_tasks() function return false for dl
> tasks by calling dl_task() in the conditional statement.
>
> Previously we have provided another patch for rt_task() (more
> precisely rt_prio()) to resolve this problem as follows:
> https://patchwork.kernel.org/patch/9299267/
> However, a dependency issue were raised. So, we think that it is
> better to modify tg_has_rt_tasks() instead of rt_task() itself.
>
> Signed-off-by: Yin-goo Yim <ygyim@konkuk.ac.kr>
Can you please repost with scheduler maintainers cc'd?
Ingo Molnar <mingo@redhat.com>
Peter Zijlstra <peterz@infradead.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cgroup/cpu: Fix tg_has_rt_task() malfunction
@ 2016-09-20 19:41 ` Tejun Heo
0 siblings, 0 replies; 6+ messages in thread
From: Tejun Heo @ 2016-09-20 19:41 UTC (permalink / raw)
To: yingooyim; +Cc: lizefan, hannes, cgroups, LKML, jinh
On Sun, Sep 18, 2016 at 11:23:10PM +0900, yingooyim wrote:
> Hi,
> I am a graduate student of System Software Lab. at Konkuk University
> (http://sslab.konkuk.ac.kr).
>
> This patch is to fix the malfunction of tg_has_rt_tasks(). The
> tg_has_rt_tasks() function is supposed to determine whether a task
> group includes an "rt task" or not. However, it returns true for
> "dl task" too. The origin of this problem is that rt_task() called
> by tg_has_rt_tasks() returns true for dl tasks. Because of this
> problem, tg_rt_schedulable() that calls tg_has_rt_tasks() returns
> –EBUSY if we try to initialize an rt task group, while a dl task
> is running. That is, you cannot run an rt task group when there
> exists a dl task in the system. Our patch provided in this post
> simply makes the tg_has_rt_tasks() function return false for dl
> tasks by calling dl_task() in the conditional statement.
>
> Previously we have provided another patch for rt_task() (more
> precisely rt_prio()) to resolve this problem as follows:
> https://patchwork.kernel.org/patch/9299267/
> However, a dependency issue were raised. So, we think that it is
> better to modify tg_has_rt_tasks() instead of rt_task() itself.
>
> Signed-off-by: Yin-goo Yim <ygyim@konkuk.ac.kr>
Can you please repost with scheduler maintainers cc'd?
Ingo Molnar <mingo@redhat.com>
Peter Zijlstra <peterz@infradead.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] cgroup/cpu: Fix tg_has_rt_task() malfunction
@ 2016-09-21 4:35 ` yingooyim
0 siblings, 0 replies; 6+ messages in thread
From: yingooyim @ 2016-09-21 4:35 UTC (permalink / raw)
To: tj, lizefan, hannes; +Cc: mingo, peterz, cgroups, LKML, jinh
Hi,
I am a graduate student of System Software Lab. at Konkuk University
(http://sslab.konkuk.ac.kr).
This patch is to fix the malfunction of tg_has_rt_tasks(). The
tg_has_rt_tasks() function is supposed to determine whether a task
group includes an "rt task" or not. However, it returns true for
"dl task" too. The origin of this problem is that rt_task() called
by tg_has_rt_tasks() returns true for dl tasks. Because of this
problem, tg_rt_schedulable() that calls tg_has_rt_tasks() returns
–EBUSY if we try to initialize an rt task group, while a dl task
is running. That is, you cannot run an rt task group when there
exists a dl task in the system. Our patch provided in this post
simply makes the tg_has_rt_tasks() function return false for dl
tasks by calling dl_task() in the conditional statement.
Previously we have provided another patch for rt_task() (more
precisely rt_prio()) to resolve this problem as follows:
https://patchwork.kernel.org/patch/9299267/
However, a dependency issue were raised. So, we think that it is
better to modify tg_has_rt_tasks() instead of rt_task() itself.
Signed-off-by: Yin-goo Yim <ygyim@konkuk.ac.kr>
----
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 2a906f2..ee5ab2f 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7846,7 +7846,7 @@ static inline int tg_has_rt_tasks(struct task_group
*tg)
return 0;
for_each_process_thread(g, p) {
- if (rt_task(p) && task_group(p) == tg)
+ if (rt_task(p) && !dl_task(p) && task_group(p) == tg)
return 1;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] cgroup/cpu: Fix tg_has_rt_task() malfunction
@ 2016-09-21 4:35 ` yingooyim
0 siblings, 0 replies; 6+ messages in thread
From: yingooyim @ 2016-09-21 4:35 UTC (permalink / raw)
To: tj-DgEjT+Ai2ygdnm+yROfE0A, lizefan-hv44wF8Li93QT0dZR+AlfA,
hannes-druUgvl0LCNAfugRpC6u6w
Cc: mingo-H+wXaHxf7aLQT0dZR+AlfA, peterz-wEGCiKHe2LqWVfeAwA7xHQ,
cgroups-u79uwXL29TY76Z2rM5mHXA, LKML,
jinh-vrdpybo1/PJOKQ8SreQ7dg
Hi,
I am a graduate student of System Software Lab. at Konkuk University
(http://sslab.konkuk.ac.kr).
This patch is to fix the malfunction of tg_has_rt_tasks(). The
tg_has_rt_tasks() function is supposed to determine whether a task
group includes an "rt task" or not. However, it returns true for
"dl task" too. The origin of this problem is that rt_task() called
by tg_has_rt_tasks() returns true for dl tasks. Because of this
problem, tg_rt_schedulable() that calls tg_has_rt_tasks() returns
–EBUSY if we try to initialize an rt task group, while a dl task
is running. That is, you cannot run an rt task group when there
exists a dl task in the system. Our patch provided in this post
simply makes the tg_has_rt_tasks() function return false for dl
tasks by calling dl_task() in the conditional statement.
Previously we have provided another patch for rt_task() (more
precisely rt_prio()) to resolve this problem as follows:
https://patchwork.kernel.org/patch/9299267/
However, a dependency issue were raised. So, we think that it is
better to modify tg_has_rt_tasks() instead of rt_task() itself.
Signed-off-by: Yin-goo Yim <ygyim-vrdpybo1/PJOKQ8SreQ7dg@public.gmane.org>
----
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 2a906f2..ee5ab2f 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -7846,7 +7846,7 @@ static inline int tg_has_rt_tasks(struct task_group
*tg)
return 0;
for_each_process_thread(g, p) {
- if (rt_task(p) && task_group(p) == tg)
+ if (rt_task(p) && !dl_task(p) && task_group(p) == tg)
return 1;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-21 4:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-18 14:23 [PATCH] cgroup/cpu: Fix tg_has_rt_task() malfunction yingooyim
2016-09-18 14:23 ` yingooyim
2016-09-20 19:41 ` Tejun Heo
2016-09-20 19:41 ` Tejun Heo
2016-09-21 4:35 yingooyim
2016-09-21 4:35 ` yingooyim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.