All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Engestrom <eric.engestrom@imgtec.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] debugfs: remove unused variable
Date: Wed, 21 Sep 2016 09:39:15 +0100	[thread overview]
Message-ID: <20160921083915.GH3075@imgtec.com> (raw)
In-Reply-To: <20160921080111.GB15998@kroah.com>

On Wed, Sep 21, 2016 at 10:01:11AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 20, 2016 at 05:17:15PM +0100, Eric Engestrom wrote:
> > Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> > ---
> >  fs/debugfs/file.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
> > index 592059f..04eca0b 100644
> > --- a/fs/debugfs/file.c
> > +++ b/fs/debugfs/file.c
> > @@ -195,7 +195,6 @@ static int full_proxy_release(struct inode *inode, struct file *filp)
> >  	const struct dentry *dentry = F_DENTRY(filp);
> >  	const struct file_operations *real_fops = REAL_FOPS_DEREF(dentry);
> >  	const struct file_operations *proxy_fops = filp->f_op;
> > -	int r = 0;
> >  
> >  	/*
> >  	 * We must not protect this against removal races here: the
> > @@ -204,7 +203,7 @@ static int full_proxy_release(struct inode *inode, struct file *filp)
> >  	 * ->i_private is still being meaningful here.
> >  	 */
> >  	if (real_fops->release)
> > -		r = real_fops->release(inode, filp);
> > +		real_fops->release(inode, filp);
> 
> Hm, shouldn't we be propagating the result back up the call chain?

You're right, sorry, I wasn't thinking. Correct fix incoming :)

Cheers,
  Eric

> 
> thanks,
> 
> greg k-h

  parent reply	other threads:[~2016-09-21  8:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20 16:17 [PATCH] debugfs: remove unused variable Eric Engestrom
2016-09-21  8:01 ` Greg Kroah-Hartman
2016-09-21  8:36   ` [PATCH] debugfs: propagate release() call result Eric Engestrom
2016-09-21  9:15     ` Greg Kroah-Hartman
2016-09-21  9:27       ` [PATCH v2] " Eric Engestrom
2016-09-21  8:39   ` Eric Engestrom [this message]
2016-09-21  8:50   ` [PATCH] debugfs: remove unused variable Nicolai Stange
2016-09-21  9:23     ` Eric Engestrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160921083915.GH3075@imgtec.com \
    --to=eric.engestrom@imgtec.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.