All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Engestrom <eric.engestrom@imgtec.com>
To: <linux-kernel@vger.kernel.org>
Cc: Nicolai Stange <nicstange@gmail.com>,
	Eric Engestrom <eric.engestrom@imgtec.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v2] debugfs: propagate release() call result
Date: Wed, 21 Sep 2016 10:27:36 +0100	[thread overview]
Message-ID: <20160921092736.4889-1-eric.engestrom@imgtec.com> (raw)
In-Reply-To: <20160921091509.GA24316@kroah.com>

The result was being ignored and 0 was always returned.
Return the actual result instead.

Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
v2: add a commit message
---
 fs/debugfs/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
index 592059f..40e586f 100644
--- a/fs/debugfs/file.c
+++ b/fs/debugfs/file.c
@@ -209,7 +209,7 @@ static int full_proxy_release(struct inode *inode, struct file *filp)
 	replace_fops(filp, d_inode(dentry)->i_fop);
 	kfree((void *)proxy_fops);
 	fops_put(real_fops);
-	return 0;
+	return r;
 }
 
 static void __full_proxy_fops_init(struct file_operations *proxy_fops,
-- 
Cheers,
  Eric

  reply	other threads:[~2016-09-21  9:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20 16:17 [PATCH] debugfs: remove unused variable Eric Engestrom
2016-09-21  8:01 ` Greg Kroah-Hartman
2016-09-21  8:36   ` [PATCH] debugfs: propagate release() call result Eric Engestrom
2016-09-21  9:15     ` Greg Kroah-Hartman
2016-09-21  9:27       ` Eric Engestrom [this message]
2016-09-21  8:39   ` [PATCH] debugfs: remove unused variable Eric Engestrom
2016-09-21  8:50   ` Nicolai Stange
2016-09-21  9:23     ` Eric Engestrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160921092736.4889-1-eric.engestrom@imgtec.com \
    --to=eric.engestrom@imgtec.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicstange@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.