* Remark on commit a7900a116803 "fsnotify-convert-notification_mutex-to-a-spinlock-fix"
@ 2016-09-20 16:59 Heiner Kallweit
2016-09-21 9:06 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2016-09-20 16:59 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-fsdevel, Lino Sanfilippo, Guenter Roeck, Andrew Morton
I was also hit by the false BUG_ON in the first version of the change
and checked how to fix it. The current fix IMHO is overly complex.
You could simply use assert_spin_locked(lock). It does exactly what
you want and it's even used in other places under fs/notify already.
Rgds, Heiner
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Remark on commit a7900a116803 "fsnotify-convert-notification_mutex-to-a-spinlock-fix"
2016-09-20 16:59 Remark on commit a7900a116803 "fsnotify-convert-notification_mutex-to-a-spinlock-fix" Heiner Kallweit
@ 2016-09-21 9:06 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2016-09-21 9:06 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Jan Kara, linux-fsdevel, Lino Sanfilippo, Guenter Roeck, Andrew Morton
On Tue 20-09-16 18:59:35, Heiner Kallweit wrote:
> I was also hit by the false BUG_ON in the first version of the change
> and checked how to fix it. The current fix IMHO is overly complex.
>
> You could simply use assert_spin_locked(lock). It does exactly what
> you want and it's even used in other places under fs/notify already.
Bah, I was searching for something like this and I failed. Thanks for the
pointer. I'll fix up the patch.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-21 9:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-20 16:59 Remark on commit a7900a116803 "fsnotify-convert-notification_mutex-to-a-spinlock-fix" Heiner Kallweit
2016-09-21 9:06 ` Jan Kara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.