[PATCH] dm: add swap_slot_free_notify handler

[PATCH] dm: add swap_slot_free_notify handler

[Wonhong Kwon]

swap_slot_free_notify callback has been added to block_device_operations to
allow freeing memory allocated by RAM-based swap device like zram or zswap
more aggressively.

In case of device mapper, it is also required if mapped target is being
used as swap device and it uses some in-memory metadata for swap entries.
This patch introduces swap_slot_free_notify callback into dm_blk_ops and
target device can implement its own handler to handle this via
slot_free_notify in target_type.

Signed-off-by: Wonhong Kwon <wonhong.kwon@lge.com>
---
 drivers/md/dm.c               | 19 +++++++++++++++++++
 include/linux/device-mapper.h |  3 +++
 2 files changed, 22 insertions(+)

diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index fa9b1cb..2749f95 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -2720,6 +2720,24 @@ static const struct pr_ops dm_pr_ops = {
 	.pr_clear	= dm_pr_clear,
 };
 
+static void dm_blk_slot_free_notify(struct block_device *bdev,
+				    unsigned long index)
+{
+	int srcu_idx;
+	struct mapped_device *md = bdev->bd_disk->private_data;
+	struct dm_table *map = dm_get_live_table(md, &srcu_idx);
+	struct dm_target *ti = dm_table_find_target(map, index);
+
+	if (!dm_target_is_valid(ti))
+		goto out;
+
+	if (ti->type->slot_free_notify)
+		ti->type->slot_free_notify(index);
+
+out:
+	dm_put_live_table(md, srcu_idx);
+}
+
 static const struct block_device_operations dm_blk_dops = {
 	.open = dm_blk_open,
 	.release = dm_blk_close,
@@ -2727,6 +2745,7 @@ static const struct block_device_operations dm_blk_dops = {
 	.direct_access = dm_blk_direct_access,
 	.getgeo = dm_blk_getgeo,
 	.pr_ops = &dm_pr_ops,
+	.swap_slot_free_notify = dm_blk_slot_free_notify,
 	.owner = THIS_MODULE
 };
 
diff --git a/include/linux/device-mapper.h b/include/linux/device-mapper.h
index 91acfce..589fd9a 100644
--- a/include/linux/device-mapper.h
+++ b/include/linux/device-mapper.h
@@ -133,6 +133,8 @@ typedef int (*dm_busy_fn) (struct dm_target *ti);
 typedef long (*dm_direct_access_fn) (struct dm_target *ti, sector_t sector,
 				     void **kaddr, pfn_t *pfn, long size);
 
+typedef void (*dm_slot_free_notify_fn) (unsigned long index);
+
 void dm_error(const char *message);
 
 struct dm_dev {
@@ -180,6 +182,7 @@ struct target_type {
 	dm_iterate_devices_fn iterate_devices;
 	dm_io_hints_fn io_hints;
 	dm_direct_access_fn direct_access;
+	dm_slot_free_notify_fn slot_free_notify;
 
 	/* For internal device-mapper use. */
 	struct list_head list;
-- 
1.9.1

Re: dm: add swap_slot_free_notify handler

[Mike Snitzer]

On Wed, Sep 21 2016 at  7:09pm -0400,
Wonhong Kwon <wonhong.kwon@lge.com> wrote:

> swap_slot_free_notify callback has been added to block_device_operations to
> allow freeing memory allocated by RAM-based swap device like zram or zswap
> more aggressively.
> 
> In case of device mapper, it is also required if mapped target is being
> used as swap device and it uses some in-memory metadata for swap entries.
> This patch introduces swap_slot_free_notify callback into dm_blk_ops and
> target device can implement its own handler to handle this via
> slot_free_notify in target_type.
> 
> Signed-off-by: Wonhong Kwon <wonhong.kwon@lge.com>

This change to DM core only makes sense once we have an upstream DM
target that implements slot_free_notify hook.

Re: dm: add swap_slot_free_notify handler

[David Kwon (권원홍)]

[-- Attachment #1.1: Type: text/plain, Size: 1221 bytes --]

Understood. Now I’m developing some target which is using this interface
locally, and I’ll send this patch again when I push this target to upstream.

From:  Mike Snitzer <snitzer@redhat.com>
Date:  2016년 9월 22일 목요일 오전 9:14
To:  David <wonhong.kwon@lge.com>
Cc:  <agk@redhat.com>, <dm-devel@redhat.com>, '이건호' <gunho.lee@lge.com>
Subject:  Re: dm: add swap_slot_free_notify handler

> On Wed, Sep 21 2016 at  7:09pm -0400,
> Wonhong Kwon <wonhong.kwon@lge.com> wrote:
> 
>>  swap_slot_free_notify callback has been added to block_device_operations to
>>  allow freeing memory allocated by RAM-based swap device like zram or zswap
>>  more aggressively.
>>  
>>  In case of device mapper, it is also required if mapped target is being
>>  used as swap device and it uses some in-memory metadata for swap entries.
>>  This patch introduces swap_slot_free_notify callback into dm_blk_ops and
>>  target device can implement its own handler to handle this via
>>  slot_free_notify in target_type.
>>  
>>  Signed-off-by: Wonhong Kwon <wonhong.kwon@lge.com>
> 
> This change to DM core only makes sense once we have an upstream DM
> target that implements slot_free_notify hook.
> 



[-- Attachment #1.2: Type: text/html, Size: 2739 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]