All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix Kconfig dependencies for FIPS
@ 2016-09-15 22:41 NTU
  2016-09-15 22:45 ` NTU
  2016-09-22  9:32 ` Herbert Xu
  0 siblings, 2 replies; 4+ messages in thread
From: NTU @ 2016-09-15 22:41 UTC (permalink / raw)
  To: linux-crypto

Currently FIPS depends on MODULE_SIG, even if MODULES is disabled.
This change allows the enabling of FIPS without support for modules.

If module loading support is enabled, only then does
FIPS require MODULE_SIG.

Signed-off-by: Alec Ari <neotheuser@gmail.com>
---
 crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 84d7148..fd28805 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -24,7 +24,7 @@ comment "Crypto core or helper"
 config CRYPTO_FIPS
     bool "FIPS 200 compliance"
     depends on (CRYPTO_ANSI_CPRNG || CRYPTO_DRBG) &&
!CRYPTO_MANAGER_DISABLE_TESTS
-    depends on MODULE_SIG
+    depends on (MODULE_SIG || !MODULES)
     help
       This options enables the fips boot option which is
       required if you want to system to operate in a FIPS 200
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix Kconfig dependencies for FIPS
  2016-09-15 22:41 [PATCH] Fix Kconfig dependencies for FIPS NTU
@ 2016-09-15 22:45 ` NTU
  2016-09-22  9:32 ` Herbert Xu
  1 sibling, 0 replies; 4+ messages in thread
From: NTU @ 2016-09-15 22:45 UTC (permalink / raw)
  To: linux-crypto

I hope I got this right, on my screen the first "depends on" line is
incorrectly truncated, hope this will not become problematic..

Alec Ari

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix Kconfig dependencies for FIPS
  2016-09-15 22:41 [PATCH] Fix Kconfig dependencies for FIPS NTU
  2016-09-15 22:45 ` NTU
@ 2016-09-22  9:32 ` Herbert Xu
  1 sibling, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2016-09-22  9:32 UTC (permalink / raw)
  To: NTU; +Cc: linux-crypto

NTU <neotheuser@gmail.com> wrote:
> Currently FIPS depends on MODULE_SIG, even if MODULES is disabled.
> This change allows the enabling of FIPS without support for modules.
> 
> If module loading support is enabled, only then does
> FIPS require MODULE_SIG.
> 
> Signed-off-by: Alec Ari <neotheuser@gmail.com>
> ---
> crypto/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 84d7148..fd28805 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -24,7 +24,7 @@ comment "Crypto core or helper"
> config CRYPTO_FIPS
>     bool "FIPS 200 compliance"
>     depends on (CRYPTO_ANSI_CPRNG || CRYPTO_DRBG) &&
> !CRYPTO_MANAGER_DISABLE_TESTS
> -    depends on MODULE_SIG
> +    depends on (MODULE_SIG || !MODULES)
>     help
>       This options enables the fips boot option which is
>       required if you want to system to operate in a FIPS 200

Your email has turned tabs into white spaces.  Please fix it
and resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] Fix Kconfig dependencies for FIPS
@ 2016-10-04 22:34 Alec Ari
  0 siblings, 0 replies; 4+ messages in thread
From: Alec Ari @ 2016-10-04 22:34 UTC (permalink / raw)
  To: linux-crypto

Currently FIPS depends on MODULE_SIG, even if MODULES is disabled.
This change allows the enabling of FIPS without support for modules.

If module loading support is enabled, only then does
FIPS require MODULE_SIG.

Signed-off-by: Alec Ari <neotheuser@gmail.com>
---
  crypto/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 84d7148..fd28805 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -24,7 +24,7 @@ comment "Crypto core or helper"
  config CRYPTO_FIPS
  	bool "FIPS 200 compliance"
  	depends on (CRYPTO_ANSI_CPRNG || CRYPTO_DRBG) && 
!CRYPTO_MANAGER_DISABLE_TESTS
-	depends on MODULE_SIG
+	depends on (MODULE_SIG || !MODULES)
  	help
  	  This options enables the fips boot option which is
  	  required if you want to system to operate in a FIPS 200
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-10-04 22:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-15 22:41 [PATCH] Fix Kconfig dependencies for FIPS NTU
2016-09-15 22:45 ` NTU
2016-09-22  9:32 ` Herbert Xu
2016-10-04 22:34 Alec Ari

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.