[PATCH] staging: ion: Fix checkpatch.pl coding style issues

[PATCH] staging: ion: Fix checkpatch.pl coding style issues

[Antti Keränen]

One warning was left in place that wanted a typedef (ion_user_handle_t) to be removed.
I think the typedef makes sense so I left it intact.

Signed-off-by: Antti Keränen <detegr@gmail.com>
---
 drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++--
 drivers/staging/android/uapi/ion.h                 | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
index 659aa71..bd45151 100644
--- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c
+++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
@@ -82,9 +82,9 @@ static int hi6220_ion_remove(struct platform_device *pdev)
 
 	ipdev = platform_get_drvdata(pdev);
 
-	for (i = 0; i < ipdev->data->nr; i++) {
+	for (i = 0; i < ipdev->data->nr; i++)
 		ion_heap_destroy(ipdev->heaps[i]);
-	}
+
 	ion_destroy_platform_data(ipdev->data);
 	ion_device_destroy(ipdev->idev);
 
diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
index 647f130..e629394 100644
--- a/drivers/staging/android/uapi/ion.h
+++ b/drivers/staging/android/uapi/ion.h
@@ -57,7 +57,7 @@ enum ion_heap_type {
 					 * cached, ion will do cache
 					 * maintenance when the buffer is
 					 * mapped for dma
-					*/
+					 */
 #define ION_FLAG_CACHED_NEEDS_SYNC 2	/*
 					 * mappings of this buffer will created
 					 * at mmap time, if this is set
-- 
2.9.3

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: ion: Fix checkpatch.pl coding style issues

[Greg KH]

On Thu, Sep 22, 2016 at 09:08:01AM +0300, Antti Keränen wrote:
> One warning was left in place that wanted a typedef (ion_user_handle_t) to be removed.
> I think the typedef makes sense so I left it intact.

This does not describe at all what type of changes you made, or why you
made them, only what you did not do, which is not the point of a
changelog text :(

Please fix this up and resend.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: ion: Fix checkpatch.pl coding style issues

[Antti Keränen]

This patch fixes two coding style issues found with checkpatch.pl. Both
of them are warnings.

uapi/ion.h had an unaligned block comment. ion/hisilicon/hi6220_ion.c
had unnecessary braces around a single statement block.

One warning in uapi/ion.h was left in place that wanted a typedef
(ion_user_handle_t) to be removed.  I think the typedef makes sense so
I left it intact.

Signed-off-by: Antti Keränen <detegr@gmail.com>
---
 drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++--
 drivers/staging/android/uapi/ion.h                 | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
index 659aa71..bd45151 100644
--- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c
+++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
@@ -82,9 +82,9 @@ static int hi6220_ion_remove(struct platform_device *pdev)
 
 	ipdev = platform_get_drvdata(pdev);
 
-	for (i = 0; i < ipdev->data->nr; i++) {
+	for (i = 0; i < ipdev->data->nr; i++)
 		ion_heap_destroy(ipdev->heaps[i]);
-	}
+
 	ion_destroy_platform_data(ipdev->data);
 	ion_device_destroy(ipdev->idev);
 
diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
index 647f130..e629394 100644
--- a/drivers/staging/android/uapi/ion.h
+++ b/drivers/staging/android/uapi/ion.h
@@ -57,7 +57,7 @@ enum ion_heap_type {
 					 * cached, ion will do cache
 					 * maintenance when the buffer is
 					 * mapped for dma
-					*/
+					 */
 #define ION_FLAG_CACHED_NEEDS_SYNC 2	/*
 					 * mappings of this buffer will created
 					 * at mmap time, if this is set
-- 
2.9.3

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: ion: Fix checkpatch.pl coding style issues

[Greg KH]

On Thu, Sep 22, 2016 at 09:57:16AM +0300, Antti Keränen wrote:
> This patch fixes two coding style issues found with checkpatch.pl. Both
> of them are warnings.

Ah, then this should be two separate patches :)

Also, always use scripts/get_maintainer.pl to determine who to cc: on a
patch.

> 
> uapi/ion.h had an unaligned block comment. ion/hisilicon/hi6220_ion.c
> had unnecessary braces around a single statement block.
> 
> One warning in uapi/ion.h was left in place that wanted a typedef
> (ion_user_handle_t) to be removed.  I think the typedef makes sense so
> I left it intact.

Again, this paragraph makes no sense, don't talk about what you did not
do, why would that matter in a changelog comment?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 0/2] staging: ion: Fix checkpatch.pl coding style issues

[Antti Keränen]

This set of patches fix two coding style warnings found with checkpatch.pl
I hope I got this correctly this time around :)

Antti Keränen (2):
  staging: ion: Fix a coding style issue
  staging: ion: Fix a coding style issue

 drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++--
 drivers/staging/android/uapi/ion.h                 | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.9.3

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 1/2] staging: ion: Fix a coding style issue

[Antti Keränen]

Remove unnecessary braces surrounding a single statement block

Signed-off-by: Antti Keränen <detegr@gmail.com>
---
 drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
index 659aa71..bd45151 100644
--- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c
+++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
@@ -82,9 +82,9 @@ static int hi6220_ion_remove(struct platform_device *pdev)
 
 	ipdev = platform_get_drvdata(pdev);
 
-	for (i = 0; i < ipdev->data->nr; i++) {
+	for (i = 0; i < ipdev->data->nr; i++)
 		ion_heap_destroy(ipdev->heaps[i]);
-	}
+
 	ion_destroy_platform_data(ipdev->data);
 	ion_device_destroy(ipdev->idev);
 
-- 
2.9.3

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 2/2] staging: ion: Fix a coding style issue

[Antti Keränen]

Correctly align an unaligned block comment

Signed-off-by: Antti Keränen <detegr@gmail.com>
---
 drivers/staging/android/uapi/ion.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
index 647f130..e629394 100644
--- a/drivers/staging/android/uapi/ion.h
+++ b/drivers/staging/android/uapi/ion.h
@@ -57,7 +57,7 @@ enum ion_heap_type {
 					 * cached, ion will do cache
 					 * maintenance when the buffer is
 					 * mapped for dma
-					*/
+					 */
 #define ION_FLAG_CACHED_NEEDS_SYNC 2	/*
 					 * mappings of this buffer will created
 					 * at mmap time, if this is set
-- 
2.9.3

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 0/2] staging: ion: Fix checkpatch.pl coding style issues

[Greg KH]

On Thu, Sep 22, 2016 at 05:13:07PM +0300, Antti Keränen wrote:
> This set of patches fix two coding style warnings found with checkpatch.pl
> I hope I got this correctly this time around :)
> 
> Antti Keränen (2):
>   staging: ion: Fix a coding style issue
>   staging: ion: Fix a coding style issue

Any reason you didn't use scripts/get_maintainer.pl to determine who to
send these patches to?

Please do so and resend them.

thanks,

greg k-h

[PATCH v3 1/2] staging: ion: Fix a coding style issue

[Antti Keränen]

Remove unnecessary braces surrounding a single statement block

Signed-off-by: Antti Keränen <detegr@gmail.com>
---
 drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
index 659aa71..bd45151 100644
--- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c
+++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
@@ -82,9 +82,9 @@ static int hi6220_ion_remove(struct platform_device *pdev)
 
 	ipdev = platform_get_drvdata(pdev);
 
-	for (i = 0; i < ipdev->data->nr; i++) {
+	for (i = 0; i < ipdev->data->nr; i++)
 		ion_heap_destroy(ipdev->heaps[i]);
-	}
+
 	ion_destroy_platform_data(ipdev->data);
 	ion_device_destroy(ipdev->idev);
 
-- 
2.9.3

[PATCH v3 2/2] staging: ion: Fix a coding style issue

[Antti Keränen]

Correctly align an unaligned block comment

Signed-off-by: Antti Keränen <detegr@gmail.com>
---
 drivers/staging/android/uapi/ion.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
index 647f130..e629394 100644
--- a/drivers/staging/android/uapi/ion.h
+++ b/drivers/staging/android/uapi/ion.h
@@ -57,7 +57,7 @@ enum ion_heap_type {
 					 * cached, ion will do cache
 					 * maintenance when the buffer is
 					 * mapped for dma
-					*/
+					 */
 #define ION_FLAG_CACHED_NEEDS_SYNC 2	/*
 					 * mappings of this buffer will created
 					 * at mmap time, if this is set
-- 
2.9.3

Re: [PATCH v3 1/2] staging: ion: Fix a coding style issue

[Laura Abbott]

On 09/22/2016 08:59 AM, Antti Keränen wrote:
> Remove unnecessary braces surrounding a single statement block
>

In the future, when sending different versions of a patch please
give a short summary of what's changed. I think this is just
a resend from v2 with more reviewers added but I'm not 100%
sure.

> Signed-off-by: Antti Keränen <detegr@gmail.com>
> ---

You can put your summary right here between the --- and the
diffstat.

>  drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> index 659aa71..bd45151 100644
> --- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> +++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> @@ -82,9 +82,9 @@ static int hi6220_ion_remove(struct platform_device *pdev)
>
>  	ipdev = platform_get_drvdata(pdev);
>
> -	for (i = 0; i < ipdev->data->nr; i++) {
> +	for (i = 0; i < ipdev->data->nr; i++)
>  		ion_heap_destroy(ipdev->heaps[i]);
> -	}
> +
>  	ion_destroy_platform_data(ipdev->data);
>  	ion_device_destroy(ipdev->idev);
>
>

The patch looks fine though so assuming nothing else has
changed

Acked-by: Laura Abbott <labbott@redhat.com>

Re: [PATCH v3 2/2] staging: ion: Fix a coding style issue

[Laura Abbott]

On 09/22/2016 08:59 AM, Antti Keränen wrote:
> Correctly align an unaligned block comment
>
> Signed-off-by: Antti Keränen <detegr@gmail.com>
> ---
>  drivers/staging/android/uapi/ion.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 647f130..e629394 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -57,7 +57,7 @@ enum ion_heap_type {
>  					 * cached, ion will do cache
>  					 * maintenance when the buffer is
>  					 * mapped for dma
> -					*/
> +					 */
>  #define ION_FLAG_CACHED_NEEDS_SYNC 2	/*
>  					 * mappings of this buffer will created
>  					 * at mmap time, if this is set
>

I've always hated these comments. Can you fix them to be regular
looking right above each #define?

Thanks,
Laura

[PATCH v4] staging: ion: Fix a coding style issue

[Antti Keränen]

This patch fixes the alignment of an allocation flag block comment
and moves the comments before each #define.

Signed-off-by: Antti Keränen <detegr@gmail.com>
---
In addition to fixing the alignment issue, this version of the patch moves
the comments from after the define lines to before the define lines.

 drivers/staging/android/uapi/ion.h | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
index 647f130..14cd873 100644
--- a/drivers/staging/android/uapi/ion.h
+++ b/drivers/staging/android/uapi/ion.h
@@ -52,18 +52,18 @@ enum ion_heap_type {
  * allocation flags - the lower 16 bits are used by core ion, the upper 16
  * bits are reserved for use by the heaps themselves.
  */
-#define ION_FLAG_CACHED 1		/*
-					 * mappings of this buffer should be
-					 * cached, ion will do cache
-					 * maintenance when the buffer is
-					 * mapped for dma
-					*/
-#define ION_FLAG_CACHED_NEEDS_SYNC 2	/*
-					 * mappings of this buffer will created
-					 * at mmap time, if this is set
-					 * caches must be managed
-					 * manually
-					 */
+
+/*
+ * mappings of this buffer should be cached, ion will do cache maintenance
+ * when the buffer is mapped for dma
+ */
+#define ION_FLAG_CACHED 1
+
+/*
+ * mappings of this buffer will created at mmap time, if this is set
+ * caches must be managed manually
+ */
+#define ION_FLAG_CACHED_NEEDS_SYNC 2
 
 /**
  * DOC: Ion Userspace API
-- 
2.9.3

Re: [PATCH v4] staging: ion: Fix a coding style issue

[Laura Abbott]

On 09/23/2016 11:03 AM, Antti Keränen wrote:
> This patch fixes the alignment of an allocation flag block comment
> and moves the comments before each #define.
>

Acked-by: Laura Abbott <labbott@redhat.com>

> Signed-off-by: Antti Keränen <detegr@gmail.com>
> ---
> In addition to fixing the alignment issue, this version of the patch moves
> the comments from after the define lines to before the define lines.
>
>  drivers/staging/android/uapi/ion.h | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 647f130..14cd873 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -52,18 +52,18 @@ enum ion_heap_type {
>   * allocation flags - the lower 16 bits are used by core ion, the upper 16
>   * bits are reserved for use by the heaps themselves.
>   */
> -#define ION_FLAG_CACHED 1		/*
> -					 * mappings of this buffer should be
> -					 * cached, ion will do cache
> -					 * maintenance when the buffer is
> -					 * mapped for dma
> -					*/
> -#define ION_FLAG_CACHED_NEEDS_SYNC 2	/*
> -					 * mappings of this buffer will created
> -					 * at mmap time, if this is set
> -					 * caches must be managed
> -					 * manually
> -					 */
> +
> +/*
> + * mappings of this buffer should be cached, ion will do cache maintenance
> + * when the buffer is mapped for dma
> + */
> +#define ION_FLAG_CACHED 1
> +
> +/*
> + * mappings of this buffer will created at mmap time, if this is set
> + * caches must be managed manually
> + */
> +#define ION_FLAG_CACHED_NEEDS_SYNC 2
>
>  /**
>   * DOC: Ion Userspace API
>