All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ata: Replace BUG() with BUG_ON().
@ 2016-09-21 19:59 Harman Kalra
  2016-09-22 15:47 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: Harman Kalra @ 2016-09-21 19:59 UTC (permalink / raw)
  To: b.zolnierkie, tj; +Cc: linux-ide, linux-kernel, Harman Kalra

Replace BUG() with BUG_ON().
Caught by coccinelle.

Signed-off-by: Harman Kalra <harman4linux@gmail.com>
---
 drivers/ata/pata_octeon_cf.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c
index 2724595..475a006 100644
--- a/drivers/ata/pata_octeon_cf.c
+++ b/drivers/ata/pata_octeon_cf.c
@@ -152,8 +152,7 @@ static void octeon_cf_set_piomode(struct ata_port *ap, struct ata_device *dev)
 		div = 8;
 	T = (int)((1000000000000LL * div) / octeon_get_io_clock_rate());
 
-	if (ata_timing_compute(dev, dev->pio_mode, &timing, T, T))
-		BUG();
+	BUG_ON(ata_timing_compute(dev, dev->pio_mode, &timing, T, T));
 
 	t1 = timing.setup;
 	if (t1)
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ata: Replace BUG() with BUG_ON().
  2016-09-21 19:59 [PATCH] ata: Replace BUG() with BUG_ON() Harman Kalra
@ 2016-09-22 15:47 ` Tejun Heo
  0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2016-09-22 15:47 UTC (permalink / raw)
  To: Harman Kalra; +Cc: b.zolnierkie, linux-ide, linux-kernel

On Thu, Sep 22, 2016 at 01:29:48AM +0530, Harman Kalra wrote:
> Replace BUG() with BUG_ON().
> Caught by coccinelle.
> 
> Signed-off-by: Harman Kalra <harman4linux@gmail.com>

Applied libata/for-4.9.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-22 15:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-21 19:59 [PATCH] ata: Replace BUG() with BUG_ON() Harman Kalra
2016-09-22 15:47 ` Tejun Heo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.