* [Qemu-devel] [PATCH] build-sys: fix find-in-path
@ 2016-09-23 12:35 Marc-André Lureau
2016-09-27 14:17 ` Markus Armbruster
2016-09-29 15:59 ` Michael Tokarev
0 siblings, 2 replies; 5+ messages in thread
From: Marc-André Lureau @ 2016-09-23 12:35 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Marc-André Lureau
Fix spelling, the GNU make text functions is not called "find-string"
but "findstring".
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
rules.mak | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rules.mak b/rules.mak
index 5c82c19..f721988 100644
--- a/rules.mak
+++ b/rules.mak
@@ -132,7 +132,7 @@ endef
# Looks in the PATH if the argument contains no slash, else only considers one
# specific directory. Returns an # empty string if the program doesn't exist
# there.
-find-in-path = $(if $(find-string /, $1), \
+find-in-path = $(if $(findstring /, $1), \
$(wildcard $1), \
$(wildcard $(patsubst %, %/$1, $(subst :, ,$(PATH)))))
--
2.10.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] build-sys: fix find-in-path
2016-09-23 12:35 [Qemu-devel] [PATCH] build-sys: fix find-in-path Marc-André Lureau
@ 2016-09-27 14:17 ` Markus Armbruster
2016-09-27 14:22 ` Marc-André Lureau
2016-09-29 15:59 ` Michael Tokarev
1 sibling, 1 reply; 5+ messages in thread
From: Markus Armbruster @ 2016-09-27 14:17 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-devel, qemu-trivial
Marc-André Lureau <marcandre.lureau@redhat.com> writes:
> Fix spelling, the GNU make text functions is not called "find-string"
> but "findstring".
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> rules.mak | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rules.mak b/rules.mak
> index 5c82c19..f721988 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -132,7 +132,7 @@ endef
> # Looks in the PATH if the argument contains no slash, else only considers one
> # specific directory. Returns an # empty string if the program doesn't exist
> # there.
> -find-in-path = $(if $(find-string /, $1), \
> +find-in-path = $(if $(findstring /, $1), \
> $(wildcard $1), \
> $(wildcard $(patsubst %, %/$1, $(subst :, ,$(PATH)))))
Impact?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] build-sys: fix find-in-path
2016-09-27 14:17 ` Markus Armbruster
@ 2016-09-27 14:22 ` Marc-André Lureau
2016-09-27 15:26 ` Markus Armbruster
0 siblings, 1 reply; 5+ messages in thread
From: Marc-André Lureau @ 2016-09-27 14:22 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Marc-André Lureau, qemu-devel, qemu-trivial
Hi
----- Original Message -----
> Marc-André Lureau <marcandre.lureau@redhat.com> writes:
>
> > Fix spelling, the GNU make text functions is not called "find-string"
> > but "findstring".
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> > rules.mak | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/rules.mak b/rules.mak
> > index 5c82c19..f721988 100644
> > --- a/rules.mak
> > +++ b/rules.mak
> > @@ -132,7 +132,7 @@ endef
> > # Looks in the PATH if the argument contains no slash, else only considers
> > one
> > # specific directory. Returns an # empty string if the program doesn't
> > exist
> > # there.
> > -find-in-path = $(if $(find-string /, $1), \
> > +find-in-path = $(if $(findstring /, $1), \
> > $(wildcard $1), \
> > $(wildcard $(patsubst %, %/$1, $(subst :, ,$(PATH)))))
>
> Impact?
Not much in current code base, it's only used by:
tests/tcg/Makefile:ifneq ($(call find-in-path, $(CC_I386)),)
So if you set CC_I386 to an absolute PATH, it's not going to run the I386_TESTS.
This is not very important yet, but better for correctness.
In the future, I hope qemu can have a better tcg-test framework (I am doing some experiment in https://github.com/elmarco/qemu/tree/tcg-tests/tests/tcg), and as part of this work, I found this bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] build-sys: fix find-in-path
2016-09-27 14:22 ` Marc-André Lureau
@ 2016-09-27 15:26 ` Markus Armbruster
0 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2016-09-27 15:26 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-trivial, Marc-André Lureau, qemu-devel
Marc-André Lureau <mlureau@redhat.com> writes:
> Hi
>
> ----- Original Message -----
>> Marc-André Lureau <marcandre.lureau@redhat.com> writes:
>>
>> > Fix spelling, the GNU make text functions is not called "find-string"
>> > but "findstring".
>> >
>> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> > ---
>> > rules.mak | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/rules.mak b/rules.mak
>> > index 5c82c19..f721988 100644
>> > --- a/rules.mak
>> > +++ b/rules.mak
>> > @@ -132,7 +132,7 @@ endef
>> > # Looks in the PATH if the argument contains no slash, else only considers
>> > one
>> > # specific directory. Returns an # empty string if the program doesn't
>> > exist
>> > # there.
>> > -find-in-path = $(if $(find-string /, $1), \
>> > +find-in-path = $(if $(findstring /, $1), \
>> > $(wildcard $1), \
>> > $(wildcard $(patsubst %, %/$1, $(subst :, ,$(PATH)))))
>>
>> Impact?
>
> Not much in current code base, it's only used by:
> tests/tcg/Makefile:ifneq ($(call find-in-path, $(CC_I386)),)
>
> So if you set CC_I386 to an absolute PATH, it's not going to run the I386_TESTS.
>
> This is not very important yet, but better for correctness.
>
> In the future, I hope qemu can have a better tcg-test framework (I am doing some experiment in https://github.com/elmarco/qemu/tree/tcg-tests/tests/tcg), and as part of this work, I found this bug.
Thanks. Suggest to amend the commit message with:
Broken in commit 2b2e59e. Fairly harmless: its only use is in
tests/tcg/Makefile, where the bug can cause the I386_TESTS not to
run when they should.
With this or something similar, you may add
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] build-sys: fix find-in-path
2016-09-23 12:35 [Qemu-devel] [PATCH] build-sys: fix find-in-path Marc-André Lureau
2016-09-27 14:17 ` Markus Armbruster
@ 2016-09-29 15:59 ` Michael Tokarev
1 sibling, 0 replies; 5+ messages in thread
From: Michael Tokarev @ 2016-09-29 15:59 UTC (permalink / raw)
To: Marc-André Lureau, qemu-devel; +Cc: qemu-trivial
Applied to trivial, with additional commit comment
suggested by Marcus, thanks!
/mjt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-29 15:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-23 12:35 [Qemu-devel] [PATCH] build-sys: fix find-in-path Marc-André Lureau
2016-09-27 14:17 ` Markus Armbruster
2016-09-27 14:22 ` Marc-André Lureau
2016-09-27 15:26 ` Markus Armbruster
2016-09-29 15:59 ` Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.