From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 2/2] Makefile: rm u-boot.cfg dependencies are missing
Date: Fri, 23 Sep 2016 14:37:07 -0400 [thread overview]
Message-ID: <20160923183707.GC8556@bill-the-cat> (raw)
In-Reply-To: <20160919182026.18533-2-swarren@wwwdotorg.org>
On Mon, Sep 19, 2016 at 12:20:26PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Prior to the previous patch, a freshly created .u-boot.cfg.cmd may not
> correctly represent all dependencies for u-boot.cfg. The previous change
> only solved this issue for fresh builds; when performing an incremental
> build, the deficient .u-boot.cfg.cmd is already present, so u-boot.cfg
> is not rebuilt, and hence .u-boot.cfg.cmd is not rebuilt with the correct
> content.
>
> Solve this by explicitly detecting when the dependency file .u-boot.cfg.d
> has not been integrated into .u-boot.cfg.cmd, and force u-boot.cfg to be
> rebuilt in this case by deleting it first. This is possible since
> if_changed_dep will always delete .u-boot.cfg.d when it executes
> successfully, so its presence means either that the previous build was
> made by a source tree that contained a Makefile that didn't include the
> previous patch, or that the build failed part way through executing
> if_changed_dep for u-boot.cfg. Forcing a rebuild of u-boot.cfg is required
> in the former case, and will cause no additional work in the latter case,
> since the file would be rebuilt anyway for the same reason it was being
> rebuilt by the previous build.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
A few days ago now, applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160923/470ab24a/attachment.sig>
next prev parent reply other threads:[~2016-09-23 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 18:20 [U-Boot] [PATCH 1/2] Makefile: use if_change_dep for u-boot.cfg Stephen Warren
2016-09-19 18:20 ` [U-Boot] [PATCH 2/2] Makefile: rm u-boot.cfg dependencies are missing Stephen Warren
2016-09-23 4:16 ` Simon Glass
2016-09-23 18:37 ` Tom Rini [this message]
2016-09-23 4:16 ` [U-Boot] [PATCH 1/2] Makefile: use if_change_dep for u-boot.cfg Simon Glass
2016-09-23 9:32 ` Masahiro Yamada
2016-09-24 0:05 ` Simon Glass
2016-09-23 18:36 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923183707.GC8556@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.