From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Makefile: use if_change_dep for u-boot.cfg
Date: Fri, 23 Sep 2016 18:32:38 +0900 [thread overview]
Message-ID: <CAK7LNAQ2mcKJDwC9GtCMrveQKyJ5h9VFAUvF8THQ12_JDONFFA@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ1+2PZdi=Uf+h8N7AXZBn1Xrr-hd=Wi-47XCCKwbLq3sQ@mail.gmail.com>
2016-09-23 13:16 GMT+09:00 Simon Glass <sjg@chromium.org>:
> On 19 September 2016 at 12:20, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> cmd_cpp_cfg generates a dependency output, but because it's invoked using
>> if_changed rather than if_changed_dep, that dependency file is ignored.
>> This results in Kbuild not knowing about which files u-boot.cfg depends
>> on, so it may not be rebuilt when required.
>>
>> A practical result of this is that u-boot.cfg may continue to reference
>> CONFIG_ options that no longer exist in the source tree, and this can
>> cause the adhoc config options check to fail.
>>
>> This change modifies Makefile to use if_changed_dep, which in turn causes
>> all dependencies to be known to the next make invocation.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
In the first place, why do we need u-boot.cfg?
CONFIG options from board headers are already collected in include/autoconf.mk.
I think the most correct way is to rework check-config.sh
to parse include/autoconf.mk (I can do this).
Then, remove all of the u-boot.cfg rules.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2016-09-23 9:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 18:20 [U-Boot] [PATCH 1/2] Makefile: use if_change_dep for u-boot.cfg Stephen Warren
2016-09-19 18:20 ` [U-Boot] [PATCH 2/2] Makefile: rm u-boot.cfg dependencies are missing Stephen Warren
2016-09-23 4:16 ` Simon Glass
2016-09-23 18:37 ` [U-Boot] [U-Boot, " Tom Rini
2016-09-23 4:16 ` [U-Boot] [PATCH 1/2] Makefile: use if_change_dep for u-boot.cfg Simon Glass
2016-09-23 9:32 ` Masahiro Yamada [this message]
2016-09-24 0:05 ` Simon Glass
2016-09-23 18:36 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAQ2mcKJDwC9GtCMrveQKyJ5h9VFAUvF8THQ12_JDONFFA@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.