From: Daniel Vetter <daniel@ffwll.ch>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Daniel Vetter <daniel@ffwll.ch>,
Brian Starkey <brian.starkey@arm.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Sean Paul <seanpaul@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i2c: tda998x: don't register the connector
Date: Sun, 25 Sep 2016 22:34:25 +0200 [thread overview]
Message-ID: <20160925203425.GN20761@phenom.ffwll.local> (raw)
In-Reply-To: <20160923140503.GY1041@n2100.armlinux.org.uk>
On Fri, Sep 23, 2016 at 03:05:03PM +0100, Russell King - ARM Linux wrote:
> On Fri, Sep 23, 2016 at 03:13:15PM +0200, Daniel Vetter wrote:
> > Hm, maybe we should simply not call ->lastclose for kms drivers. That is
> > kinda only a hack for ums/dri1 drivers.
>
> Are you sure about that - isn't it needed so that the fbdev mode gets
> restored when the last DRM user exits, so that the VT consoles becomes
> functional again?
>
> I ended up needing a call to drm_fb_helper_restore_fbdev_mode_unlocked()
> in Armada's ->lastclose to ensure that VT consoles worked after Xorg was
> shutdown.
I meant not call it on driver unload. When closing the last drm fd we
indeed need it to restore the fbdev vt. That use-case definitely needs to
stay for kms drivers.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i2c: tda998x: don't register the connector
Date: Sun, 25 Sep 2016 22:34:25 +0200 [thread overview]
Message-ID: <20160925203425.GN20761@phenom.ffwll.local> (raw)
In-Reply-To: <20160923140503.GY1041@n2100.armlinux.org.uk>
On Fri, Sep 23, 2016 at 03:05:03PM +0100, Russell King - ARM Linux wrote:
> On Fri, Sep 23, 2016 at 03:13:15PM +0200, Daniel Vetter wrote:
> > Hm, maybe we should simply not call ->lastclose for kms drivers. That is
> > kinda only a hack for ums/dri1 drivers.
>
> Are you sure about that - isn't it needed so that the fbdev mode gets
> restored when the last DRM user exits, so that the VT consoles becomes
> functional again?
>
> I ended up needing a call to drm_fb_helper_restore_fbdev_mode_unlocked()
> in Armada's ->lastclose to ensure that VT consoles worked after Xorg was
> shutdown.
I meant not call it on driver unload. When closing the last drm fd we
indeed need it to restore the fbdev vt. That use-case definitely needs to
stay for kms drivers.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-09-25 20:34 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 10:55 [PATCH] drm/i2c: tda998x: don't register the connector Brian Starkey
2016-07-25 10:55 ` Brian Starkey
2016-07-25 12:25 ` Russell King - ARM Linux
2016-07-25 12:54 ` Brian Starkey
2016-07-25 12:54 ` Brian Starkey
2016-07-25 15:08 ` Daniel Vetter
2016-07-25 15:08 ` Daniel Vetter
2016-08-08 16:04 ` Brian Starkey
2016-08-08 16:04 ` Brian Starkey
2016-08-09 6:07 ` Daniel Vetter
2016-08-09 6:07 ` Daniel Vetter
2016-08-09 22:48 ` Russell King - ARM Linux
2016-09-21 8:57 ` Brian Starkey
2016-09-21 16:28 ` Russell King - ARM Linux
2016-09-22 10:39 ` Brian Starkey
2016-09-22 10:51 ` Russell King - ARM Linux
2016-09-22 11:22 ` Sean Paul
2016-09-22 11:28 ` Daniel Vetter
2016-09-22 13:38 ` Brian Starkey
2016-09-22 13:38 ` Brian Starkey
2016-09-22 14:24 ` Russell King - ARM Linux
2016-09-22 12:09 ` Russell King - ARM Linux
2016-09-22 12:32 ` Sean Paul
2016-09-22 12:40 ` Russell King - ARM Linux
2016-09-23 7:07 ` Daniel Vetter
2016-09-23 7:07 ` Daniel Vetter
2016-09-22 14:14 ` Brian Starkey
2016-09-22 14:14 ` Brian Starkey
2016-09-23 7:05 ` Daniel Vetter
2016-09-23 7:05 ` Daniel Vetter
2016-09-23 7:18 ` [PATCH] Revert "drm/i2c: tda998x: don't register the connector" Sean Paul
2016-09-23 9:32 ` liviu.dudau
2016-09-23 11:05 ` Sean Paul
2016-09-23 9:34 ` [PATCH] drm/i2c: tda998x: don't register the connector Liviu Dudau
2016-09-23 10:58 ` Daniel Vetter
2016-09-23 10:58 ` Daniel Vetter
2016-09-23 12:22 ` Lucas Stach
2016-09-23 12:52 ` Brian Starkey
2016-09-23 12:52 ` Brian Starkey
2016-09-23 13:13 ` Daniel Vetter
2016-09-23 13:13 ` Daniel Vetter
2016-09-23 14:05 ` Russell King - ARM Linux
2016-09-25 20:34 ` Daniel Vetter [this message]
2016-09-25 20:34 ` Daniel Vetter
2016-09-23 14:42 ` Brian Starkey
2016-09-23 14:42 ` Brian Starkey
2016-09-25 20:38 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160925203425.GN20761@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Liviu.Dudau@arm.com \
--cc=brian.starkey@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.