* [PATCH] cpufreq: kirkwood: add missing \n to end of dev_err messages
@ 2016-09-25 21:35 Colin King
2016-09-26 3:53 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-09-25 21:35 UTC (permalink / raw)
To: trivial, Rafael J . Wysocki, Viresh Kumar, linux-pm; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trival fix, dev_err messages are missing a \n, so add it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/cpufreq/kirkwood-cpufreq.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c
index be42f10..1b9bcd7 100644
--- a/drivers/cpufreq/kirkwood-cpufreq.c
+++ b/drivers/cpufreq/kirkwood-cpufreq.c
@@ -123,7 +123,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
priv.cpu_clk = of_clk_get_by_name(np, "cpu_clk");
if (IS_ERR(priv.cpu_clk)) {
- dev_err(priv.dev, "Unable to get cpuclk");
+ dev_err(priv.dev, "Unable to get cpuclk\n");
return PTR_ERR(priv.cpu_clk);
}
@@ -132,7 +132,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
priv.ddr_clk = of_clk_get_by_name(np, "ddrclk");
if (IS_ERR(priv.ddr_clk)) {
- dev_err(priv.dev, "Unable to get ddrclk");
+ dev_err(priv.dev, "Unable to get ddrclk\n");
err = PTR_ERR(priv.ddr_clk);
goto out_cpu;
}
@@ -142,7 +142,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
priv.powersave_clk = of_clk_get_by_name(np, "powersave");
if (IS_ERR(priv.powersave_clk)) {
- dev_err(priv.dev, "Unable to get powersave");
+ dev_err(priv.dev, "Unable to get powersave\n");
err = PTR_ERR(priv.powersave_clk);
goto out_ddr;
}
@@ -155,7 +155,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
if (!err)
return 0;
- dev_err(priv.dev, "Failed to register cpufreq driver");
+ dev_err(priv.dev, "Failed to register cpufreq driver\n");
clk_disable_unprepare(priv.powersave_clk);
out_ddr:
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cpufreq: kirkwood: add missing \n to end of dev_err messages
2016-09-25 21:35 [PATCH] cpufreq: kirkwood: add missing \n to end of dev_err messages Colin King
@ 2016-09-26 3:53 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2016-09-26 3:53 UTC (permalink / raw)
To: Colin King; +Cc: trivial, Rafael J . Wysocki, linux-pm, linux-kernel
On 25-09-16, 14:35, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, dev_err messages are missing a \n, so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/cpufreq/kirkwood-cpufreq.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c
> index be42f10..1b9bcd7 100644
> --- a/drivers/cpufreq/kirkwood-cpufreq.c
> +++ b/drivers/cpufreq/kirkwood-cpufreq.c
> @@ -123,7 +123,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>
> priv.cpu_clk = of_clk_get_by_name(np, "cpu_clk");
> if (IS_ERR(priv.cpu_clk)) {
> - dev_err(priv.dev, "Unable to get cpuclk");
> + dev_err(priv.dev, "Unable to get cpuclk\n");
> return PTR_ERR(priv.cpu_clk);
> }
>
> @@ -132,7 +132,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>
> priv.ddr_clk = of_clk_get_by_name(np, "ddrclk");
> if (IS_ERR(priv.ddr_clk)) {
> - dev_err(priv.dev, "Unable to get ddrclk");
> + dev_err(priv.dev, "Unable to get ddrclk\n");
> err = PTR_ERR(priv.ddr_clk);
> goto out_cpu;
> }
> @@ -142,7 +142,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>
> priv.powersave_clk = of_clk_get_by_name(np, "powersave");
> if (IS_ERR(priv.powersave_clk)) {
> - dev_err(priv.dev, "Unable to get powersave");
> + dev_err(priv.dev, "Unable to get powersave\n");
> err = PTR_ERR(priv.powersave_clk);
> goto out_ddr;
> }
> @@ -155,7 +155,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
> if (!err)
> return 0;
>
> - dev_err(priv.dev, "Failed to register cpufreq driver");
> + dev_err(priv.dev, "Failed to register cpufreq driver\n");
>
> clk_disable_unprepare(priv.powersave_clk);
> out_ddr:
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-26 3:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-25 21:35 [PATCH] cpufreq: kirkwood: add missing \n to end of dev_err messages Colin King
2016-09-26 3:53 ` Viresh Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.