From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jan Stancek <jstancek@redhat.com>
Cc: rui.y.wang@intel.com, mhcerri@linux.vnet.ibm.com,
leosilva@linux.vnet.ibm.com, pfsmorigo@linux.vnet.ibm.com,
linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7
Date: Mon, 26 Sep 2016 22:59:34 +0800 [thread overview]
Message-ID: <20160926145934.GA5520@gondor.apana.org.au> (raw)
In-Reply-To: <1655600242.1561022.1474676547316.JavaMail.zimbra@redhat.com>
On Fri, Sep 23, 2016 at 08:22:27PM -0400, Jan Stancek wrote:
>
> This seems to directly correspond with:
> p8_ghash_alg.descsize = sizeof(struct p8_ghash_desc_ctx) == 56
> shash_tfm->descsize = sizeof(struct p8_ghash_desc_ctx) + crypto_shash_descsize(fallback) == 56 + 20
> where 20 is presumably coming from "ghash_alg.descsize".
>
> My gut feeling was that these 2 should match, but I'd love to hear
> what crypto people think.
Indeed. The vmx driver is broken. It is allocating a fallback
but is not providing any space for the state of the fallback.
Unfortunately our interface doesn't really provide a way to provide
the state size dynamically. So what I'd suggest is to fix the
fallback to the generic ghash implementation and export its state
size like we do for md5/sha.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-09-26 14:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <450861381.1559123.1474673197124.JavaMail.zimbra@redhat.com>
2016-09-24 0:22 ` [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7 Jan Stancek
2016-09-26 14:15 ` Marcelo Cerri
2016-09-26 17:50 ` Jan Stancek
2016-09-26 14:59 ` Herbert Xu [this message]
2016-09-26 17:43 ` Marcelo Cerri
2016-09-27 3:08 ` Herbert Xu
2016-09-27 9:01 ` Jan Stancek
2016-09-27 12:04 ` Marcelo Cerri
2016-09-27 19:46 ` Marcelo Cerri
2016-09-28 2:45 ` Herbert Xu
2016-09-28 7:40 ` Jan Stancek
2016-09-28 12:29 ` Herbert Xu
2016-09-28 12:38 ` Marcelo Cerri
2016-09-28 12:44 ` Herbert Xu
2016-09-28 12:55 ` Marcelo Cerri
2016-09-28 13:09 ` Herbert Xu
2016-09-28 12:28 ` Marcelo Cerri
2016-09-28 12:33 ` Herbert Xu
2016-09-28 13:22 ` Paulo Flabiano Smorigo
2016-09-28 8:59 ` Jan Stancek
2016-09-28 2:44 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926145934.GA5520@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=jstancek@redhat.com \
--cc=leosilva@linux.vnet.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhcerri@linux.vnet.ibm.com \
--cc=pfsmorigo@linux.vnet.ibm.com \
--cc=rui.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.