From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jan Stancek <jstancek@redhat.com>
Cc: Marcelo Cerri <marcelo.cerri@canonical.com>,
rui y wang <rui.y.wang@intel.com>,
mhcerri@linux.vnet.ibm.com, leosilva@linux.vnet.ibm.com,
pfsmorigo@linux.vnet.ibm.com, linux-crypto@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7
Date: Wed, 28 Sep 2016 20:29:35 +0800 [thread overview]
Message-ID: <20160928122935.GA20839@gondor.apana.org.au> (raw)
In-Reply-To: <1597189480.51836.1475048451846.JavaMail.zimbra@redhat.com>
On Wed, Sep 28, 2016 at 03:40:51AM -0400, Jan Stancek wrote:
>
> Thanks for clearing up how this works in padlock-sha, but
> we are not exactly in same situation with p8_ghash.
>
> p8_ghash_init_tfm() already updates descsize. Problem in original report
> is that without custom export/import/statesize p8_ghash_alg.statesize
> gets initialized by shash_prepare_alg() to alg->descsize:
Right.
> so I think we need either:
> 1) make sure p8_ghash_alg.descsize is correct before we register shash,
> this is what Marcelo's last patch is doing
This approach doesn't work because there is no guarantee that
you'll get the same fallback the next time you allocate a tfm.
So relying on the descsize being constant can only work if all
implementations of the fallback use the same desc struct.
> 2) provide custom export/import/statesize for p8_ghash_alg
This works for padlock-sha because every implementation of SHA
uses the same state data structure from sha.h. If we can make
all implementations of ghash agree on the exported state then
we can use the same approach.
Otherwise we can go back to allocating just ghash-generic and
also move its data structure into an exported header file.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2016-09-28 12:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <450861381.1559123.1474673197124.JavaMail.zimbra@redhat.com>
2016-09-24 0:22 ` [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7 Jan Stancek
2016-09-26 14:15 ` Marcelo Cerri
2016-09-26 17:50 ` Jan Stancek
2016-09-26 14:59 ` Herbert Xu
2016-09-26 17:43 ` Marcelo Cerri
2016-09-27 3:08 ` Herbert Xu
2016-09-27 9:01 ` Jan Stancek
2016-09-27 12:04 ` Marcelo Cerri
2016-09-27 19:46 ` Marcelo Cerri
2016-09-28 2:45 ` Herbert Xu
2016-09-28 7:40 ` Jan Stancek
2016-09-28 12:29 ` Herbert Xu [this message]
2016-09-28 12:38 ` Marcelo Cerri
2016-09-28 12:44 ` Herbert Xu
2016-09-28 12:55 ` Marcelo Cerri
2016-09-28 13:09 ` Herbert Xu
2016-09-28 12:28 ` Marcelo Cerri
2016-09-28 12:33 ` Herbert Xu
2016-09-28 13:22 ` Paulo Flabiano Smorigo
2016-09-28 8:59 ` Jan Stancek
2016-09-28 2:44 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928122935.GA20839@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=jstancek@redhat.com \
--cc=leosilva@linux.vnet.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=marcelo.cerri@canonical.com \
--cc=mhcerri@linux.vnet.ibm.com \
--cc=pfsmorigo@linux.vnet.ibm.com \
--cc=rui.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.