* [PATCH] padata: remove recently added module usage from bool code
@ 2016-09-27 1:18 Paul Gortmaker
2016-09-27 9:03 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2016-09-27 1:18 UTC (permalink / raw)
To: linux-kernel
Cc: Paul Gortmaker, Steffen Klassert, Thomas Gleixner,
Sebastian Andrzej Siewior, linux-crypto
In commit 30e92153b4e6 ("padata: Convert to hotplug state machine")
this file started using module.h and got module_init and module_exit
added to it.
However the Kconfig for it is:
init/Kconfig:config PADATA
init/Kconfig: depends on SMP
init/Kconfig: bool
...and so it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
kernel/padata.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/kernel/padata.c b/kernel/padata.c
index 7848f0566403..355807e52b1e 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -30,7 +30,7 @@
#include <linux/slab.h>
#include <linux/sysfs.h>
#include <linux/rcupdate.h>
-#include <linux/module.h>
+#include <linux/init.h>
#define MAX_OBJ_NUM 1000
@@ -1043,11 +1043,6 @@ static __init int padata_driver_init(void)
hp_online = ret;
return 0;
}
-module_init(padata_driver_init);
+device_initcall(padata_driver_init);
-static __exit void padata_driver_exit(void)
-{
- cpuhp_remove_multi_state(hp_online);
-}
-module_exit(padata_driver_exit);
#endif
--
2.10.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] padata: remove recently added module usage from bool code
2016-09-27 1:18 [PATCH] padata: remove recently added module usage from bool code Paul Gortmaker
@ 2016-09-27 9:03 ` Sebastian Andrzej Siewior
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2016-09-27 9:03 UTC (permalink / raw)
To: Paul Gortmaker
Cc: linux-kernel, Steffen Klassert, Thomas Gleixner, linux-crypto
On 2016-09-26 21:18:21 [-0400], Paul Gortmaker wrote:
>
> ...and so it currently is not being built as a module by anyone.
that is correct.
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Sebastian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-27 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-27 1:18 [PATCH] padata: remove recently added module usage from bool code Paul Gortmaker
2016-09-27 9:03 ` Sebastian Andrzej Siewior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.