* [patch] KVM: PPC: fix a sanity check
@ 2016-07-14 10:15 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2016-07-14 10:15 UTC (permalink / raw)
To: Alexander Graf, Bharat Bhushan
Cc: Paolo Bonzini, Radim Krčmář,
Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
kvm-ppc, kvm, linuxppc-dev, kernel-janitors
We use logical negate where bitwise negate was intended. It means that
we never return -EINVAL here.
Fixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index 02b4672..df3f270 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -2038,7 +2038,7 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
if (type == KVMPPC_DEBUG_NONE)
continue;
- if (type & !(KVMPPC_DEBUG_WATCH_READ |
+ if (type & ~(KVMPPC_DEBUG_WATCH_READ |
KVMPPC_DEBUG_WATCH_WRITE |
KVMPPC_DEBUG_BREAKPOINT))
return -EINVAL;
^ permalink raw reply related [flat|nested] 7+ messages in thread* [patch] KVM: PPC: fix a sanity check
@ 2016-07-14 10:15 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2016-07-14 10:15 UTC (permalink / raw)
To: Alexander Graf, Bharat Bhushan
Cc: kvm, Radim Krčmář,
kernel-janitors, kvm-ppc, Paul Mackerras, Paolo Bonzini,
linuxppc-dev
We use logical negate where bitwise negate was intended. It means that
we never return -EINVAL here.
Fixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index 02b4672..df3f270 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -2038,7 +2038,7 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
if (type == KVMPPC_DEBUG_NONE)
continue;
- if (type & !(KVMPPC_DEBUG_WATCH_READ |
+ if (type & ~(KVMPPC_DEBUG_WATCH_READ |
KVMPPC_DEBUG_WATCH_WRITE |
KVMPPC_DEBUG_BREAKPOINT))
return -EINVAL;
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [patch] KVM: PPC: fix a sanity check
2016-07-14 10:15 ` Dan Carpenter
@ 2016-07-14 11:10 ` Alexander Graf
-1 siblings, 0 replies; 7+ messages in thread
From: Alexander Graf @ 2016-07-14 11:10 UTC (permalink / raw)
To: Dan Carpenter, Bharat Bhushan
Cc: Michael Ellerman, Benjamin Herrenschmidt, linuxppc-dev,
Paolo Bonzini, rkrcmar, Paul Mackerras, kernel-janitors, kvm,
kvm-ppc
On 07/14/2016 12:15 PM, Dan Carpenter wrote:
> We use logical negate where bitwise negate was intended. It means that
> we never return -EINVAL here.
>
> Fixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Oops :).
Reviewed-by: Alexander Graf <agraf@suse.de>
Alex
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [patch] KVM: PPC: fix a sanity check
@ 2016-07-14 11:10 ` Alexander Graf
0 siblings, 0 replies; 7+ messages in thread
From: Alexander Graf @ 2016-07-14 11:10 UTC (permalink / raw)
To: Dan Carpenter, Bharat Bhushan
Cc: Michael Ellerman, Benjamin Herrenschmidt, linuxppc-dev,
Paolo Bonzini, rkrcmar, Paul Mackerras, kernel-janitors, kvm,
kvm-ppc
On 07/14/2016 12:15 PM, Dan Carpenter wrote:
> We use logical negate where bitwise negate was intended. It means that
> we never return -EINVAL here.
>
> Fixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Oops :).
Reviewed-by: Alexander Graf <agraf@suse.de>
Alex
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [patch] KVM: PPC: fix a sanity check
2016-07-14 10:15 ` Dan Carpenter
@ 2016-09-27 5:46 ` Paul Mackerras
-1 siblings, 0 replies; 7+ messages in thread
From: Paul Mackerras @ 2016-09-27 5:46 UTC (permalink / raw)
To: Dan Carpenter
Cc: Alexander Graf, Bharat Bhushan, Paolo Bonzini,
Radim Krčmář,
Benjamin Herrenschmidt, Michael Ellerman, kvm-ppc, kvm,
linuxppc-dev, kernel-janitors
On Thu, Jul 14, 2016 at 01:15:46PM +0300, Dan Carpenter wrote:
> We use logical negate where bitwise negate was intended. It means that
> we never return -EINVAL here.
>
> Fixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to kvm-ppc-next.
Paul.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [patch] KVM: PPC: fix a sanity check
@ 2016-09-27 5:46 ` Paul Mackerras
0 siblings, 0 replies; 7+ messages in thread
From: Paul Mackerras @ 2016-09-27 5:46 UTC (permalink / raw)
To: Dan Carpenter
Cc: Alexander Graf, Bharat Bhushan, Paolo Bonzini,
Radim Krčmář,
Benjamin Herrenschmidt, Michael Ellerman, kvm-ppc, kvm,
linuxppc-dev, kernel-janitors
On Thu, Jul 14, 2016 at 01:15:46PM +0300, Dan Carpenter wrote:
> We use logical negate where bitwise negate was intended. It means that
> we never return -EINVAL here.
>
> Fixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to kvm-ppc-next.
Paul.
^ permalink raw reply [flat|nested] 7+ messages in thread