* [PATCH v3] Staging: ks7010 : Fix block comments warning
@ 2016-09-27 20:10 Muraru Mihaela
2016-09-28 9:33 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Muraru Mihaela @ 2016-09-27 20:10 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Move final */ to a new line, to conform to
the kernel coding style for block comments.
Issue found by checkpatch.
Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com>
---
Chnages in v3:
- adding a * to respect the coding style rule for multi-line
comments
---
drivers/staging/ks7010/eap_packet.h | 24 ++++++++++++++++--------
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h
index 16a392a..6399da4 100644
--- a/drivers/staging/ks7010/eap_packet.h
+++ b/drivers/staging/ks7010/eap_packet.h
@@ -51,24 +51,32 @@ enum { EAPOL_KEY_TYPE_RC4 = 1, EAPOL_KEY_TYPE_RSN = 2,
struct ieee802_1x_eapol_key {
unsigned char type;
unsigned short key_length;
- /* does not repeat within the life of the keying material used to
- * encrypt the Key field; 64-bit NTP timestamp MAY be used here */
+ /*
+ * does not repeat within the life of the keying material used to
+ * encrypt the Key field; 64-bit NTP timestamp MAY be used here
+ */
unsigned char replay_counter[IEEE8021X_REPLAY_COUNTER_LEN];
unsigned char key_iv[IEEE8021X_KEY_IV_LEN]; /* cryptographically random number */
- unsigned char key_index; /* key flag in the most significant bit:
+ unsigned char key_index; /*
+ * key flag in the most significant bit:
* 0 = broadcast (default key),
* 1 = unicast (key mapping key); key index is in the
- * 7 least significant bits */
- /* HMAC-MD5 message integrity check computed with MS-MPPE-Send-Key as
- * the key */
+ * 7 least significant bits
+ */
+ /*
+ * HMAC-MD5 message integrity check computed with MS-MPPE-Send-Key as
+ * the key
+ */
unsigned char key_signature[IEEE8021X_KEY_SIGN_LEN];
- /* followed by key: if packet body length = 44 + key length, then the
+ /*
+ * followed by key: if packet body length = 44 + key length, then the
* key field (of key_length bytes) contains the key in encrypted form;
* if packet body length = 44, key field is absent and key_length
* represents the number of least significant octets from
* MS-MPPE-Send-Key attribute to be used as the keying material;
- * RC4 key used in encryption = Key-IV + MS-MPPE-Recv-Key */
+ * RC4 key used in encryption = Key-IV + MS-MPPE-Recv-Key
+ */
} __attribute__ ((packed));
#define WPA_NONCE_LEN 32
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] Staging: ks7010 : Fix block comments warning
2016-09-27 20:10 [PATCH v3] Staging: ks7010 : Fix block comments warning Muraru Mihaela
@ 2016-09-28 9:33 ` Greg KH
2016-09-28 12:55 ` Muraru Mihaela
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2016-09-28 9:33 UTC (permalink / raw)
To: Muraru Mihaela; +Cc: outreachy-kernel
On Tue, Sep 27, 2016 at 11:10:31PM +0300, Muraru Mihaela wrote:
> Move final */ to a new line, to conform to
> the kernel coding style for block comments.
>
> Issue found by checkpatch.
>
> Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com>
> ---
> Chnages in v3:
> - adding a * to respect the coding style rule for multi-line
> comments
> ---
> drivers/staging/ks7010/eap_packet.h | 24 ++++++++++++++++--------
> 1 file changed, 16 insertions(+), 8 deletions(-)
This doesn't apply to my tree at all. Can you update your local tree
and rebase it and resend?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] Staging: ks7010 : Fix block comments warning
2016-09-28 9:33 ` Greg KH
@ 2016-09-28 12:55 ` Muraru Mihaela
0 siblings, 0 replies; 3+ messages in thread
From: Muraru Mihaela @ 2016-09-28 12:55 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
On Wed, Sep 28, 2016 at 11:33:47AM +0200, Greg KH wrote:
> On Tue, Sep 27, 2016 at 11:10:31PM +0300, Muraru Mihaela wrote:
> > Move final */ to a new line, to conform to
> > the kernel coding style for block comments.
> >
> > Issue found by checkpatch.
> >
> > Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com>
> > ---
> > Chnages in v3:
> > - adding a * to respect the coding style rule for multi-line
> > comments
> > ---
> > drivers/staging/ks7010/eap_packet.h | 24 ++++++++++++++++--------
> > 1 file changed, 16 insertions(+), 8 deletions(-)
>
> This doesn't apply to my tree at all. Can you update your local tree
> and rebase it and resend?
>
> thanks,
>
> greg k-h
Thank you for telling me I will send patch v4.
mihaela
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-28 12:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-27 20:10 [PATCH v3] Staging: ks7010 : Fix block comments warning Muraru Mihaela
2016-09-28 9:33 ` Greg KH
2016-09-28 12:55 ` Muraru Mihaela
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.