* tracing: add #undef to fix compile error
@ 2016-09-29 2:55 Rik van Riel
2017-03-02 3:11 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Rik van Riel @ 2016-09-29 2:55 UTC (permalink / raw)
To: rostedt; +Cc: mingo, linux-kernel
There are several trace include files that define TRACE_INCLUDE_FILE.
Include several of them in the same .c file (as I currently have in
some code I am working on), and the compile will blow up with a
"warning: "TRACE_INCLUDE_FILE" redefined #define TRACE_INCLUDE_FILE syscalls"
Every other include file in include/trace/events/ avoids that issue
by having a #undef TRACE_INCLUDE_FILE before the #define; syscalls.h
should have one, too.
Signed-off-by: Rik van Riel <riel@redhat.com>
---
include/trace/events/syscalls.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/trace/events/syscalls.h b/include/trace/events/syscalls.h
index 14e49c798135..b35533b94277 100644
--- a/include/trace/events/syscalls.h
+++ b/include/trace/events/syscalls.h
@@ -1,5 +1,6 @@
#undef TRACE_SYSTEM
#define TRACE_SYSTEM raw_syscalls
+#undef TRACE_INCLUDE_FILE
#define TRACE_INCLUDE_FILE syscalls
#if !defined(_TRACE_EVENTS_SYSCALLS_H) || defined(TRACE_HEADER_MULTI_READ)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: tracing: add #undef to fix compile error
2016-09-29 2:55 tracing: add #undef to fix compile error Rik van Riel
@ 2017-03-02 3:11 ` Steven Rostedt
2017-03-02 14:43 ` Rik van Riel
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2017-03-02 3:11 UTC (permalink / raw)
To: Rik van Riel; +Cc: mingo, linux-kernel
On Wed, 28 Sep 2016 22:55:54 -0400
Rik van Riel <riel@redhat.com> wrote:
> There are several trace include files that define TRACE_INCLUDE_FILE.
>
> Include several of them in the same .c file (as I currently have in
> some code I am working on), and the compile will blow up with a
> "warning: "TRACE_INCLUDE_FILE" redefined #define TRACE_INCLUDE_FILE syscalls"
>
> Every other include file in include/trace/events/ avoids that issue
> by having a #undef TRACE_INCLUDE_FILE before the #define; syscalls.h
> should have one, too.
Cleaning out my INBOX, I stumbled over this patch. It looks like I
missed it. I'm guessing this is still an issue? (Too lazy to actually
look deeper, well just too tired at the moment).
-- Steve
>
> Signed-off-by: Rik van Riel <riel@redhat.com>
> ---
> include/trace/events/syscalls.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/trace/events/syscalls.h b/include/trace/events/syscalls.h
> index 14e49c798135..b35533b94277 100644
> --- a/include/trace/events/syscalls.h
> +++ b/include/trace/events/syscalls.h
> @@ -1,5 +1,6 @@
> #undef TRACE_SYSTEM
> #define TRACE_SYSTEM raw_syscalls
> +#undef TRACE_INCLUDE_FILE
> #define TRACE_INCLUDE_FILE syscalls
>
> #if !defined(_TRACE_EVENTS_SYSCALLS_H) || defined(TRACE_HEADER_MULTI_READ)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: tracing: add #undef to fix compile error
2017-03-02 3:11 ` Steven Rostedt
@ 2017-03-02 14:43 ` Rik van Riel
0 siblings, 0 replies; 3+ messages in thread
From: Rik van Riel @ 2017-03-02 14:43 UTC (permalink / raw)
To: Steven Rostedt; +Cc: mingo, linux-kernel
On Wed, 2017-03-01 at 22:11 -0500, Steven Rostedt wrote:
> On Wed, 28 Sep 2016 22:55:54 -0400
> Rik van Riel <riel@redhat.com> wrote:
>
> > There are several trace include files that define
> > TRACE_INCLUDE_FILE.
> >
> > Include several of them in the same .c file (as I currently have in
> > some code I am working on), and the compile will blow up with a
> > "warning: "TRACE_INCLUDE_FILE" redefined #define TRACE_INCLUDE_FILE
> > syscalls"
> >
> > Every other include file in include/trace/events/ avoids that issue
> > by having a #undef TRACE_INCLUDE_FILE before the #define;
> > syscalls.h
> > should have one, too.
>
> Cleaning out my INBOX, I stumbled over this patch. It looks like I
> missed it. I'm guessing this is still an issue? (Too lazy to actually
> look deeper, well just too tired at the moment).
I believe it is :)
> > Signed-off-by: Rik van Riel <riel@redhat.com>
> > ---
> > include/trace/events/syscalls.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/trace/events/syscalls.h
> > b/include/trace/events/syscalls.h
> > index 14e49c798135..b35533b94277 100644
> > --- a/include/trace/events/syscalls.h
> > +++ b/include/trace/events/syscalls.h
> > @@ -1,5 +1,6 @@
> > #undef TRACE_SYSTEM
> > #define TRACE_SYSTEM raw_syscalls
> > +#undef TRACE_INCLUDE_FILE
> > #define TRACE_INCLUDE_FILE syscalls
> >
> > #if !defined(_TRACE_EVENTS_SYSCALLS_H) ||
> > defined(TRACE_HEADER_MULTI_READ)
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-02 14:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-29 2:55 tracing: add #undef to fix compile error Rik van Riel
2017-03-02 3:11 ` Steven Rostedt
2017-03-02 14:43 ` Rik van Riel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.