All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Kiper <daniel.kiper@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Juergen Gross <JGross@suse.com>,
	sstabellini@kernel.org, andrew.cooper3@citrix.com,
	cardoe@cardoe.com, pgnet.dev@gmail.com, ning.sun@intel.com,
	julien.grall@arm.com, david.vrabel@citrix.com,
	xen-devel@lists.xenproject.org, qiaowei.ren@intel.com,
	gang.wei@intel.com, fu.wei@linaro.org
Subject: Re: [PATCH v8 04/13] x86: properly calculate xen ELF end of image address
Date: Thu, 29 Sep 2016 10:17:43 +0200	[thread overview]
Message-ID: <20160929081743.GU28753@olila.local.net-space.pl> (raw)
In-Reply-To: <57ECE68A0200007800113A07@prv-mh.provo.novell.com>

On Thu, Sep 29, 2016 at 02:01:46AM -0600, Jan Beulich wrote:
> >>> On 29.09.16 at 09:51, <daniel.kiper@oracle.com> wrote:
> > On Thu, Sep 29, 2016 at 01:34:30AM -0600, Jan Beulich wrote:
> >> >>> On 29.09.16 at 00:51, <daniel.kiper@oracle.com> wrote:
> >> > --- a/xen/arch/x86/Makefile
> >> > +++ b/xen/arch/x86/Makefile
> >> > @@ -91,7 +91,7 @@ endif
> >> >
> >> >  $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32
> >> >  	./boot/mkelf32 $(notes_phdrs) $(TARGET)-syms $(TARGET) 0x100000 \
> >> > -	`$(NM) -nr $(TARGET)-syms | head -n 1 | sed -e 's/^\([^ ]*\).*/0x\1/'`
> >> > +	        `$(NM) $(TARGET)-syms | sed -ne 's/^\([^ ]*\) . _end$$/0x\1/p'`
> >>
> >> I thought we had agreed to use __2M_rwdata_end here.
> >
> > Oh, I forgot about that.
> >
> >> And also note that I had said "such that the command line argument
> >> here aligns with the first one on the previous line" in my reply to v7
> >> regarding the indentation change.
> >
> > $(TARGET)-syms starts in the same column as $(notes_phdrs) does in the
> > final output as you requested. However, here it looks that it is
> > misaligned due to tab at the begging of the line.
>
> I specifically looked at this in an editor using a fixed width font,
> and I just took a look another time: I cannot confirm what you
> say - the first back quote sits under the k of mkelf32. Or wait -
> what you say is true, but is not what I had asked for. The whole
> back-quoted string is an argument to mkelf32.

Ahhh... It looks that I misunderstood you. You wish to have first
back-quote under "$" sign which is the beginning of "$(notes_phdrs)".
Am I right?

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-09-29  8:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 22:51 [PATCH v8 00/13] x86: multiboot2 protocol support Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 01/13] x86: add " Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 02/13] efi: create efi_enabled() Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 03/13] x86: allow EFI reboot method neither on EFI platforms Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 04/13] x86: properly calculate xen ELF end of image address Daniel Kiper
2016-09-29  7:34   ` Jan Beulich
2016-09-29  7:51     ` Daniel Kiper
2016-09-29  8:01       ` Jan Beulich
2016-09-29  8:17         ` Daniel Kiper [this message]
2016-09-29  8:34           ` Jan Beulich
2016-09-28 22:51 ` [PATCH v8 05/13] efi: build xen.gz with EFI code Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 06/13] efi: create new early memory allocator Daniel Kiper
2016-09-29  7:40   ` Jan Beulich
2016-09-29  8:08     ` Daniel Kiper
2016-09-29 12:47       ` Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 07/13] x86: add multiboot2 protocol support for EFI platforms Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 08/13] x86/boot: implement early command line parser in C Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 09/13] x86: change default load address from 1 MiB to 2 MiB Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 10/13] x86/setup: use XEN_IMG_OFFSET instead of Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 11/13] x86: make Xen early boot code relocatable Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 12/13] x86/boot: rename sym_phys() to sym_offs() Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 13/13] x86: add multiboot2 protocol support for relocatable images Daniel Kiper
2016-09-29  7:46   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160929081743.GU28753@olila.local.net-space.pl \
    --to=daniel.kiper@oracle.com \
    --cc=JBeulich@suse.com \
    --cc=JGross@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=david.vrabel@citrix.com \
    --cc=fu.wei@linaro.org \
    --cc=gang.wei@intel.com \
    --cc=julien.grall@arm.com \
    --cc=ning.sun@intel.com \
    --cc=pgnet.dev@gmail.com \
    --cc=qiaowei.ren@intel.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.