All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: Juergen Gross <JGross@suse.com>,
	sstabellini@kernel.org, andrew.cooper3@citrix.com,
	cardoe@cardoe.com, pgnet.dev@gmail.com, ning.sun@intel.com,
	julien.grall@arm.com, david.vrabel@citrix.com,
	xen-devel@lists.xenproject.org, qiaowei.ren@intel.com,
	gang.wei@intel.com, fu.wei@linaro.org
Subject: Re: [PATCH v8 13/13] x86: add multiboot2 protocol support for relocatable images
Date: Thu, 29 Sep 2016 01:46:28 -0600	[thread overview]
Message-ID: <57ECE2F402000078001139D5@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1475103092-27893-14-git-send-email-daniel.kiper@oracle.com>

>>> On 29.09.16 at 00:51, <daniel.kiper@oracle.com> wrote:
> @@ -384,6 +391,15 @@ __start:
>          cmp     %edi,MB2_fixed_total_size(%ebx)
>          jbe     trampoline_bios_setup
>  
> +        /* Get Xen image load base address from Multiboot2 information. */
> +        cmpl    $MULTIBOOT2_TAG_TYPE_LOAD_BASE_ADDR,MB2_tag_type(%ecx)
> +        jne     1f
> +
> +        mov     MB2_load_base_addr(%ecx),%esi
> +        sub     $XEN_IMG_OFFSET,%esi
> +        jmp     9f
> +
> +1:
>          /* Get mem_lower from Multiboot2 information. */
>          cmpl    $MULTIBOOT2_TAG_TYPE_BASIC_MEMINFO,MB2_tag_type(%ecx)
>          cmove   MB2_mem_lower(%ecx),%edx

This demonstrates the downsides of using numeric labels for other
than branching across a few instructions: Without digging out where
(and which) other patch places that label, it is impossible to judge
whether this is correct now. If the label had been a suitably named
.L one, this would be much less of a problem (and much easier to
look for in the other patches).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      reply	other threads:[~2016-09-29  7:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 22:51 [PATCH v8 00/13] x86: multiboot2 protocol support Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 01/13] x86: add " Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 02/13] efi: create efi_enabled() Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 03/13] x86: allow EFI reboot method neither on EFI platforms Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 04/13] x86: properly calculate xen ELF end of image address Daniel Kiper
2016-09-29  7:34   ` Jan Beulich
2016-09-29  7:51     ` Daniel Kiper
2016-09-29  8:01       ` Jan Beulich
2016-09-29  8:17         ` Daniel Kiper
2016-09-29  8:34           ` Jan Beulich
2016-09-28 22:51 ` [PATCH v8 05/13] efi: build xen.gz with EFI code Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 06/13] efi: create new early memory allocator Daniel Kiper
2016-09-29  7:40   ` Jan Beulich
2016-09-29  8:08     ` Daniel Kiper
2016-09-29 12:47       ` Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 07/13] x86: add multiboot2 protocol support for EFI platforms Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 08/13] x86/boot: implement early command line parser in C Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 09/13] x86: change default load address from 1 MiB to 2 MiB Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 10/13] x86/setup: use XEN_IMG_OFFSET instead of Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 11/13] x86: make Xen early boot code relocatable Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 12/13] x86/boot: rename sym_phys() to sym_offs() Daniel Kiper
2016-09-28 22:51 ` [PATCH v8 13/13] x86: add multiboot2 protocol support for relocatable images Daniel Kiper
2016-09-29  7:46   ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57ECE2F402000078001139D5@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=JGross@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=daniel.kiper@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=fu.wei@linaro.org \
    --cc=gang.wei@intel.com \
    --cc=julien.grall@arm.com \
    --cc=ning.sun@intel.com \
    --cc=pgnet.dev@gmail.com \
    --cc=qiaowei.ren@intel.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.