[PATCH v2 1/2] staging: iio: cdc: ad7152: Add blank line after declarations to increase readability

[PATCH v2 1/2] staging: iio: cdc: ad7152: Add blank line after declarations to increase readability

[Anchal Jain]

Add a blank line after a function declaration because local variable 
declarations should be seprated from the function's statments by a blank line
to increase the readability of a code.  

Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
 drivers/staging/iio/cdc/ad7152.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
index 1962052..f9767e9 100644
--- a/drivers/staging/iio/cdc/ad7152.c
+++ b/drivers/staging/iio/cdc/ad7152.c
@@ -134,6 +134,7 @@ static inline ssize_t ad7152_start_calib(struct device *dev,
 	mutex_unlock(&indio_dev->mlock);
 	return len;
 }
+
 static ssize_t ad7152_start_offset_calib(struct device *dev,
 					 struct device_attribute *attr,
 					 const char *buf,
@@ -142,6 +143,7 @@ static ssize_t ad7152_start_offset_calib(struct device *dev,
 	return ad7152_start_calib(dev, attr, buf, len,
 				  AD7152_CONF_MODE_OFFS_CAL);
 }
+
 static ssize_t ad7152_start_gain_calib(struct device *dev,
 				       struct device_attribute *attr,
 				       const char *buf,
@@ -317,6 +319,7 @@ out:
 	mutex_unlock(&indio_dev->mlock);
 	return ret;
 }
+
 static int ad7152_read_raw(struct iio_dev *indio_dev,
 			   struct iio_chan_spec const *chan,
 			   int *val, int *val2,
@@ -470,6 +473,7 @@ static const struct iio_chan_spec ad7152_channels[] = {
 		BIT(IIO_CHAN_INFO_SCALE),
 	}
 };
+
 /*
  * device probe and remove
  */
-- 
1.9.1

Re: [PATCH v2 1/2] staging: iio: cdc: ad7152: Add blank line after declarations to increase readability

[Greg KH]

On Thu, Sep 29, 2016 at 08:31:19PM +0530, Anchal Jain wrote:
> Add a blank line after a function declaration because local variable 
> declarations should be seprated from the function's statments by a blank line
> to increase the readability of a code.  
> 
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
>  drivers/staging/iio/cdc/ad7152.c | 4 ++++
>  1 file changed, 4 insertions(+)

Why do you have trailing whitespace in your changelog comment?

Also, you forgot to cc: the IIO maintainers :(