All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <thierry.reding@gmail.com>, <jingoohan1@gmail.com>,
	<lee.jones@linaro.org>
Cc: <tomi.valkeinen@ti.com>, <linux-pwm@vger.kernel.org>,
	<linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<p.zabel@pengutronix.de>
Subject: [PATCH 2/2] backlight: pwm_bl: Check the pwm state for initial backlight power state
Date: Fri, 30 Sep 2016 10:02:59 +0300	[thread overview]
Message-ID: <20160930070259.5710-3-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20160930070259.5710-1-peter.ujfalusi@ti.com>

If the pwm is not enabled the backlight initially should not be enabled
either if we have booted with DT and there is a phandle pointing to the
backlight node.

The patch extends the checks to decide if we should keep the backlight off
initially.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/video/backlight/pwm_bl.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 9bc4715bf116..e4326bbf807f 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -223,6 +223,10 @@ static int pwm_backlight_initial_power_state(const struct pwm_bl_data *pb)
 	if (!regulator_is_enabled(pb->power_supply))
 		return FB_BLANK_POWERDOWN;
 
+	/* The pwm is disabled, keep it like this */
+	if (!pwm_is_enabled(pb->pwm))
+		return FB_BLANK_POWERDOWN;
+
 	return FB_BLANK_UNBLANK;
 }
 
-- 
2.10.0

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: thierry.reding@gmail.com, jingoohan1@gmail.com, lee.jones@linaro.org
Cc: tomi.valkeinen@ti.com, linux-pwm@vger.kernel.org,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	p.zabel@pengutronix.de
Subject: [PATCH 2/2] backlight: pwm_bl: Check the pwm state for initial backlight power state
Date: Fri, 30 Sep 2016 10:02:59 +0300	[thread overview]
Message-ID: <20160930070259.5710-3-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20160930070259.5710-1-peter.ujfalusi@ti.com>

If the pwm is not enabled the backlight initially should not be enabled
either if we have booted with DT and there is a phandle pointing to the
backlight node.

The patch extends the checks to decide if we should keep the backlight off
initially.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/video/backlight/pwm_bl.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 9bc4715bf116..e4326bbf807f 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -223,6 +223,10 @@ static int pwm_backlight_initial_power_state(const struct pwm_bl_data *pb)
 	if (!regulator_is_enabled(pb->power_supply))
 		return FB_BLANK_POWERDOWN;
 
+	/* The pwm is disabled, keep it like this */
+	if (!pwm_is_enabled(pb->pwm))
+		return FB_BLANK_POWERDOWN;
+
 	return FB_BLANK_UNBLANK;
 }
 
-- 
2.10.0

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: thierry.reding@gmail.com, jingoohan1@gmail.com, lee.jones@linaro.org
Cc: tomi.valkeinen@ti.com, linux-pwm@vger.kernel.org,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	p.zabel@pengutronix.de
Subject: [PATCH 2/2] backlight: pwm_bl: Check the pwm state for initial backlight power state
Date: Fri, 30 Sep 2016 07:02:59 +0000	[thread overview]
Message-ID: <20160930070259.5710-3-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20160930070259.5710-1-peter.ujfalusi@ti.com>

If the pwm is not enabled the backlight initially should not be enabled
either if we have booted with DT and there is a phandle pointing to the
backlight node.

The patch extends the checks to decide if we should keep the backlight off
initially.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/video/backlight/pwm_bl.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 9bc4715bf116..e4326bbf807f 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -223,6 +223,10 @@ static int pwm_backlight_initial_power_state(const struct pwm_bl_data *pb)
 	if (!regulator_is_enabled(pb->power_supply))
 		return FB_BLANK_POWERDOWN;
 
+	/* The pwm is disabled, keep it like this */
+	if (!pwm_is_enabled(pb->pwm))
+		return FB_BLANK_POWERDOWN;
+
 	return FB_BLANK_UNBLANK;
 }
 
-- 
2.10.0


  parent reply	other threads:[~2016-09-30  7:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-30  7:02 [PATCH 0/2] backlight: pwm_bl: Fix the initial power state selection Peter Ujfalusi
2016-09-30  7:02 ` Peter Ujfalusi
2016-09-30  7:02 ` Peter Ujfalusi
2016-09-30  7:02 ` [PATCH 1/2] backlight: pwm_bl: Move the checks for initial power state to a separate function Peter Ujfalusi
2016-09-30  7:02   ` Peter Ujfalusi
2016-09-30  7:02   ` Peter Ujfalusi
2016-10-26 12:12   ` Lee Jones
2016-10-26 12:12     ` Lee Jones
2016-10-26 13:02     ` Peter Ujfalusi
2016-10-26 13:02       ` Peter Ujfalusi
2016-10-26 13:02       ` Peter Ujfalusi
2016-10-27  7:18       ` Peter Ujfalusi
2016-10-27  7:18         ` Peter Ujfalusi
2016-10-27  7:18         ` Peter Ujfalusi
2016-09-30  7:02 ` Peter Ujfalusi [this message]
2016-09-30  7:02   ` [PATCH 2/2] backlight: pwm_bl: Check the pwm state for initial backlight power state Peter Ujfalusi
2016-09-30  7:02   ` Peter Ujfalusi
2016-10-26 12:13   ` Lee Jones
2016-10-26 12:13     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160930070259.5710-3-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.