[PATCH v3 1/2] staging: iio: cdc: ad7152: Add blank line after

[PATCH v3 1/2] staging: iio: cdc: ad7152: Add blank line after

[Anchal Jain]

declarations to increase readability
Reply-To: 

Add a blank line after a function declaration because local variable
declarations should be seprated from the function's statments by a blank line
to increase the readability of a code.

Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
 drivers/staging/iio/cdc/ad7152.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
index 1962052..f9767e9 100644
--- a/drivers/staging/iio/cdc/ad7152.c
+++ b/drivers/staging/iio/cdc/ad7152.c
@@ -134,6 +134,7 @@ static inline ssize_t ad7152_start_calib(struct device *dev,
 	mutex_unlock(&indio_dev->mlock);
 	return len;
 }
+
 static ssize_t ad7152_start_offset_calib(struct device *dev,
 					 struct device_attribute *attr,
 					 const char *buf,
@@ -142,6 +143,7 @@ static ssize_t ad7152_start_offset_calib(struct device *dev,
 	return ad7152_start_calib(dev, attr, buf, len,
 				  AD7152_CONF_MODE_OFFS_CAL);
 }
+
 static ssize_t ad7152_start_gain_calib(struct device *dev,
 				       struct device_attribute *attr,
 				       const char *buf,
@@ -317,6 +319,7 @@ out:
 	mutex_unlock(&indio_dev->mlock);
 	return ret;
 }
+
 static int ad7152_read_raw(struct iio_dev *indio_dev,
 			   struct iio_chan_spec const *chan,
 			   int *val, int *val2,
@@ -470,6 +473,7 @@ static const struct iio_chan_spec ad7152_channels[] = {
 		BIT(IIO_CHAN_INFO_SCALE),
 	}
 };
+
 /*
  * device probe and remove
  */
-- 
1.9.1

Re: [Outreachy kernel] [PATCH v3 1/2] staging: iio: cdc: ad7152: Add blank line after

[Julia Lawall]

On Sun, 2 Oct 2016, Anchal Jain wrote:

> declarations to increase readability
> Reply-To:
>
> Add a blank line after a function declaration because local variable
> declarations should be seprated from the function's statments by a blank line
> to increase the readability of a code.

The log message is not formatted properly.  It looks like a newline ended
up in the subject line, and the Reply-to is not needed.

There are people who should be on the CC list who are not.  Are you using
the get_maintainer command shown in the Submit a patch section of the
tutorial?

julia

>
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
>  drivers/staging/iio/cdc/ad7152.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/ad7152.c
> index 1962052..f9767e9 100644
> --- a/drivers/staging/iio/cdc/ad7152.c
> +++ b/drivers/staging/iio/cdc/ad7152.c
> @@ -134,6 +134,7 @@ static inline ssize_t ad7152_start_calib(struct device *dev,
>  	mutex_unlock(&indio_dev->mlock);
>  	return len;
>  }
> +
>  static ssize_t ad7152_start_offset_calib(struct device *dev,
>  					 struct device_attribute *attr,
>  					 const char *buf,
> @@ -142,6 +143,7 @@ static ssize_t ad7152_start_offset_calib(struct device *dev,
>  	return ad7152_start_calib(dev, attr, buf, len,
>  				  AD7152_CONF_MODE_OFFS_CAL);
>  }
> +
>  static ssize_t ad7152_start_gain_calib(struct device *dev,
>  				       struct device_attribute *attr,
>  				       const char *buf,
> @@ -317,6 +319,7 @@ out:
>  	mutex_unlock(&indio_dev->mlock);
>  	return ret;
>  }
> +
>  static int ad7152_read_raw(struct iio_dev *indio_dev,
>  			   struct iio_chan_spec const *chan,
>  			   int *val, int *val2,
> @@ -470,6 +473,7 @@ static const struct iio_chan_spec ad7152_channels[] = {
>  		BIT(IIO_CHAN_INFO_SCALE),
>  	}
>  };
> +
>  /*
>   * device probe and remove
>   */
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161002152635.GA4163%40life-desktop.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v3 1/2] staging: iio: cdc: ad7152: Add blank line after

[Anchal Jain]

[-- Attachment #1: Type: text/plain, Size: 2981 bytes --]

yes,

I used the get_maintainer command but In CC I need to add maintainers only
or everyone which listed there?

On Sun, Oct 2, 2016 at 9:02 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:

>
>
> On Sun, 2 Oct 2016, Anchal Jain wrote:
>
> > declarations to increase readability
> > Reply-To:
> >
> > Add a blank line after a function declaration because local variable
> > declarations should be seprated from the function's statments by a blank
> line
> > to increase the readability of a code.
>
> The log message is not formatted properly.  It looks like a newline ended
> up in the subject line, and the Reply-to is not needed.
>
> There are people who should be on the CC list who are not.  Are you using
> the get_maintainer command shown in the Submit a patch section of the
> tutorial?
>
> julia
>
> >
> > Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> > ---
> >  drivers/staging/iio/cdc/ad7152.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/cdc/
> ad7152.c
> > index 1962052..f9767e9 100644
> > --- a/drivers/staging/iio/cdc/ad7152.c
> > +++ b/drivers/staging/iio/cdc/ad7152.c
> > @@ -134,6 +134,7 @@ static inline ssize_t ad7152_start_calib(struct
> device *dev,
> >       mutex_unlock(&indio_dev->mlock);
> >       return len;
> >  }
> > +
> >  static ssize_t ad7152_start_offset_calib(struct device *dev,
> >                                        struct device_attribute *attr,
> >                                        const char *buf,
> > @@ -142,6 +143,7 @@ static ssize_t ad7152_start_offset_calib(struct
> device *dev,
> >       return ad7152_start_calib(dev, attr, buf, len,
> >                                 AD7152_CONF_MODE_OFFS_CAL);
> >  }
> > +
> >  static ssize_t ad7152_start_gain_calib(struct device *dev,
> >                                      struct device_attribute *attr,
> >                                      const char *buf,
> > @@ -317,6 +319,7 @@ out:
> >       mutex_unlock(&indio_dev->mlock);
> >       return ret;
> >  }
> > +
> >  static int ad7152_read_raw(struct iio_dev *indio_dev,
> >                          struct iio_chan_spec const *chan,
> >                          int *val, int *val2,
> > @@ -470,6 +473,7 @@ static const struct iio_chan_spec ad7152_channels[]
> = {
> >               BIT(IIO_CHAN_INFO_SCALE),
> >       }
> >  };
> > +
> >  /*
> >   * device probe and remove
> >   */
> > --
> > 1.9.1
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/
> msgid/outreachy-kernel/20161002152635.GA4163%40life-desktop.
> > For more options, visit https://groups.google.com/d/optout.
> >
>

[-- Attachment #2: Type: text/html, Size: 4473 bytes --]

Re: [PATCH v3 1/2] staging: iio: cdc: ad7152: Add blank line after

[Greg KH]

On Sun, Oct 02, 2016 at 08:56:43PM +0530, Anchal Jain wrote:
> declarations to increase readability
> Reply-To: 

What are these lines for?  They shouldn't be here :(

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH v3 1/2] staging: iio: cdc: ad7152: Add blank line after

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 3819 bytes --]



On Sun, 2 Oct 2016, Anchal Jain wrote:

> yes,
>
> I used the get_maintainer command but In CC I need to add maintainers only
> or everyone which listed there?

The command that is shown in the Submit a patch section only gives
maintainers.  If you run get_maintainer in some other way, you will indeed
get people who are not maintainers.

julia

>
> On Sun, Oct 2, 2016 at 9:02 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>       On Sun, 2 Oct 2016, Anchal Jain wrote:
>
>       > declarations to increase readability
>       > Reply-To:
>       >
>       > Add a blank line after a function declaration because local
>       variable
>       > declarations should be seprated from the function's statments
>       by a blank line
>       > to increase the readability of a code.
>
>       The log message is not formatted properly.  It looks like a
>       newline ended
>       up in the subject line, and the Reply-to is not needed.
>
>       There are people who should be on the CC list who are not.  Are
>       you using
>       the get_maintainer command shown in the Submit a patch section
>       of the
>       tutorial?
>
>       julia
>
>       >
>       > Signed-off-by: Anchal Jain <anchalj109@gmail.com>
>       > ---
>       >  drivers/staging/iio/cdc/ad7152.c | 4 ++++
>       >  1 file changed, 4 insertions(+)
>       >
>       > diff --git a/drivers/staging/iio/cdc/ad7152.c
>       b/drivers/staging/iio/cdc/ad7152.c
>       > index 1962052..f9767e9 100644
>       > --- a/drivers/staging/iio/cdc/ad7152.c
>       > +++ b/drivers/staging/iio/cdc/ad7152.c
>       > @@ -134,6 +134,7 @@ static inline ssize_t
>       ad7152_start_calib(struct device *dev,
>       >       mutex_unlock(&indio_dev->mlock);
>       >       return len;
>       >  }
>       > +
>       >  static ssize_t ad7152_start_offset_calib(struct device *dev,
>       >                                        struct
>       device_attribute *attr,
>       >                                        const char *buf,
>       > @@ -142,6 +143,7 @@ static ssize_t
>       ad7152_start_offset_calib(struct device *dev,
>       >       return ad7152_start_calib(dev, attr, buf, len,
>       >                                 AD7152_CONF_MODE_OFFS_CAL);
>       >  }
>       > +
>       >  static ssize_t ad7152_start_gain_calib(struct device *dev,
>       >                                      struct device_attribute
>       *attr,
>       >                                      const char *buf,
>       > @@ -317,6 +319,7 @@ out:
>       >       mutex_unlock(&indio_dev->mlock);
>       >       return ret;
>       >  }
>       > +
>       >  static int ad7152_read_raw(struct iio_dev *indio_dev,
>       >                          struct iio_chan_spec const *chan,
>       >                          int *val, int *val2,
>       > @@ -470,6 +473,7 @@ static const struct iio_chan_spec
>       ad7152_channels[] = {
>       >               BIT(IIO_CHAN_INFO_SCALE),
>       >       }
>       >  };
>       > +
>       >  /*
>       >   * device probe and remove
>       >   */
>       > --
>       > 1.9.1
>       >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it,
> send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to
> outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20161002152635.GA4163%4
> 0life-desktop.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
>
>
>