* [PATCH] xfs: add XBF_XBF_NO_IOACCT to buf trace output
@ 2016-09-08 21:53 Eric Sandeen
2016-10-03 15:01 ` Eric Sandeen
2016-10-03 15:31 ` Brian Foster
0 siblings, 2 replies; 4+ messages in thread
From: Eric Sandeen @ 2016-09-08 21:53 UTC (permalink / raw)
To: xfs-oss, linux-xfs
When XBF_NO_IOACCT got added, it missed the translation
in XFS_BUF_FLAGS, so we see "0x8" in trace output rather
than the flag name. Fix it.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h
index 1c2e52b..424f6b0 100644
--- a/fs/xfs/xfs_buf.h
+++ b/fs/xfs/xfs_buf.h
@@ -71,6 +71,7 @@ typedef unsigned int xfs_buf_flags_t;
{ XBF_READ, "READ" }, \
{ XBF_WRITE, "WRITE" }, \
{ XBF_READ_AHEAD, "READ_AHEAD" }, \
+ { XBF_NO_IOACCT, "NO_IOACCT" }, \
{ XBF_ASYNC, "ASYNC" }, \
{ XBF_DONE, "DONE" }, \
{ XBF_STALE, "STALE" }, \
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] xfs: add XBF_XBF_NO_IOACCT to buf trace output
2016-09-08 21:53 [PATCH] xfs: add XBF_XBF_NO_IOACCT to buf trace output Eric Sandeen
@ 2016-10-03 15:01 ` Eric Sandeen
2016-10-03 15:31 ` Brian Foster
1 sibling, 0 replies; 4+ messages in thread
From: Eric Sandeen @ 2016-10-03 15:01 UTC (permalink / raw)
To: Eric Sandeen, linux-xfs
Ping?
On 9/8/16 4:53 PM, Eric Sandeen wrote:
> When XBF_NO_IOACCT got added, it missed the translation
> in XFS_BUF_FLAGS, so we see "0x8" in trace output rather
> than the flag name. Fix it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h
> index 1c2e52b..424f6b0 100644
> --- a/fs/xfs/xfs_buf.h
> +++ b/fs/xfs/xfs_buf.h
> @@ -71,6 +71,7 @@ typedef unsigned int xfs_buf_flags_t;
> { XBF_READ, "READ" }, \
> { XBF_WRITE, "WRITE" }, \
> { XBF_READ_AHEAD, "READ_AHEAD" }, \
> + { XBF_NO_IOACCT, "NO_IOACCT" }, \
> { XBF_ASYNC, "ASYNC" }, \
> { XBF_DONE, "DONE" }, \
> { XBF_STALE, "STALE" }, \
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xfs: add XBF_XBF_NO_IOACCT to buf trace output
2016-09-08 21:53 [PATCH] xfs: add XBF_XBF_NO_IOACCT to buf trace output Eric Sandeen
2016-10-03 15:01 ` Eric Sandeen
@ 2016-10-03 15:31 ` Brian Foster
2016-11-10 16:41 ` Eric Sandeen
1 sibling, 1 reply; 4+ messages in thread
From: Brian Foster @ 2016-10-03 15:31 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Thu, Sep 08, 2016 at 04:53:28PM -0500, Eric Sandeen wrote:
> When XBF_NO_IOACCT got added, it missed the translation
> in XFS_BUF_FLAGS, so we see "0x8" in trace output rather
> than the flag name. Fix it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Thought I caught that, apparently not. Thanks!
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h
> index 1c2e52b..424f6b0 100644
> --- a/fs/xfs/xfs_buf.h
> +++ b/fs/xfs/xfs_buf.h
> @@ -71,6 +71,7 @@ typedef unsigned int xfs_buf_flags_t;
> { XBF_READ, "READ" }, \
> { XBF_WRITE, "WRITE" }, \
> { XBF_READ_AHEAD, "READ_AHEAD" }, \
> + { XBF_NO_IOACCT, "NO_IOACCT" }, \
> { XBF_ASYNC, "ASYNC" }, \
> { XBF_DONE, "DONE" }, \
> { XBF_STALE, "STALE" }, \
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xfs: add XBF_XBF_NO_IOACCT to buf trace output
2016-10-03 15:31 ` Brian Foster
@ 2016-11-10 16:41 ` Eric Sandeen
0 siblings, 0 replies; 4+ messages in thread
From: Eric Sandeen @ 2016-11-10 16:41 UTC (permalink / raw)
To: Brian Foster, Eric Sandeen; +Cc: linux-xfs, Dave Chinner
On 10/3/16 10:31 AM, Brian Foster wrote:
> On Thu, Sep 08, 2016 at 04:53:28PM -0500, Eric Sandeen wrote:
>> When XBF_NO_IOACCT got added, it missed the translation
>> in XFS_BUF_FLAGS, so we see "0x8" in trace output rather
>> than the flag name. Fix it.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>
> Thought I caught that, apparently not. Thanks!
>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
Dave, ping on a merge for this? It has Brian's review.
Thanks,
-Eric
>>
>> diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h
>> index 1c2e52b..424f6b0 100644
>> --- a/fs/xfs/xfs_buf.h
>> +++ b/fs/xfs/xfs_buf.h
>> @@ -71,6 +71,7 @@ typedef unsigned int xfs_buf_flags_t;
>> { XBF_READ, "READ" }, \
>> { XBF_WRITE, "WRITE" }, \
>> { XBF_READ_AHEAD, "READ_AHEAD" }, \
>> + { XBF_NO_IOACCT, "NO_IOACCT" }, \
>> { XBF_ASYNC, "ASYNC" }, \
>> { XBF_DONE, "DONE" }, \
>> { XBF_STALE, "STALE" }, \
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-10 16:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-08 21:53 [PATCH] xfs: add XBF_XBF_NO_IOACCT to buf trace output Eric Sandeen
2016-10-03 15:01 ` Eric Sandeen
2016-10-03 15:31 ` Brian Foster
2016-11-10 16:41 ` Eric Sandeen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.