All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] serial: ns16550: Handle -ENOENT when requesting clock
@ 2016-09-30  8:37 Alexandre Courbot
  2016-09-30  8:54 ` Alexandre Courbot
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Alexandre Courbot @ 2016-09-30  8:37 UTC (permalink / raw)
  To: u-boot

When calling clk_get_by_index(), fall back to the legacy method of
getting the clock if -ENOENT is returned.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
 drivers/serial/ns16550.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index 765499dab646..29d547166b90 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -408,7 +408,7 @@ int ns16550_serial_ofdata_to_platdata(struct udevice *dev)
 		err = clk_get_rate(&clk);
 		if (!IS_ERR_VALUE(err))
 			plat->clock = err;
-	} else if (err != -ENODEV && err != -ENOSYS) {
+	} else if (err != -ENOENT && err != -ENODEV && err != -ENOSYS) {
 		debug("ns16550 failed to get clock\n");
 		return err;
 	}
-- 
2.10.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] serial: ns16550: Handle -ENOENT when requesting clock
  2016-09-30  8:37 [U-Boot] [PATCH] serial: ns16550: Handle -ENOENT when requesting clock Alexandre Courbot
@ 2016-09-30  8:54 ` Alexandre Courbot
  2016-10-03 16:23 ` Stephen Warren
  2016-10-07  0:32 ` [U-Boot] " Tom Rini
  2 siblings, 0 replies; 5+ messages in thread
From: Alexandre Courbot @ 2016-09-30  8:54 UTC (permalink / raw)
  To: u-boot

On 09/30/2016 05:37 PM, Alexandre Courbot wrote:
> When calling clk_get_by_index(), fall back to the legacy method of
> getting the clock if -ENOENT is returned.

Withdrawing this patch as Thierry sent a better version of it.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] serial: ns16550: Handle -ENOENT when requesting clock
  2016-09-30  8:37 [U-Boot] [PATCH] serial: ns16550: Handle -ENOENT when requesting clock Alexandre Courbot
  2016-09-30  8:54 ` Alexandre Courbot
@ 2016-10-03 16:23 ` Stephen Warren
  2016-10-04 12:37   ` Thierry Reding
  2016-10-07  0:32 ` [U-Boot] " Tom Rini
  2 siblings, 1 reply; 5+ messages in thread
From: Stephen Warren @ 2016-10-03 16:23 UTC (permalink / raw)
  To: u-boot

On 09/30/2016 02:37 AM, Alexandre Courbot wrote:
> When calling clk_get_by_index(), fall back to the legacy method of
> getting the clock if -ENOENT is returned.

Tested-by: Stephen Warren <swarren@nvidia.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] serial: ns16550: Handle -ENOENT when requesting clock
  2016-10-03 16:23 ` Stephen Warren
@ 2016-10-04 12:37   ` Thierry Reding
  0 siblings, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2016-10-04 12:37 UTC (permalink / raw)
  To: u-boot

On Mon, Oct 03, 2016 at 10:23:49AM -0600, Stephen Warren wrote:
> On 09/30/2016 02:37 AM, Alexandre Courbot wrote:
> > When calling clk_get_by_index(), fall back to the legacy method of
> > getting the clock if -ENOENT is returned.
> 
> Tested-by: Stephen Warren <swarren@nvidia.com>

Agreed, this looks like the more correct fix in retrospect.

Acked-by: Thierry Reding <treding@nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161004/38ceb2d4/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] serial: ns16550: Handle -ENOENT when requesting clock
  2016-09-30  8:37 [U-Boot] [PATCH] serial: ns16550: Handle -ENOENT when requesting clock Alexandre Courbot
  2016-09-30  8:54 ` Alexandre Courbot
  2016-10-03 16:23 ` Stephen Warren
@ 2016-10-07  0:32 ` Tom Rini
  2 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2016-10-07  0:32 UTC (permalink / raw)
  To: u-boot

On Fri, Sep 30, 2016 at 05:37:00PM +0900, Alexandre Courbot wrote:

> When calling clk_get_by_index(), fall back to the legacy method of
> getting the clock if -ENOENT is returned.
> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> Tested-by: Stephen Warren <swarren@nvidia.com>
> Acked-by: Thierry Reding <treding@nvidia.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161006/87b6abb9/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-10-07  0:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-30  8:37 [U-Boot] [PATCH] serial: ns16550: Handle -ENOENT when requesting clock Alexandre Courbot
2016-09-30  8:54 ` Alexandre Courbot
2016-10-03 16:23 ` Stephen Warren
2016-10-04 12:37   ` Thierry Reding
2016-10-07  0:32 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.