* [Buildroot] [PATCH v3] package/linux-tools: add gpio
@ 2016-10-03 12:25 Marcin Niestroj
2016-10-03 17:06 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Marcin Niestroj @ 2016-10-03 12:25 UTC (permalink / raw)
To: buildroot
Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
---
Changes v2 -> v3:
* Add info about supported Linux version in Config.in
(suggested by Baruch)
Changes v1 -> v2:
* Adapt to new linux-tools infra, which is moved to package/ directory
(suggested by Yann)
package/linux-tools/Config.in | 12 ++++++++++++
package/linux-tools/linux-tool-gpio.mk | 28 ++++++++++++++++++++++++++++
2 files changed, 40 insertions(+)
create mode 100644 package/linux-tools/linux-tool-gpio.mk
diff --git a/package/linux-tools/Config.in b/package/linux-tools/Config.in
index 61c196f..bd07509 100644
--- a/package/linux-tools/Config.in
+++ b/package/linux-tools/Config.in
@@ -20,6 +20,18 @@ comment "cpupower needs a toolchain w/ wchar"
depends on !BR2_bfin
depends on !BR2_USE_WCHAR && BR2_NEEDS_GETTEXT
+config BR2_PACKAGE_LINUX_TOOLS_GPIO
+ bool "gpio"
+ select BR2_PACKAGE_LINUX_TOOLS
+ help
+ gpio is a collection of tools to get information about,
+ control and monitor gpios present on system.
+
+ These tools use new gpio ABI which will deprecate sysfs gpio
+ interface in the future.
+
+ These tools are available only from kernel version 4.8.
+
config BR2_PACKAGE_LINUX_TOOLS_PERF
bool "perf"
select BR2_PACKAGE_LINUX_TOOLS
diff --git a/package/linux-tools/linux-tool-gpio.mk b/package/linux-tools/linux-tool-gpio.mk
new file mode 100644
index 0000000..db0094a
--- /dev/null
+++ b/package/linux-tools/linux-tool-gpio.mk
@@ -0,0 +1,28 @@
+################################################################################
+#
+# gpio
+#
+################################################################################
+
+LINUX_TOOLS += gpio
+
+GPIO_MAKE_OPTS = CROSS_COMPILE=$(TARGET_CROSS)
+
+define GPIO_BUILD_CMDS
+ $(Q)if ! grep install $(LINUX_DIR)/tools/gpio/Makefile >/dev/null 2>&1 ; then \
+ echo "Your kernel version is too old and does not have the gpio tools." ; \
+ echo "At least kernel 4.8 must be used." ; \
+ exit 1 ; \
+ fi
+
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools \
+ $(GPIO_MAKE_OPTS) \
+ gpio
+endef
+
+define GPIO_INSTALL_TARGET_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools \
+ $(GPIO_MAKE_OPTS) \
+ DESTDIR=$(TARGET_DIR) \
+ gpio_install
+endef
--
2.10.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v3] package/linux-tools: add gpio
2016-10-03 12:25 [Buildroot] [PATCH v3] package/linux-tools: add gpio Marcin Niestroj
@ 2016-10-03 17:06 ` Yann E. MORIN
2016-10-04 6:53 ` Marcin Niestroj
0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2016-10-03 17:06 UTC (permalink / raw)
To: buildroot
Marcin, All,
On 2016-10-03 14:25 +0200, Marcin Niestroj spake thusly:
> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
> ---
> Changes v2 -> v3:
> * Add info about supported Linux version in Config.in
> (suggested by Baruch)
>
> Changes v1 -> v2:
> * Adapt to new linux-tools infra, which is moved to package/ directory
> (suggested by Yann)
>
> package/linux-tools/Config.in | 12 ++++++++++++
> package/linux-tools/linux-tool-gpio.mk | 28 ++++++++++++++++++++++++++++
> 2 files changed, 40 insertions(+)
> create mode 100644 package/linux-tools/linux-tool-gpio.mk
>
> diff --git a/package/linux-tools/Config.in b/package/linux-tools/Config.in
> index 61c196f..bd07509 100644
> --- a/package/linux-tools/Config.in
> +++ b/package/linux-tools/Config.in
> @@ -20,6 +20,18 @@ comment "cpupower needs a toolchain w/ wchar"
> depends on !BR2_bfin
> depends on !BR2_USE_WCHAR && BR2_NEEDS_GETTEXT
>
> +config BR2_PACKAGE_LINUX_TOOLS_GPIO
> + bool "gpio"
> + select BR2_PACKAGE_LINUX_TOOLS
> + help
> + gpio is a collection of tools to get information about,
> + control and monitor gpios present on system.
> +
> + These tools use new gpio ABI which will deprecate sysfs gpio
> + interface in the future.
> +
> + These tools are available only from kernel version 4.8.
> +
> config BR2_PACKAGE_LINUX_TOOLS_PERF
> bool "perf"
> select BR2_PACKAGE_LINUX_TOOLS
> diff --git a/package/linux-tools/linux-tool-gpio.mk b/package/linux-tools/linux-tool-gpio.mk
> new file mode 100644
> index 0000000..db0094a
> --- /dev/null
> +++ b/package/linux-tools/linux-tool-gpio.mk
> @@ -0,0 +1,28 @@
> +################################################################################
> +#
> +# gpio
> +#
> +################################################################################
> +
> +LINUX_TOOLS += gpio
> +
> +GPIO_MAKE_OPTS = CROSS_COMPILE=$(TARGET_CROSS)
Any reason not to use $(LINUX_MAKE_FLAGS) in the first place?
GPIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS)
LINUX_MAKE_FLAGS shall contain all the required variable definitions
needed to build for the target.
Yes, cpupower directly defines CROSS_COMPILE et al., but perf and
selftests do use LINUX_MAKE_FLAGS, and I think we should use that unless
there is a good reason not to.
This would allow use to easily update the compile options/variables.
(Sorry, I forgot to point that out in the previous review...)
Regards,
Yann E. MORIN.
> +define GPIO_BUILD_CMDS
> + $(Q)if ! grep install $(LINUX_DIR)/tools/gpio/Makefile >/dev/null 2>&1 ; then \
> + echo "Your kernel version is too old and does not have the gpio tools." ; \
> + echo "At least kernel 4.8 must be used." ; \
> + exit 1 ; \
> + fi
> +
> + $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools \
> + $(GPIO_MAKE_OPTS) \
> + gpio
> +endef
> +
> +define GPIO_INSTALL_TARGET_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools \
> + $(GPIO_MAKE_OPTS) \
> + DESTDIR=$(TARGET_DIR) \
> + gpio_install
> +endef
> --
> 2.10.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v3] package/linux-tools: add gpio
2016-10-03 17:06 ` Yann E. MORIN
@ 2016-10-04 6:53 ` Marcin Niestroj
2016-10-04 15:42 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Marcin Niestroj @ 2016-10-04 6:53 UTC (permalink / raw)
To: buildroot
Hi,
On 03.10.2016 19:06, Yann E. MORIN wrote:
> Marcin, All,
>
> On 2016-10-03 14:25 +0200, Marcin Niestroj spake thusly:
>> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
>> ---
>> Changes v2 -> v3:
>> * Add info about supported Linux version in Config.in
>> (suggested by Baruch)
>>
>> Changes v1 -> v2:
>> * Adapt to new linux-tools infra, which is moved to package/ directory
>> (suggested by Yann)
>>
>> package/linux-tools/Config.in | 12 ++++++++++++
>> package/linux-tools/linux-tool-gpio.mk | 28 ++++++++++++++++++++++++++++
>> 2 files changed, 40 insertions(+)
>> create mode 100644 package/linux-tools/linux-tool-gpio.mk
>>
>> diff --git a/package/linux-tools/Config.in b/package/linux-tools/Config.in
>> index 61c196f..bd07509 100644
>> --- a/package/linux-tools/Config.in
>> +++ b/package/linux-tools/Config.in
>> @@ -20,6 +20,18 @@ comment "cpupower needs a toolchain w/ wchar"
>> depends on !BR2_bfin
>> depends on !BR2_USE_WCHAR && BR2_NEEDS_GETTEXT
>>
>> +config BR2_PACKAGE_LINUX_TOOLS_GPIO
>> + bool "gpio"
>> + select BR2_PACKAGE_LINUX_TOOLS
>> + help
>> + gpio is a collection of tools to get information about,
>> + control and monitor gpios present on system.
>> +
>> + These tools use new gpio ABI which will deprecate sysfs gpio
>> + interface in the future.
>> +
>> + These tools are available only from kernel version 4.8.
>> +
>> config BR2_PACKAGE_LINUX_TOOLS_PERF
>> bool "perf"
>> select BR2_PACKAGE_LINUX_TOOLS
>> diff --git a/package/linux-tools/linux-tool-gpio.mk b/package/linux-tools/linux-tool-gpio.mk
>> new file mode 100644
>> index 0000000..db0094a
>> --- /dev/null
>> +++ b/package/linux-tools/linux-tool-gpio.mk
>> @@ -0,0 +1,28 @@
>> +################################################################################
>> +#
>> +# gpio
>> +#
>> +################################################################################
>> +
>> +LINUX_TOOLS += gpio
>> +
>> +GPIO_MAKE_OPTS = CROSS_COMPILE=$(TARGET_CROSS)
>
> Any reason not to use $(LINUX_MAKE_FLAGS) in the first place?
>
> GPIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS)
>
> LINUX_MAKE_FLAGS shall contain all the required variable definitions
> needed to build for the target.
>
> Yes, cpupower directly defines CROSS_COMPILE et al., but perf and
> selftests do use LINUX_MAKE_FLAGS, and I think we should use that unless
> there is a good reason not to.
>
> This would allow use to easily update the compile options/variables.
I just did it similar to cpupower package. But using LINUX_MAKE_FLAGS
looks like a better option.
What about specifying also DESTDIR together:
GPIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS) DESTDIR=$(TARGET_DIR)
so we can simplify GPIO_INSTALL_TARGET_CMDS?
This would be similar to perf package.
>
> (Sorry, I forgot to point that out in the previous review...)
>
> Regards,
> Yann E. MORIN.
>
>> +define GPIO_BUILD_CMDS
>> + $(Q)if ! grep install $(LINUX_DIR)/tools/gpio/Makefile >/dev/null 2>&1 ; then \
>> + echo "Your kernel version is too old and does not have the gpio tools." ; \
>> + echo "At least kernel 4.8 must be used." ; \
>> + exit 1 ; \
>> + fi
>> +
>> + $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools \
>> + $(GPIO_MAKE_OPTS) \
>> + gpio
>> +endef
>> +
>> +define GPIO_INSTALL_TARGET_CMDS
>> + $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools \
>> + $(GPIO_MAKE_OPTS) \
>> + DESTDIR=$(TARGET_DIR) \
>> + gpio_install
>> +endef
>> --
>> 2.10.0
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
--
Marcin Niestroj
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v3] package/linux-tools: add gpio
2016-10-04 6:53 ` Marcin Niestroj
@ 2016-10-04 15:42 ` Yann E. MORIN
2016-10-04 22:05 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2016-10-04 15:42 UTC (permalink / raw)
To: buildroot
Marcin, All,
On 2016-10-04 08:53 +0200, Marcin Niestroj spake thusly:
> On 03.10.2016 19:06, Yann E. MORIN wrote:
> >On 2016-10-03 14:25 +0200, Marcin Niestroj spake thusly:
> >>Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
[--SNIP--]
> >>diff --git a/package/linux-tools/linux-tool-gpio.mk b/package/linux-tools/linux-tool-gpio.mk
> >>new file mode 100644
> >>index 0000000..db0094a
> >>--- /dev/null
> >>+++ b/package/linux-tools/linux-tool-gpio.mk
> >>@@ -0,0 +1,28 @@
> >>+################################################################################
> >>+#
> >>+# gpio
> >>+#
> >>+################################################################################
> >>+
> >>+LINUX_TOOLS += gpio
> >>+
> >>+GPIO_MAKE_OPTS = CROSS_COMPILE=$(TARGET_CROSS)
> >
> >Any reason not to use $(LINUX_MAKE_FLAGS) in the first place?
> >
> > GPIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS)
> >
> >LINUX_MAKE_FLAGS shall contain all the required variable definitions
> >needed to build for the target.
> >
> >Yes, cpupower directly defines CROSS_COMPILE et al., but perf and
> >selftests do use LINUX_MAKE_FLAGS, and I think we should use that unless
> >there is a good reason not to.
> >
> >This would allow use to easily update the compile options/variables.
>
> I just did it similar to cpupower package. But using LINUX_MAKE_FLAGS
> looks like a better option.
>
> What about specifying also DESTDIR together:
> GPIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS) DESTDIR=$(TARGET_DIR)
> so we can simplify GPIO_INSTALL_TARGET_CMDS?
> This would be similar to perf package.
No, please specify DESTDIR only at install time.
Regards,
Yann E. MORIN.
> >(Sorry, I forgot to point that out in the previous review...)
> >
> >Regards,
> >Yann E. MORIN.
> >
> >>+define GPIO_BUILD_CMDS
> >>+ $(Q)if ! grep install $(LINUX_DIR)/tools/gpio/Makefile >/dev/null 2>&1 ; then \
> >>+ echo "Your kernel version is too old and does not have the gpio tools." ; \
> >>+ echo "At least kernel 4.8 must be used." ; \
> >>+ exit 1 ; \
> >>+ fi
> >>+
> >>+ $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools \
> >>+ $(GPIO_MAKE_OPTS) \
> >>+ gpio
> >>+endef
> >>+
> >>+define GPIO_INSTALL_TARGET_CMDS
> >>+ $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools \
> >>+ $(GPIO_MAKE_OPTS) \
> >>+ DESTDIR=$(TARGET_DIR) \
> >>+ gpio_install
> >>+endef
> >>--
> >>2.10.0
> >>
> >>_______________________________________________
> >>buildroot mailing list
> >>buildroot at busybox.net
> >>http://lists.busybox.net/mailman/listinfo/buildroot
> >
>
> --
> Marcin Niestroj
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v3] package/linux-tools: add gpio
2016-10-04 15:42 ` Yann E. MORIN
@ 2016-10-04 22:05 ` Arnout Vandecappelle
2016-10-05 6:38 ` Marcin Niestroj
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2016-10-04 22:05 UTC (permalink / raw)
To: buildroot
On 04-10-16 17:42, Yann E. MORIN wrote:
> Marcin, All,
>
> On 2016-10-04 08:53 +0200, Marcin Niestroj spake thusly:
>> On 03.10.2016 19:06, Yann E. MORIN wrote:
>>> On 2016-10-03 14:25 +0200, Marcin Niestroj spake thusly:
>>>> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
> [--SNIP--]
>>>> diff --git a/package/linux-tools/linux-tool-gpio.mk b/package/linux-tools/linux-tool-gpio.mk
>>>> new file mode 100644
>>>> index 0000000..db0094a
>>>> --- /dev/null
>>>> +++ b/package/linux-tools/linux-tool-gpio.mk
>>>> @@ -0,0 +1,28 @@
>>>> +################################################################################
>>>> +#
>>>> +# gpio
>>>> +#
>>>> +################################################################################
>>>> +
>>>> +LINUX_TOOLS += gpio
>>>> +
>>>> +GPIO_MAKE_OPTS = CROSS_COMPILE=$(TARGET_CROSS)
>>>
>>> Any reason not to use $(LINUX_MAKE_FLAGS) in the first place?
>>>
>>> GPIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS)
>>>
>>> LINUX_MAKE_FLAGS shall contain all the required variable definitions
>>> needed to build for the target.
>>>
>>> Yes, cpupower directly defines CROSS_COMPILE et al., but perf and
>>> selftests do use LINUX_MAKE_FLAGS, and I think we should use that unless
>>> there is a good reason not to.
>>>
>>> This would allow use to easily update the compile options/variables.
>>
>> I just did it similar to cpupower package. But using LINUX_MAKE_FLAGS
>> looks like a better option.
>>
>> What about specifying also DESTDIR together:
>> GPIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS) DESTDIR=$(TARGET_DIR)
>> so we can simplify GPIO_INSTALL_TARGET_CMDS?
>> This would be similar to perf package.
>
> No, please specify DESTDIR only at install time.
This is because in general, there may also be installation to staging or
images, and in those cases DESTDIR should be STAGING_DIR resp. IMAGES_DIR. So
adding DESTDIR to the general _MAKE_OPTS is semantically incorrect.
Regards,
Arnout
>
> Regards,
> Yann E. MORIN.
>
>>> (Sorry, I forgot to point that out in the previous review...)
>>>
>>> Regards,
>>> Yann E. MORIN.
>>>
>>>> +define GPIO_BUILD_CMDS
>>>> + $(Q)if ! grep install $(LINUX_DIR)/tools/gpio/Makefile >/dev/null 2>&1 ; then \
>>>> + echo "Your kernel version is too old and does not have the gpio tools." ; \
>>>> + echo "At least kernel 4.8 must be used." ; \
>>>> + exit 1 ; \
>>>> + fi
>>>> +
>>>> + $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools \
>>>> + $(GPIO_MAKE_OPTS) \
>>>> + gpio
>>>> +endef
>>>> +
>>>> +define GPIO_INSTALL_TARGET_CMDS
>>>> + $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools \
>>>> + $(GPIO_MAKE_OPTS) \
>>>> + DESTDIR=$(TARGET_DIR) \
>>>> + gpio_install
>>>> +endef
>>>> --
>>>> 2.10.0
>>>>
>>>> _______________________________________________
>>>> buildroot mailing list
>>>> buildroot at busybox.net
>>>> http://lists.busybox.net/mailman/listinfo/buildroot
>>>
>>
>> --
>> Marcin Niestroj
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v3] package/linux-tools: add gpio
2016-10-04 22:05 ` Arnout Vandecappelle
@ 2016-10-05 6:38 ` Marcin Niestroj
0 siblings, 0 replies; 6+ messages in thread
From: Marcin Niestroj @ 2016-10-05 6:38 UTC (permalink / raw)
To: buildroot
On 05.10.2016 00:05, Arnout Vandecappelle wrote:
>
>
> On 04-10-16 17:42, Yann E. MORIN wrote:
>> Marcin, All,
>>
>> On 2016-10-04 08:53 +0200, Marcin Niestroj spake thusly:
>>> On 03.10.2016 19:06, Yann E. MORIN wrote:
>>>> On 2016-10-03 14:25 +0200, Marcin Niestroj spake thusly:
>>>>> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
>> [--SNIP--]
>>>>> diff --git a/package/linux-tools/linux-tool-gpio.mk b/package/linux-tools/linux-tool-gpio.mk
>>>>> new file mode 100644
>>>>> index 0000000..db0094a
>>>>> --- /dev/null
>>>>> +++ b/package/linux-tools/linux-tool-gpio.mk
>>>>> @@ -0,0 +1,28 @@
>>>>> +################################################################################
>>>>> +#
>>>>> +# gpio
>>>>> +#
>>>>> +################################################################################
>>>>> +
>>>>> +LINUX_TOOLS += gpio
>>>>> +
>>>>> +GPIO_MAKE_OPTS = CROSS_COMPILE=$(TARGET_CROSS)
>>>>
>>>> Any reason not to use $(LINUX_MAKE_FLAGS) in the first place?
>>>>
>>>> GPIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS)
>>>>
>>>> LINUX_MAKE_FLAGS shall contain all the required variable definitions
>>>> needed to build for the target.
>>>>
>>>> Yes, cpupower directly defines CROSS_COMPILE et al., but perf and
>>>> selftests do use LINUX_MAKE_FLAGS, and I think we should use that unless
>>>> there is a good reason not to.
>>>>
>>>> This would allow use to easily update the compile options/variables.
>>>
>>> I just did it similar to cpupower package. But using LINUX_MAKE_FLAGS
>>> looks like a better option.
>>>
>>> What about specifying also DESTDIR together:
>>> GPIO_MAKE_OPTS = $(LINUX_MAKE_FLAGS) DESTDIR=$(TARGET_DIR)
>>> so we can simplify GPIO_INSTALL_TARGET_CMDS?
>>> This would be similar to perf package.
>>
>> No, please specify DESTDIR only at install time.
>
> This is because in general, there may also be installation to staging or
> images, and in those cases DESTDIR should be STAGING_DIR resp. IMAGES_DIR. So
> adding DESTDIR to the general _MAKE_OPTS is semantically incorrect.
Thanks for clarifying that!
>
> Regards,
> Arnout
>
>>
>> Regards,
>> Yann E. MORIN.
>>
>>>> (Sorry, I forgot to point that out in the previous review...)
>>>>
>>>> Regards,
>>>> Yann E. MORIN.
>>>>
>>>>> +define GPIO_BUILD_CMDS
>>>>> + $(Q)if ! grep install $(LINUX_DIR)/tools/gpio/Makefile >/dev/null 2>&1 ; then \
>>>>> + echo "Your kernel version is too old and does not have the gpio tools." ; \
>>>>> + echo "At least kernel 4.8 must be used." ; \
>>>>> + exit 1 ; \
>>>>> + fi
>>>>> +
>>>>> + $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools \
>>>>> + $(GPIO_MAKE_OPTS) \
>>>>> + gpio
>>>>> +endef
>>>>> +
>>>>> +define GPIO_INSTALL_TARGET_CMDS
>>>>> + $(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools \
>>>>> + $(GPIO_MAKE_OPTS) \
>>>>> + DESTDIR=$(TARGET_DIR) \
>>>>> + gpio_install
>>>>> +endef
>>>>> --
>>>>> 2.10.0
>>>>>
>>>>> _______________________________________________
>>>>> buildroot mailing list
>>>>> buildroot at busybox.net
>>>>> http://lists.busybox.net/mailman/listinfo/buildroot
>>>>
>>>
>>> --
>>> Marcin Niestroj
>>
>
--
Marcin Niestroj
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-05 6:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-03 12:25 [Buildroot] [PATCH v3] package/linux-tools: add gpio Marcin Niestroj
2016-10-03 17:06 ` Yann E. MORIN
2016-10-04 6:53 ` Marcin Niestroj
2016-10-04 15:42 ` Yann E. MORIN
2016-10-04 22:05 ` Arnout Vandecappelle
2016-10-05 6:38 ` Marcin Niestroj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.