From: Mark Rutland <mark.rutland@arm.com> To: Neil Leeder <nleeder@codeaurora.org> Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Langsdorf <mlangsdo@redhat.com>, Mark Salter <msalter@redhat.com>, Jon Masters <jcm@redhat.com>, Timur Tabi <timur@codeaurora.org>, cov@codeaurora.org Subject: Re: [PATCH v6] soc: qcom: add l2 cache perf events driver Date: Tue, 4 Oct 2016 16:53:04 +0100 [thread overview] Message-ID: <20161004155304.GB29008@leverpostej> (raw) In-Reply-To: <1474492374-12140-1-git-send-email-nleeder@codeaurora.org> Hi Neil, On Wed, Sep 21, 2016 at 05:12:54PM -0400, Neil Leeder wrote: > Adds perf events support for L2 cache PMU. > > The L2 cache PMU driver is named 'l2cache_0' and can be used > with perf events to profile L2 events such as cache hits > and misses. > > Signed-off-by: Neil Leeder <nleeder@codeaurora.org> > --- > drivers/soc/qcom/Kconfig | 9 + > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/perf_event_l2.c | 948 +++++++++++++++++++++++++++++++++++++++ > include/linux/cpuhotplug.h | 1 + > 4 files changed, 959 insertions(+) > create mode 100644 drivers/soc/qcom/perf_event_l2.c Apologies for the delay; this has been on my todo list, but I've been a little distracted and haven't had the time necessary to devote to this. It's somewhat unusual given the constraint logic and the percpu uncore component, so there's more to consider than usual. At a high level, this will need to be moved to drivers/perf/, per [1]. Can you move the driver there, and post the result atop of v4.8-rc1 at the end of the merge window? Until then, I can't guarantee that I'll have the time to look at this. Can you also give Vince's perf fuzzer [2] a spin against the driver? I can't recall if we covered that previously, and in practice it's found a number of issues in drivers that have otherwise looked fine. If you've done so, it'd be worth noting in the cover. Thanks, Mark. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-September/457188.html [2] https://github.com/deater/perf_event_tests
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v6] soc: qcom: add l2 cache perf events driver Date: Tue, 4 Oct 2016 16:53:04 +0100 [thread overview] Message-ID: <20161004155304.GB29008@leverpostej> (raw) In-Reply-To: <1474492374-12140-1-git-send-email-nleeder@codeaurora.org> Hi Neil, On Wed, Sep 21, 2016 at 05:12:54PM -0400, Neil Leeder wrote: > Adds perf events support for L2 cache PMU. > > The L2 cache PMU driver is named 'l2cache_0' and can be used > with perf events to profile L2 events such as cache hits > and misses. > > Signed-off-by: Neil Leeder <nleeder@codeaurora.org> > --- > drivers/soc/qcom/Kconfig | 9 + > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/perf_event_l2.c | 948 +++++++++++++++++++++++++++++++++++++++ > include/linux/cpuhotplug.h | 1 + > 4 files changed, 959 insertions(+) > create mode 100644 drivers/soc/qcom/perf_event_l2.c Apologies for the delay; this has been on my todo list, but I've been a little distracted and haven't had the time necessary to devote to this. It's somewhat unusual given the constraint logic and the percpu uncore component, so there's more to consider than usual. At a high level, this will need to be moved to drivers/perf/, per [1]. Can you move the driver there, and post the result atop of v4.8-rc1 at the end of the merge window? Until then, I can't guarantee that I'll have the time to look at this. Can you also give Vince's perf fuzzer [2] a spin against the driver? I can't recall if we covered that previously, and in practice it's found a number of issues in drivers that have otherwise looked fine. If you've done so, it'd be worth noting in the cover. Thanks, Mark. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-September/457188.html [2] https://github.com/deater/perf_event_tests
next prev parent reply other threads:[~2016-10-04 15:53 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-09-21 21:12 [PATCH v6] soc: qcom: add l2 cache perf events driver Neil Leeder 2016-09-21 21:12 ` Neil Leeder 2016-10-04 14:35 ` Neil Leeder 2016-10-04 14:35 ` Neil Leeder 2016-10-04 15:53 ` Mark Rutland [this message] 2016-10-04 15:53 ` Mark Rutland 2016-10-04 16:25 ` Neil Leeder 2016-10-04 16:25 ` Neil Leeder 2016-10-28 16:02 ` Will Deacon 2016-10-28 16:02 ` Will Deacon 2016-10-28 18:17 ` Leeder, Neil 2016-10-28 18:17 ` Leeder, Neil 2016-10-28 18:17 ` Leeder, Neil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161004155304.GB29008@leverpostej \ --to=mark.rutland@arm.com \ --cc=acme@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=cov@codeaurora.org \ --cc=jcm@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=mlangsdo@redhat.com \ --cc=msalter@redhat.com \ --cc=nleeder@codeaurora.org \ --cc=peterz@infradead.org \ --cc=timur@codeaurora.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.