* [PATCH] drm/bridge: Call drm_connector_cleanup directly
@ 2016-10-04 22:23 Marek Vasut
2016-10-05 9:03 ` Gustavo Padovan
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2016-10-04 22:23 UTC (permalink / raw)
To: dri-devel; +Cc: Marek Vasut, Daniel Vetter
Remove the unnecessary wrapper functions around drm_connector_cleanup().
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/bridge/analogix-anx78xx.c | 7 +------
drivers/gpu/drm/bridge/nxp-ptn3460.c | 7 +------
drivers/gpu/drm/bridge/parade-ps8622.c | 7 +------
3 files changed, 3 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix-anx78xx.c
index f9f03bc..a2a8236 100644
--- a/drivers/gpu/drm/bridge/analogix-anx78xx.c
+++ b/drivers/gpu/drm/bridge/analogix-anx78xx.c
@@ -1001,16 +1001,11 @@ static enum drm_connector_status anx78xx_detect(struct drm_connector *connector,
return connector_status_connected;
}
-static void anx78xx_connector_destroy(struct drm_connector *connector)
-{
- drm_connector_cleanup(connector);
-}
-
static const struct drm_connector_funcs anx78xx_connector_funcs = {
.dpms = drm_atomic_helper_connector_dpms,
.fill_modes = drm_helper_probe_single_connector_modes,
.detect = anx78xx_detect,
- .destroy = anx78xx_connector_destroy,
+ .destroy = drm_connector_cleanup,
.reset = drm_atomic_helper_connector_reset,
.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c
index 93f3dac..f1a9993 100644
--- a/drivers/gpu/drm/bridge/nxp-ptn3460.c
+++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c
@@ -245,16 +245,11 @@ static enum drm_connector_status ptn3460_detect(struct drm_connector *connector,
return connector_status_connected;
}
-static void ptn3460_connector_destroy(struct drm_connector *connector)
-{
- drm_connector_cleanup(connector);
-}
-
static const struct drm_connector_funcs ptn3460_connector_funcs = {
.dpms = drm_atomic_helper_connector_dpms,
.fill_modes = drm_helper_probe_single_connector_modes,
.detect = ptn3460_detect,
- .destroy = ptn3460_connector_destroy,
+ .destroy = drm_connector_cleanup,
.reset = drm_atomic_helper_connector_reset,
.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c
index f1b39a2..6f7c2f9 100644
--- a/drivers/gpu/drm/bridge/parade-ps8622.c
+++ b/drivers/gpu/drm/bridge/parade-ps8622.c
@@ -483,16 +483,11 @@ static enum drm_connector_status ps8622_detect(struct drm_connector *connector,
return connector_status_connected;
}
-static void ps8622_connector_destroy(struct drm_connector *connector)
-{
- drm_connector_cleanup(connector);
-}
-
static const struct drm_connector_funcs ps8622_connector_funcs = {
.dpms = drm_atomic_helper_connector_dpms,
.fill_modes = drm_helper_probe_single_connector_modes,
.detect = ps8622_detect,
- .destroy = ps8622_connector_destroy,
+ .destroy = drm_connector_cleanup,
.reset = drm_atomic_helper_connector_reset,
.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
--
2.9.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/bridge: Call drm_connector_cleanup directly
2016-10-04 22:23 [PATCH] drm/bridge: Call drm_connector_cleanup directly Marek Vasut
@ 2016-10-05 9:03 ` Gustavo Padovan
2016-10-05 13:21 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo Padovan @ 2016-10-05 9:03 UTC (permalink / raw)
To: Marek Vasut; +Cc: Daniel Vetter, dri-devel
Hi Marek,
2016-10-05 Marek Vasut <marex@denx.de>:
> Remove the unnecessary wrapper functions around drm_connector_cleanup().
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/bridge/analogix-anx78xx.c | 7 +------
> drivers/gpu/drm/bridge/nxp-ptn3460.c | 7 +------
> drivers/gpu/drm/bridge/parade-ps8622.c | 7 +------
> 3 files changed, 3 insertions(+), 18 deletions(-)
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/bridge: Call drm_connector_cleanup directly
2016-10-05 9:03 ` Gustavo Padovan
@ 2016-10-05 13:21 ` Daniel Vetter
2016-10-05 14:06 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2016-10-05 13:21 UTC (permalink / raw)
To: Gustavo Padovan, Marek Vasut, dri-devel, Daniel Vetter
On Wed, Oct 05, 2016 at 11:03:20AM +0200, Gustavo Padovan wrote:
> Hi Marek,
>
> 2016-10-05 Marek Vasut <marex@denx.de>:
>
> > Remove the unnecessary wrapper functions around drm_connector_cleanup().
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> > drivers/gpu/drm/bridge/analogix-anx78xx.c | 7 +------
> > drivers/gpu/drm/bridge/nxp-ptn3460.c | 7 +------
> > drivers/gpu/drm/bridge/parade-ps8622.c | 7 +------
> > 3 files changed, 3 insertions(+), 18 deletions(-)
>
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Yeah, nice little cleanup. Applied to drm-misc.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/bridge: Call drm_connector_cleanup directly
2016-10-05 13:21 ` Daniel Vetter
@ 2016-10-05 14:06 ` Marek Vasut
2016-10-05 14:20 ` Gustavo Padovan
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2016-10-05 14:06 UTC (permalink / raw)
To: Daniel Vetter, Gustavo Padovan, dri-devel, Daniel Vetter
On 10/05/2016 03:21 PM, Daniel Vetter wrote:
> On Wed, Oct 05, 2016 at 11:03:20AM +0200, Gustavo Padovan wrote:
>> Hi Marek,
>>
>> 2016-10-05 Marek Vasut <marex@denx.de>:
>>
>>> Remove the unnecessary wrapper functions around drm_connector_cleanup().
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>>> ---
>>> drivers/gpu/drm/bridge/analogix-anx78xx.c | 7 +------
>>> drivers/gpu/drm/bridge/nxp-ptn3460.c | 7 +------
>>> drivers/gpu/drm/bridge/parade-ps8622.c | 7 +------
>>> 3 files changed, 3 insertions(+), 18 deletions(-)
>>
>> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> Yeah, nice little cleanup. Applied to drm-misc.
So while we're at it, I also found drivers with code like [1]. Is
calling the drm_connector_unregister() necessary in there at all ?
Or shall we convert it the same way as the three drivers above ?
[1]
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/bridge/tc358767.c#n1168
> -Daniel
>
--
Best regards,
Marek Vasut
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/bridge: Call drm_connector_cleanup directly
2016-10-05 14:06 ` Marek Vasut
@ 2016-10-05 14:20 ` Gustavo Padovan
2016-10-05 14:32 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo Padovan @ 2016-10-05 14:20 UTC (permalink / raw)
To: Marek Vasut; +Cc: Daniel Vetter, dri-devel
Hi Marek,
2016-10-05 Marek Vasut <marex@denx.de>:
> On 10/05/2016 03:21 PM, Daniel Vetter wrote:
> > On Wed, Oct 05, 2016 at 11:03:20AM +0200, Gustavo Padovan wrote:
> >> Hi Marek,
> >>
> >> 2016-10-05 Marek Vasut <marex@denx.de>:
> >>
> >>> Remove the unnecessary wrapper functions around drm_connector_cleanup().
> >>>
> >>> Signed-off-by: Marek Vasut <marex@denx.de>
> >>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> >>> ---
> >>> drivers/gpu/drm/bridge/analogix-anx78xx.c | 7 +------
> >>> drivers/gpu/drm/bridge/nxp-ptn3460.c | 7 +------
> >>> drivers/gpu/drm/bridge/parade-ps8622.c | 7 +------
> >>> 3 files changed, 3 insertions(+), 18 deletions(-)
> >>
> >> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >
> > Yeah, nice little cleanup. Applied to drm-misc.
>
> So while we're at it, I also found drivers with code like [1]. Is
> calling the drm_connector_unregister() necessary in there at all ?
> Or shall we convert it the same way as the three drivers above ?
drm_connector_register/unregister() are not necessary anymore as this is
handled by drm_dev_register() now. So these drivers can be clean up as
well.
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/bridge: Call drm_connector_cleanup directly
2016-10-05 14:20 ` Gustavo Padovan
@ 2016-10-05 14:32 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2016-10-05 14:32 UTC (permalink / raw)
To: Gustavo Padovan, Daniel Vetter, dri-devel, Daniel Vetter
On 10/05/2016 04:20 PM, Gustavo Padovan wrote:
> Hi Marek,
>
> 2016-10-05 Marek Vasut <marex@denx.de>:
>
>> On 10/05/2016 03:21 PM, Daniel Vetter wrote:
>>> On Wed, Oct 05, 2016 at 11:03:20AM +0200, Gustavo Padovan wrote:
>>>> Hi Marek,
>>>>
>>>> 2016-10-05 Marek Vasut <marex@denx.de>:
>>>>
>>>>> Remove the unnecessary wrapper functions around drm_connector_cleanup().
>>>>>
>>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>>>>> ---
>>>>> drivers/gpu/drm/bridge/analogix-anx78xx.c | 7 +------
>>>>> drivers/gpu/drm/bridge/nxp-ptn3460.c | 7 +------
>>>>> drivers/gpu/drm/bridge/parade-ps8622.c | 7 +------
>>>>> 3 files changed, 3 insertions(+), 18 deletions(-)
>>>>
>>>> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>>>
>>> Yeah, nice little cleanup. Applied to drm-misc.
>>
>> So while we're at it, I also found drivers with code like [1]. Is
>> calling the drm_connector_unregister() necessary in there at all ?
>> Or shall we convert it the same way as the three drivers above ?
>
> drm_connector_register/unregister() are not necessary anymore as this is
> handled by drm_dev_register() now. So these drivers can be clean up as
> well.
OK, got it. Patch is out.
--
Best regards,
Marek Vasut
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-05 14:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-04 22:23 [PATCH] drm/bridge: Call drm_connector_cleanup directly Marek Vasut
2016-10-05 9:03 ` Gustavo Padovan
2016-10-05 13:21 ` Daniel Vetter
2016-10-05 14:06 ` Marek Vasut
2016-10-05 14:20 ` Gustavo Padovan
2016-10-05 14:32 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.