All of lore.kernel.org
 help / color / mirror / Atom feed
* Duplicate MDIO_XGENE Kconfig entries
@ 2016-10-06 16:01 Laura Abbott
  2016-10-06 16:37 ` Andrew Lunn
  0 siblings, 1 reply; 2+ messages in thread
From: Laura Abbott @ 2016-10-06 16:01 UTC (permalink / raw)
  To: Andrew Lunn, Florian Fainelli
  Cc: David S. Miller, netdev, Linux Kernel Mailing List

Hi,

While working on the Fedora tree today, I noticed that there
seem to be two entries for CONFIG_MDIO_XGENE. It looks like
this might have been fall out from d75b4a22b255 ("net: phy:
Sort Makefile and Kconfig"). I can submit the following if
this isn't fixed up elsewhere already

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index 5078a0d..fe064ba 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -141,6 +141,7 @@ config MDIO_THUNDER
           device.
  
  config MDIO_XGENE
+       depends on ARCH_XGENE || COMPILE_TEST
         tristate "APM X-Gene SoC MDIO bus controller"
         help
           This module provides a driver for the MDIO busses found in the
@@ -320,13 +321,6 @@ config XILINX_GMII2RGMII
           the Reduced Gigabit Media Independent Interface(RGMII) between
           Ethernet physical media devices and the Gigabit Ethernet controller.
  
-config MDIO_XGENE
-       tristate "APM X-Gene SoC MDIO bus controller"
-       depends on ARCH_XGENE || COMPILE_TEST
-       help
-         This module provides a driver for the MDIO busses found in the
-         APM X-Gene SoC's.
-
  endif # PHYLIB
  
  config MICREL_KS8995MA

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Duplicate MDIO_XGENE Kconfig entries
  2016-10-06 16:01 Duplicate MDIO_XGENE Kconfig entries Laura Abbott
@ 2016-10-06 16:37 ` Andrew Lunn
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2016-10-06 16:37 UTC (permalink / raw)
  To: Laura Abbott
  Cc: Florian Fainelli, David S. Miller, netdev, Linux Kernel Mailing List

On Thu, Oct 06, 2016 at 09:01:27AM -0700, Laura Abbott wrote:
> Hi,
> 
> While working on the Fedora tree today, I noticed that there
> seem to be two entries for CONFIG_MDIO_XGENE. It looks like
> this might have been fall out from d75b4a22b255 ("net: phy:
> Sort Makefile and Kconfig"). I can submit the following if
> this isn't fixed up elsewhere already

Hi Laura

I don't remember seeing a fix for this going by. Please do submit a
follow up.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-06 16:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-06 16:01 Duplicate MDIO_XGENE Kconfig entries Laura Abbott
2016-10-06 16:37 ` Andrew Lunn

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.