Re: [PATCH 00/15] Fifteen multipath-tools patches

Re: [PATCH 00/15] Fifteen multipath-tools patches

[tang.junhui]

[-- Attachment #1.1.1: Type: text/plain, Size: 1994 bytes --]

Hello Bart,



"0007-multipathd-Fix-a-data-race.patch"

This patch solved the data race problem, 

but the assignment for paths check interval has no effect,

since there is no path in vecs when calling init_path_check_interval(vecs) in child(),

I think it is better to call  init_path_check_interval(vecs) at reconfigure() or configure() 

after the paths has created in vecs .




Thanks,

Tang























原始邮件



发件人：ChristopheVaroqui
收件人：Bart Van Assche
抄送人：device-mapper development
日 期 ：2016年10月05日 14:56
主 题 ：Re: [dm-devel] [PATCH 00/15] Fifteen multipath-tools patches





The set is merged.I just added a patch to fix the drd include in debug.c

Thanks,
Christophe




On Tue, Oct 4, 2016 at 7:36 PM, Bart Van Assche ＜bart.vanassche@sandisk.com＞ wrote:
Hello Christophe,
 
 As promised I am sending you the multipath-tools patches from my local repository. The names of these patches are:
 
 0001-libmultipath-prioritizers-ontap-Remove-an-unused-inc.patch
 0002-libmultipath-memory-Move-an-include-directive.patch
 0003-libmultipath-checkers-tur-Declare-local-functions-st.patch
 0004-libmultipath-checkers-rbd-Declare-local-functions-st.patch
 0005-multipathd-libmultipathd-Make-delays-independent-of-.patch
 0006-multipathd-Suppress-uninteresting-data-race-reports.patch
 0007-multipathd-Fix-a-data-race.patch
 0008-libmultipath-checkers-tur-Introduce-strlcpy.patch
 0009-libmultipath-checkers-tur-Terminate-a-statement-with.patch
 0010-libmultipath-checkers-tur-Move-pthread_attr_destroy-.patch
 0011-libmultipath-checkers-tur-Protect-tur_checker_contex.patch
 0012-libmultipath-checkers-tur-Serialize-tur_checker_cont.patch
 0013-libmultipath-checkers-tur-Fix-races-on-tur_checker_c.patch
 0014-libmultipath-Micro-optimize-snprint_size.patch
 0015-Makefile.inc-Enable-Wextra-and-Wformat-nonliteral.patch
 
 Thanks,
 
 Bart.

[-- Attachment #1.1.2: Type: text/html , Size: 3885 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH 00/15] Fifteen multipath-tools patches

[Bart Van Assche]

On 10/07/2016 07:05 PM, tang.junhui@zte.com.cn wrote:
> "0007-multipathd-Fix-a-data-race.patch"
>
> This patch solved the data race problem,
>
> but the assignment for paths check interval has no effect,
>
> since there is no path in vecs when calling
> init_path_check_interval(vecs) in child(),
>
> I think it is better to call
>  init_path_check_interval(vecs) at reconfigure() or configure()
>
> after the paths has created in vecs .

Hello Tang,

If init_path_check_interval() doesn't have any effect then I propose to 
remove that function. pp->checkint is namely already initialized in 
cli_add_path().

Bart.

Re: [PATCH 00/15] Fifteen multipath-tools patches

[tang.junhui]

[-- Attachment #1.1: Type: text/plain, Size: 1237 bytes --]

Hello Bart,
I also think that we do not need init_path_check_interval()，
since pp->checkint is initialized in configure() too.

Cheers,
Tang




发件人:         Bart Van Assche <bart.vanassche@sandisk.com>
收件人:         <tang.junhui@zte.com.cn>, 
<christophe.varoqui@opensvc.com>, 
抄送:   bart.vanassche@sandisk.com, dm-devel@redhat.com
日期:   2016/10/11 04:41
主题:   Re: [dm-devel] [PATCH 00/15] Fifteen multipath-tools patches
发件人: dm-devel-bounces@redhat.com



On 10/07/2016 07:05 PM, tang.junhui@zte.com.cn wrote:
> "0007-multipathd-Fix-a-data-race.patch"
>
> This patch solved the data race problem,
>
> but the assignment for paths check interval has no effect,
>
> since there is no path in vecs when calling
> init_path_check_interval(vecs) in child(),
>
> I think it is better to call
>  init_path_check_interval(vecs) at reconfigure() or configure()
>
> after the paths has created in vecs .

Hello Tang,

If init_path_check_interval() doesn't have any effect then I propose to 
remove that function. pp->checkint is namely already initialized in 
cli_add_path().

Bart.

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel



[-- Attachment #1.2: Type: text/html, Size: 2640 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH 00/15] Fifteen multipath-tools patches

[Christophe Varoqui]

[-- Attachment #1.1: Type: text/plain, Size: 1279 bytes --]

The set is merged.
I just added a patch to fix the drd include in debug.c

Thanks,
Christophe

On Tue, Oct 4, 2016 at 7:36 PM, Bart Van Assche <bart.vanassche@sandisk.com>
wrote:

> Hello Christophe,
>
> As promised I am sending you the multipath-tools patches from my local
> repository. The names of these patches are:
>
> 0001-libmultipath-prioritizers-ontap-Remove-an-unused-inc.patch
> 0002-libmultipath-memory-Move-an-include-directive.patch
> 0003-libmultipath-checkers-tur-Declare-local-functions-st.patch
> 0004-libmultipath-checkers-rbd-Declare-local-functions-st.patch
> 0005-multipathd-libmultipathd-Make-delays-independent-of-.patch
> 0006-multipathd-Suppress-uninteresting-data-race-reports.patch
> 0007-multipathd-Fix-a-data-race.patch
> 0008-libmultipath-checkers-tur-Introduce-strlcpy.patch
> 0009-libmultipath-checkers-tur-Terminate-a-statement-with.patch
> 0010-libmultipath-checkers-tur-Move-pthread_attr_destroy-.patch
> 0011-libmultipath-checkers-tur-Protect-tur_checker_contex.patch
> 0012-libmultipath-checkers-tur-Serialize-tur_checker_cont.patch
> 0013-libmultipath-checkers-tur-Fix-races-on-tur_checker_c.patch
> 0014-libmultipath-Micro-optimize-snprint_size.patch
> 0015-Makefile.inc-Enable-Wextra-and-Wformat-nonliteral.patch
>
> Thanks,
>
> Bart.
>

[-- Attachment #1.2: Type: text/html, Size: 1818 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

[PATCH 00/15] Fifteen multipath-tools patches

[Bart Van Assche]

Hello Christophe,

As promised I am sending you the multipath-tools patches from my local 
repository. The names of these patches are:

0001-libmultipath-prioritizers-ontap-Remove-an-unused-inc.patch
0002-libmultipath-memory-Move-an-include-directive.patch
0003-libmultipath-checkers-tur-Declare-local-functions-st.patch
0004-libmultipath-checkers-rbd-Declare-local-functions-st.patch
0005-multipathd-libmultipathd-Make-delays-independent-of-.patch
0006-multipathd-Suppress-uninteresting-data-race-reports.patch
0007-multipathd-Fix-a-data-race.patch
0008-libmultipath-checkers-tur-Introduce-strlcpy.patch
0009-libmultipath-checkers-tur-Terminate-a-statement-with.patch
0010-libmultipath-checkers-tur-Move-pthread_attr_destroy-.patch
0011-libmultipath-checkers-tur-Protect-tur_checker_contex.patch
0012-libmultipath-checkers-tur-Serialize-tur_checker_cont.patch
0013-libmultipath-checkers-tur-Fix-races-on-tur_checker_c.patch
0014-libmultipath-Micro-optimize-snprint_size.patch
0015-Makefile.inc-Enable-Wextra-and-Wformat-nonliteral.patch

Thanks,

Bart.