* [U-Boot] [PATCH] cmd: Make CMD_USB_MASS_STORAGE visible only with USB_GADGET and default y
@ 2016-09-19 16:40 Tom Rini
2016-10-08 17:06 ` [U-Boot] " Tom Rini
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rini @ 2016-09-19 16:40 UTC (permalink / raw)
To: u-boot
In order for CMD_USB_MASS_STORAGE to be useful we must have USB_GADGET
enabled, so only show this option when USB_GADGET is set. In addition,
expand the help text so it's clearer what this does and given the
overall utility of this command, make it enabled by default.
Signed-off-by: Tom Rini <trini@konsulko.com>
---
cmd/Kconfig | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index d28da54ed659..ddbd5a82d80f 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -408,10 +408,14 @@ config CMD_DFU
Enables the command "dfu" which is used to have U-Boot create a DFU
class device via USB.
+if USB_GADGET
config CMD_USB_MASS_STORAGE
bool "UMS usb mass storage"
+ default y
help
- USB mass storage support
+ Enables the command "ums" which is used to have U-Boot expose
+ local storage such as eMMC as a USB Mass Storage Device class device.
+endif
config CMD_FPGA
bool "fpga"
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] cmd: Make CMD_USB_MASS_STORAGE visible only with USB_GADGET and default y
2016-09-19 16:40 [U-Boot] [PATCH] cmd: Make CMD_USB_MASS_STORAGE visible only with USB_GADGET and default y Tom Rini
@ 2016-10-08 17:06 ` Tom Rini
2016-10-08 17:12 ` Tom Rini
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rini @ 2016-10-08 17:06 UTC (permalink / raw)
To: u-boot
On Mon, Sep 19, 2016 at 12:40:12PM -0400, Tom Rini wrote:
> In order for CMD_USB_MASS_STORAGE to be useful we must have USB_GADGET
> enabled, so only show this option when USB_GADGET is set. In addition,
> expand the help text so it's clearer what this does and given the
> overall utility of this command, make it enabled by default.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161008/2eae7c40/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] cmd: Make CMD_USB_MASS_STORAGE visible only with USB_GADGET and default y
2016-10-08 17:06 ` [U-Boot] " Tom Rini
@ 2016-10-08 17:12 ` Tom Rini
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-10-08 17:12 UTC (permalink / raw)
To: u-boot
On Sat, Oct 08, 2016 at 01:06:26PM -0400, Tom Rini wrote:
> On Mon, Sep 19, 2016 at 12:40:12PM -0400, Tom Rini wrote:
>
> > In order for CMD_USB_MASS_STORAGE to be useful we must have USB_GADGET
> > enabled, so only show this option when USB_GADGET is set. In addition,
> > expand the help text so it's clearer what this does and given the
> > overall utility of this command, make it enabled by default.
> >
> > Signed-off-by: Tom Rini <trini@konsulko.com>
>
> Applied to u-boot/master, thanks!
No, no it's not. This needs a bit more work as it exposes some
backend options that need to be migrated first, and it also needs to
depend on USB_GADGET_DOWNLOAD being set as we need to have the IDs set
and can't (well, shouldn't) force values there. So this is really a
changes requested.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161008/aa08c8c9/attachment-0001.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-08 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-19 16:40 [U-Boot] [PATCH] cmd: Make CMD_USB_MASS_STORAGE visible only with USB_GADGET and default y Tom Rini
2016-10-08 17:06 ` [U-Boot] " Tom Rini
2016-10-08 17:12 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.